60518bd · typeable/wai

git.iko.soy/typeable/wai

Change "Http2" to "HTTP2" globally

This seems to be the accepted naming style for initialisms here; previously the two styles were clashing in the same identifiers in warp-tls.

commit60518bdfef9853a4dd320db776368442dbfa8cd8 authorAndrew Pritchard <awpr@google.com> dateThu 6 Aug 2015, 22:45 (11 years ago) parent2bceea0

7 files changed+41−41

compare with master

unifiedsplit

wai/Network/Wai/HTTP2.hs+2−2 warp-tls/Network/Wai/Handler/WarpTLS.hs+8−8 warp/Network/Wai/Handler/Warp.hs+4−4 warp/Network/Wai/Handler/Warp/HTTP2.hs+4−4 warp/Network/Wai/Handler/Warp/HTTP2/Worker.hs+4−4 warp/Network/Wai/Handler/Warp/Internal.hs+1−1 warp/Network/Wai/Handler/Warp/Run.hs+18−18

wai/Network/Wai/HTTP2.hs+2−2

@@ -1,6 +1,6 @@

11{-# LANGUAGE OverloadedStrings, RankNTypes #-}

22module Network.Wai.HTTP2

3− ( Http2Application

3+ ( HTTP2Application

44 , PushPromise(..)

55 , RespondFunc

66 , Responder

@@ -30,7 +30,7 @@ data PushPromise = PushPromise

3030 }

3131

3232-- | The HTTP\/2-aware equivalent of 'Network.Wai.Application'.

33−type Http2Application = Request -> PushFunc -> Responder

33+type HTTP2Application = Request -> PushFunc -> Responder

3434

3535type Body a = (Builder -> IO ()) -> IO () -> IO a

3636

warp-tls/Network/Wai/Handler/WarpTLS.hs+8−8

@@ -35,8 +35,8 @@ module Network.Wai.Handler.WarpTLS (

3535 -- * Runner

3636 , runTLS

3737 , runTLSSocket

38− , runHttp2TLS

39− , runHttp2TLSSocket

38+ , runHTTP2TLS

39+ , runHTTP2TLSSocket

4040 -- * Exception

4141 , WarpTLSException (..)

4242 ) where

@@ -59,7 +59,7 @@ import Network.Socket.ByteString (sendAll)

5959import qualified Network.TLS as TLS

6060import qualified Network.TLS.Extra as TLSExtra

6161import Network.Wai (Application)

62−import Network.Wai.HTTP2 (Http2Application)

62+import Network.Wai.HTTP2 (HTTP2Application)

6363import Network.Wai.Handler.Warp

6464import Network.Wai.Handler.Warp.Internal

6565import System.IO.Error (isEOFError)

@@ -220,7 +220,7 @@ tlsSettingsChainMemory cert chainCerts key = defaultTlsSettings

220220

221221----------------------------------------------------------------

222222

223−-- Composition over two arguments at once; used for runHttp2\*.

223+-- Composition over two arguments at once; used for runHTTP2\*.

224224(.:) :: (c -> d) -> (a -> b -> c) -> a -> b -> d

225225f .: g = curry $ f . uncurry g

226226

@@ -228,8 +228,8 @@ f .: g = curry $ f . uncurry g

228228runTLS :: TLSSettings -> Settings -> Application -> IO ()

229229runTLS tset set = runServeTLS tset set . serveDefault

230230

231−runHttp2TLS :: TLSSettings -> Settings -> Http2Application -> Application -> IO ()

232−runHttp2TLS tset set = runServeTLS tset set .: serveHttp2

231+runHTTP2TLS :: TLSSettings -> Settings -> HTTP2Application -> Application -> IO ()

232+runHTTP2TLS tset set = runServeTLS tset set .: serveHTTP2

233233

234234runServeTLS :: TLSSettings -> Settings -> ServeConnection -> IO ()

235235runServeTLS tset set serve = withSocketsDo $

@@ -247,8 +247,8 @@ runTLSSocket tset set sock = runServeTLSSocket tset set sock . serveDefault

247247

248248-- | Run an HTTP/2-aware server with 'TLSSettings' and 'Settings' using

249249-- specified 'Socket'.

250−runHttp2TLSSocket :: TLSSettings -> Settings -> Socket -> Http2Application -> Application -> IO ()

251−runHttp2TLSSocket tset set sock = runServeTLSSocket tset set sock .: serveHttp2

250+runHTTP2TLSSocket :: TLSSettings -> Settings -> Socket -> HTTP2Application -> Application -> IO ()

251+runHTTP2TLSSocket tset set sock = runServeTLSSocket tset set sock .: serveHTTP2

252252

253253runServeTLSSocket :: TLSSettings -> Settings -> Socket -> ServeConnection -> IO ()

254254runServeTLSSocket tlsset@TLSSettings{..} set sock serve = do

warp/Network/Wai/Handler/Warp.hs+4−4

@@ -49,10 +49,10 @@ module Network.Wai.Handler.Warp (

4949 -- 'Application' to be used for HTTP\/1.1 and HTTP\/1 connections. These

5050 -- are only needed if your application needs access to HTTP\/2-specific

5151 -- features such as trailers or pushed streams.

52− , runHttp2

53− , runHttp2Env

54− , runHttp2Settings

55− , runHttp2SettingsSocket

52+ , runHTTP2

53+ , runHTTP2Env

54+ , runHTTP2Settings

55+ , runHTTP2SettingsSocket

5656 -- * Settings

5757 , Settings

5858 , defaultSettings

warp/Network/Wai/Handler/Warp/HTTP2.hs+4−4

@@ -17,7 +17,7 @@ import Network.HTTP2

1717import Network.Socket (SockAddr)

1818

1919import Network.Wai (Application, responseToStream)

20−import Network.Wai.HTTP2 (Http2Application)

20+import Network.Wai.HTTP2 (HTTP2Application)

2121import Network.Wai.Internal (ResponseReceived(..))

2222import Network.Wai.Handler.Warp.HTTP2.EncodeFrame

2323import Network.Wai.Handler.Warp.HTTP2.Manager

@@ -31,7 +31,7 @@ import Network.Wai.Handler.Warp.Types

3131

3232----------------------------------------------------------------

3333

34−http2 :: Connection -> InternalInfo -> SockAddr -> Transport -> S.Settings -> (BufSize -> IO ByteString) -> Http2Application -> IO ()

34+http2 :: Connection -> InternalInfo -> SockAddr -> Transport -> S.Settings -> (BufSize -> IO ByteString) -> HTTP2Application -> IO ()

3535http2 conn ii addr transport settings readN app = do

3636 checkTLS

3737 ok <- checkPreface

@@ -74,9 +74,9 @@ goaway Connection{..} etype debugmsg = connSendAll bytestream

7474 where

7575 bytestream = goawayFrame 0 etype debugmsg

7676

77−-- | Promote a normal WAI 'Application' to an 'Http2Application' by ignoring

77+-- | Promote a normal WAI 'Application' to an 'HTTP2Application' by ignoring

7878-- the HTTP/2-specific features.

79−promoteApplication :: Application -> Http2Application

79+promoteApplication :: Application -> HTTP2Application

8080promoteApplication app req _ respond = [] <$ app req respond'

8181 where

8282 respond' r = ResponseReceived <$ (withBody $ respond s h)

warp/Network/Wai/Handler/Warp/HTTP2/Worker.hs+4−4

@@ -27,20 +27,20 @@ import Network.Wai.Handler.Warp.HTTP2.EncodeFrame

2727import Network.Wai.Handler.Warp.HTTP2.Manager

2828import Network.Wai.Handler.Warp.HTTP2.Types

2929import Network.Wai.Handler.Warp.IORef

30−import Network.Wai.HTTP2 (Http2Application, PushPromise, Responder, RespondFunc)

30+import Network.Wai.HTTP2 (HTTP2Application, PushPromise, Responder, RespondFunc)

3131import qualified Network.Wai.Handler.Warp.Settings as S

3232import qualified Network.Wai.Handler.Warp.Timeout as T

3333

3434----------------------------------------------------------------

3535

36−-- | An 'Http2Application' takes a 'RespondFunc'; this type implements that by

36+-- | An 'HTTP2Application' takes a 'RespondFunc'; this type implements that by

3737-- currying some internal arguments.

3838--

3939-- This is the argument to a 'Responder'.

4040type Respond = IO () -> Stream -> TBQueue Sequence -> RespondFunc

4141

4242-- | This function is passed to workers.

43−-- They also pass responses from 'Http2Application's to this function.

43+-- They also pass responses from 'HTTP2Application's to this function.

4444-- This function enqueues commands for the HTTP/2 sender.

4545response :: Context -> Manager -> ThreadContinue -> Respond

4646response ctx mgr tconf tickle strm sq s h strmbdy = do

@@ -125,7 +125,7 @@ instance Exception Break

125125worker :: Context

126126 -> S.Settings

127127 -> T.Manager

128− -> Http2Application

128+ -> HTTP2Application

129129 -> (ThreadContinue -> Respond)

130130 -> IO ()

131131worker ctx@Context{inputQ} set tm app respond = do

warp/Network/Wai/Handler/Warp/Internal.hs+1−1

@@ -19,7 +19,7 @@ module Network.Wai.Handler.Warp.Internal (

1919 -- * ServeConnection

2020 , ServeConnection

2121 , serveDefault

22− , serveHttp2

22+ , serveHTTP2

2323 -- * Connection

2424 , Connection (..)

2525 , socketConnection

warp/Network/Wai/Handler/Warp/Run.hs+18−18

@@ -21,7 +21,7 @@ import Network (sClose, Socket)

2121import Network.Socket (accept, withSocketsDo, SockAddr(SockAddrInet, SockAddrInet6))

2222import qualified Network.Socket.ByteString as Sock

2323import Network.Wai

24−import Network.Wai.HTTP2 (Http2Application)

24+import Network.Wai.HTTP2 (HTTP2Application)

2525import Network.Wai.Handler.Warp.Buffer

2626import Network.Wai.Handler.Warp.Counter

2727import qualified Network.Wai.Handler.Warp.Date as D

@@ -69,7 +69,7 @@ allowInterrupt :: IO ()

6969allowInterrupt = unblock $ return ()

7070#endif

7171

72−-- Composition over two arguments at once; used for runHttp2\*.

72+-- Composition over two arguments at once; used for runHTTP2\*.

7373(.:) :: (c -> d) -> (a -> b -> c) -> a -> b -> d

7474f .: g = curry $ f . uncurry g

7575

@@ -78,10 +78,10 @@ f .: g = curry $ f . uncurry g

7878run :: Port -> Application -> IO ()

7979run port = runServe port . serveDefault

8080

81−-- | Serve an 'Http2Application' and an 'Application' together on the given

81+-- | Serve an 'HTTP2Application' and an 'Application' together on the given

8282-- port.

83−runHttp2 :: Port -> Http2Application -> Application -> IO ()

84−runHttp2 port = runServe port .: serveHttp2

83+runHTTP2 :: Port -> HTTP2Application -> Application -> IO ()

84+runHTTP2 port = runServe port .: serveHTTP2

8585

8686-- | The generalized form of 'run'.

8787runServe :: Port -> ServeConnection -> IO ()

@@ -96,8 +96,8 @@ runEnv :: Port -> Application -> IO ()

9696runEnv port = runServeEnv port . serveDefault

9797

9898-- | The HTTP\/2-aware form of 'runEnv'.

99−runHttp2Env :: Port -> Http2Application -> Application -> IO ()

100−runHttp2Env port = runServeEnv port .: serveHttp2

99+runHTTP2Env :: Port -> HTTP2Application -> Application -> IO ()

100+runHTTP2Env port = runServeEnv port .: serveHTTP2

101101

102102-- | The generalized form of 'runEnv'.

103103runServeEnv :: Port -> ServeConnection -> IO ()

@@ -119,8 +119,8 @@ runSettings :: Settings -> Application -> IO ()

119119runSettings set = runServeSettings set . serveDefault

120120

121121-- | The HTTP\/2-aware form of 'runSettings'.

122−runHttp2Settings :: Settings -> Http2Application -> Application -> IO ()

123−runHttp2Settings set = runServeSettings set .: serveHttp2

122+runHTTP2Settings :: Settings -> HTTP2Application -> Application -> IO ()

123+runHTTP2Settings set = runServeSettings set .: serveHTTP2

124124

125125-- | The generalized form of 'runSettings'.

126126runServeSettings :: Settings -> ServeConnection -> IO ()

@@ -147,13 +147,13 @@ runSettingsSocket :: Settings -> Socket -> Application -> IO ()

147147runSettingsSocket set socket = runServeSettingsSocket set socket . serveDefault

148148

149149-- | The HTTP\/2-aware form of 'runSettingsSocket'.

150−runHttp2SettingsSocket :: Settings

150+runHTTP2SettingsSocket :: Settings

151151 -> Socket

152− -> Http2Application

152+ -> HTTP2Application

153153 -> Application

154154 -> IO ()

155−runHttp2SettingsSocket set socket =

156− runServeSettingsSocket set socket .: serveHttp2

155+runHTTP2SettingsSocket set socket =

156+ runServeSettingsSocket set socket .: serveHTTP2

157157

158158-- | The generalized form of 'runSettingsSocket'.

159159runServeSettingsSocket :: Settings -> Socket -> ServeConnection -> IO ()

@@ -369,17 +369,17 @@ type ServeConnection = Connection

369369

370370-- Serve an HTTP\/2-aware application, rejecting clients that attempt to use an

371371-- older protocol version.

372−serveHttp2Only :: Http2Application -> ServeConnection

373−serveHttp2Only = error "serveHttp2Only not implemented"

372+serveHTTP2Only :: HTTP2Application -> ServeConnection

373+serveHTTP2Only = error "serveHTTP2Only not implemented"

374374

375375-- Serve an HTTP\/2-unaware Application to a connection over any HTTP version.

376376serveDefault :: Application -> ServeConnection

377−serveDefault = flip serveHttp2 <*> promoteApplication

377+serveDefault = flip serveHTTP2 <*> promoteApplication

378378

379379-- Serve an HTTP\/2-aware application over HTTP\/2 or a backup 'Application'

380380-- over HTTP\/1.1 or HTTP\/1.

381−serveHttp2 :: Http2Application -> Application -> ServeConnection

382−serveHttp2 app2 app conn ii origAddr transport settings = do

381+serveHTTP2 :: HTTP2Application -> Application -> ServeConnection

382+serveHTTP2 app2 app conn ii origAddr transport settings = do

383383 -- fixme: Upgrading to HTTP/2 should be supported.

384384 (h2,bs) <- if isHTTP2 transport then

385385 return (True, "")