on master help sign in
fix if-modified test case, but still fails
commit9b42d06bceeb9292475f31b2f9cd3374cf71b7bc authorGreg Weber <greg@gregweber.info> dateWed 29 Jun 2011, 23:01 (15 years ago) parentc48c4d3
2 files changed+12−4
tests/runtests.hs+8−4 wai-app-static.cabal+4
tests/runtests.hs+8−4
@@ -13,6 +13,9 @@ import qualified Data.Text.Encoding as TE
1313import System.PosixCompat.Files (getFileStatus, modificationTime)
1414import System.IO (stderr, hPutStrLn)
1515
16+import Network.HTTP.Date
17+{-import System.Locale (defaultTimeLocale)-}
18+{-import Data.Time.Format (formatTime)-}
1619
1720import Network.Wai
1821import Network.Wai.Test
@@ -33,7 +36,7 @@ defRequest = Request {
3336, httpVersion = H.http11
3437, serverPort = 80
3538, isSecure = False
36−, remoteHost = Sock.SockAddrUnix "/dev/null"
39+, remoteHost = Sock.SockAddrInet 1 2
3740}
3841
3942setRawPathInfo :: Request -> S8.ByteString -> Request
@@ -143,10 +146,11 @@ main = hspecX $ do
143146 assertNoHeader "Cache-Control" req
144147
145148 it "304 when if-modified-since matches" $ fileServerApp $ do
146− stat <- liftIO $ getFileStatus file
149+ -- formatTime defaultTimeLocale format $
150+ -- let format = "%a, %d %b %Y %X %Z"
151+ stat <- liftIO $ getFileStatus $ "tests/" ++ file
147152 req <- request statFile {
148− -- TODO: need actual time String
149− requestHeaders = [("If-Modified-Since", S8.pack $ show $ modificationTime stat)]
153+ requestHeaders = [("If-Modified-Since", formatHTTPDate . epochTimeToHTTPDate $ modificationTime stat)]
150154 }
151155 assertStatus 304 req
152156 assertNoHeader "Cache-Control" req
wai-app-static.cabal+4
@@ -34,6 +34,7 @@ library
3434 , blaze-builder >= 0.2.1.4 && < 0.4
3535 , base64-bytestring >= 0.1 && < 0.2
3636 , cryptohash >= 0.7 && < 0.8
37+ , http-date
3738 exposed-modules: Network.Wai.Application.Static
3839 ghc-options: -Wall
3940 extensions: CPP
@@ -50,6 +51,9 @@ test-suite runtests
5051 , hspec >= 0.6
5152 , HUnit
5253 , unix-compat >= 0.2 && < 0.3
54+ , time >= 1.1.4 && < 1.3
55+ , old-locale >= 1.0.0.2 && < 1.1
56+ , http-date
5357 , Cabal
5458 , wai-app-static >= 0.3
5559 , wai-test