on master help sign in
Minor cleanups
commitf6cc1a063e8eea4870452015c9b78cf934c93821 authorMichael Snoyman <michael@snoyman.com> dateFri 27 May 2011, 10:35 (15 years ago) parentd18012b
1 file changed+9−8
Network/Wai/Application/Static.hs+9−8
Network/Wai/Application/Static.hs+9−8
@@ -252,7 +252,6 @@ checkPieces fileLookup indices pieces cache req
252252 | T.null $ piecePretty (last pieces) -> (False, True)
253253 | otherwise -> (True, False)
254254
255− let fp = undefined
256255 if not isFile then uncached isFile isFolder
257256 else
258257 case cache of
@@ -311,7 +310,8 @@ defaultDirListing :: StaticDirListing
311310defaultDirListing = StaticDirListing defaultListing []
312311
313312-- IO is for development mode
314−type CheckHashParam = (File -> S8.ByteString -> Bool)
313+-- FIXME: Greg
314+type CheckHashParam = (File -> S8.ByteString -> Bool) -- FIXME Greg: Can you explain the purposes of the parameters here?
315315data CacheSettings = NoCache | Forever CheckHashParam | ETag (File -> IO (Maybe S8.ByteString))
316316
317317oneYear :: Int
@@ -379,7 +379,7 @@ fileSystemLookup prefix pieces = do
379379 if de
380380 then do
381381 entries <- getDirectoryContents fp >>= (mapM $ \name -> do
382− let name' = T.pack name -- FIXME fix/unfix, not sure which
382+ let name' = T.pack name
383383 let fp' = fp ++ '/' : name
384384 fe' <- doesFileExist fp'
385385 return FolderEntry
@@ -394,12 +394,13 @@ type Embedded = Map.Map T.Text EmbeddedEntry
394394
395395data EmbeddedEntry = EEFile S8.ByteString | EEFolder Embedded
396396
397−embeddedLookup :: Embedded -> Pieces -> IO FileLookup -- FIXME broken for unicode path names
397+embeddedLookup :: Embedded -> Pieces -> IO FileLookup
398398embeddedLookup root pieces =
399399 return $ elookup (map piecePretty pieces) root
400400 where
401+ modified = 0 -- FIXME
401402 elookup :: [T.Text] -> Embedded -> FileLookup
402− elookup [] x = FLFolder $ Folder $ map toEntry $ Map.toList x
403+ elookup [] x = FLFolder $ Folder $ map (toEntry modified) $ Map.toList x
403404 elookup [""] x = elookup [] x
404405 elookup (p:ps) x =
405406 case Map.lookup p x of
@@ -410,8 +411,8 @@ embeddedLookup root pieces =
410411 _ -> FLDoesNotExist
411412 Just (EEFolder y) -> elookup ps y
412413
413−toEntry :: (T.Text, EmbeddedEntry) -> FolderEntry
414−toEntry (name, ee) = FolderEntry
414+toEntry :: EpochTime -> (T.Text, EmbeddedEntry) -> FolderEntry
415+toEntry modified (name, ee) = FolderEntry
415416 { feName = name
416417 , feIsFile =
417418 case ee of
@@ -421,7 +422,7 @@ toEntry (name, ee) = FolderEntry
421422 case ee of
422423 EEFile bs -> FileMetaData
423424 { mdName = name
424− , mdModified = 0 -- FIXME
425+ , mdModified = modified
425426 , mdSize = fromIntegral $ S8.length bs
426427 }
427428 EEFolder _ -> FolderMetaData