`cmark`’s pretty-printer matches our output pretty well, with a few differences:
- it puts a space between the fence and the info string for in code blocks;
- it prefers `-` over `*` for bulleted lists (as do I) and it indents them;
- it `\`-escapes certain chars very conservatively;
- it prefers indented/unfenced code blocks if there is no info string; and
- it prefers `*` over `_` (unlike any sane person).
This also shows how the change fixes a number of issues:
- fix2158-1.output.md also illustrates how this change fixes#1809;
- alias-many.output.md and input-parse-errors.output.md show how fenced
code blocks without an info string would use the beginning of the
content as the info string;
- transcripts-round-trip/main.output.md shows how output blocks for
generated `unison` stanzas (which could contain nested fenced blocks)
might not have long-enough fences; and
- error-messages.output.md and generic-parse-errors.output.md show how
Unison errors were reported on the wrong line number (and thus the
printed error lines were also incorrect).
- This commit delays making up inference variables until the
outermost universal quantifiers of a type annotation have
been unwrapped and added to the context. However, failures
can still be generated by putting quantifiers inside other
connectives.
- Previously, the type checker was not using the patterns to inform
which abilities are matched on in cases at all.
- Instead, we walk through all patterns and compile a list of all
abilities involved in matching, then perform a subtype check on
the scrutinee type with a type consisting of all the abilities.
- This strategy seems to be more robust than trying to handle this
case-by-case. In such scenarios, recursion can lead to additional
effects being pushed into the `Request` type that are not informed by
the pattern matching.
- This causes the 1696 transcript to fail appropriately (I believe).
