git.iko.soy/unity8
on xenial help sign in
Removing Rates and Comments section from the UI until the feature is ready
0eb380dDiego Sarmentero
Dash/Apps/AppPreview.qml+7−6
compare with xenial
unifiedsplit
@@ -186,14 +186,15 @@ DashPreview {
186
186
187 ListItem.ThinDivider { }
187 ListItem.ThinDivider { }
188
188
189+ // TODO: This should be added when the feature for reviews/comments is complete.
189− AppReviews {
190+// AppReviews {
190− objectName: "appReviews"
191+// objectName: "appReviews"
191− anchors { left: parent.left; right: parent.right }
192+// anchors { left: parent.left; right: parent.right }
192
193
193− model: root.previewData.infoMap["comments"] ? root.previewData.infoMap["comments"].value : undefined
194+// model: root.previewData.infoMap["comments"] ? root.previewData.infoMap["comments"].value : undefined
194
195
195− onSendReview: root.sendUserReview(review);
196+// onSendReview: root.sendUserReview(review);
196− }
197+// }
197 }
198 }
198 }
199 }
199}
200}
tests/qmltests/Dash/Apps/tst_AppPreview.qml+50−48
@@ -85,9 +85,10 @@ Item {
85 function cleanup() {
85 function cleanup() {
86 root.calls = new Array();
86 root.calls = new Array();
87 sendPreviewSpy.clear();
87 sendPreviewSpy.clear();
88+ // TODO: This should be added when the feature for reviews/comments is complete.
88− var reviewField = findChild(appPreview, "reviewField");
89+// var reviewField = findChild(appPreview, "reviewField");
89− reviewField.focus = false;
90+// reviewField.focus = false;
90− reviewField.text = "";
91+// reviewField.text = "";
91 data.rating = rating.value;
92 data.rating = rating.value;
92 }
93 }
93
94
@@ -116,51 +117,52 @@ Item {
116 compare(rated.text, "8 reviews", "Reviews don't match");
117 compare(rated.text, "8 reviews", "Reviews don't match");
117 }
118 }
118
119
120+ // TODO: This should be added when the feature for reviews/comments is complete.
119− function test_send_review() {
121+// function test_send_review() {
120− var appReviews = findChild(appPreview, "appReviews");
122+// var appReviews = findChild(appPreview, "appReviews");
121− appReviews.sendReview("review");
123+// appReviews.sendReview("review");
122− sendPreviewSpy.wait();
124+// sendPreviewSpy.wait();
123− }
125+// }
124−
126+
125− function test_review_focus() {
127+// function test_review_focus() {
126− var appReviews = findChild(appPreview, "appReviews");
128+// var appReviews = findChild(appPreview, "appReviews");
127− var sendButton = findChild(appReviews, "sendButton");
129+// var sendButton = findChild(appReviews, "sendButton");
128− var reviewField = findChild(appReviews, "reviewField");
130+// var reviewField = findChild(appReviews, "reviewField");
129−
131+
130− compare(reviewField.focus, false, "ReviewField shouldn't have focus");
132+// compare(reviewField.focus, false, "ReviewField shouldn't have focus");
131− compare(appReviews.state, "", "State should be empty");
133+// compare(appReviews.state, "", "State should be empty");
132−
134+
133− mouseClick(reviewField, reviewField.width/2, reviewField.height/2);
135+// mouseClick(reviewField, reviewField.width/2, reviewField.height/2);
134− compare(reviewField.focus, true, "Review Field should have focus");
136+// compare(reviewField.focus, true, "Review Field should have focus");
135− compare(appReviews.state, "editing", "State should be 'editing'");
137+// compare(appReviews.state, "editing", "State should be 'editing'");
136− }
138+// }
137−
139+
138− function test_comments() {
140+// function test_comments() {
139− var commentsArea = findChild(appPreview, "commentsArea");
141+// var commentsArea = findChild(appPreview, "commentsArea");
140− compare(commentsArea.count, 3);
142+// compare(commentsArea.count, 3);
141− for(var i = 0; i < 3; i++) {
143+// for(var i = 0; i < 3; i++) {
142− var username = commentsArea.itemAt(i).children[0].children[0].text
144+// var username = commentsArea.itemAt(i).children[0].children[0].text
143− var rate = commentsArea.itemAt(i).children[0].children[1].children[0].rating
145+// var rate = commentsArea.itemAt(i).children[0].children[1].children[0].rating
144− var date = commentsArea.itemAt(i).children[0].children[1].children[1].text
146+// var date = commentsArea.itemAt(i).children[0].children[1].children[1].text
145− var comment = commentsArea.itemAt(i).children[1].text
147+// var comment = commentsArea.itemAt(i).children[1].text
146− compare(username, comments.value[i][0], "Username don't match");
148+// compare(username, comments.value[i][0], "Username don't match");
147− compare(rate, comments.value[i][1], "Rating don't match");
149+// compare(rate, comments.value[i][1], "Rating don't match");
148− compare(date, comments.value[i][2], "Date don't match");
150+// compare(date, comments.value[i][2], "Date don't match");
149− compare(comment, comments.value[i][3], "Comment don't match");
151+// compare(comment, comments.value[i][3], "Comment don't match");
150− }
152+// }
151− }
153+// }
152−
154+
153− function test_negative_rating() {
155+// function test_negative_rating() {
154− data.rating = -1.0;
156+// data.rating = -1.0;
155− var rated = findChild(appPreview, "reviewsLabel");
157+// var rated = findChild(appPreview, "reviewsLabel");
156− verify(rated.visible == false);
158+// verify(rated.visible == false);
157− var commentsArea = findChild(appPreview, "commentsArea");
159+// var commentsArea = findChild(appPreview, "commentsArea");
158− verify(commentsArea.visible == false);
160+// verify(commentsArea.visible == false);
159− var appReviews = findChild(appPreview, "appReviews");
161+// var appReviews = findChild(appPreview, "appReviews");
160− verify(appReviews.visible == false);
162+// verify(appReviews.visible == false);
161− var buttons = findChild(appPreview, "gridButtons");
163+// var buttons = findChild(appPreview, "gridButtons");
162− verify(buttons.visible == true);
164+// verify(buttons.visible == true);
163− }
165+// }
164
166
165 }
167 }
166}
168}