git.iko.soy/unity8
on xenial help sign in
Hide the greeter OSK if indicators are open and don't show the edge tutorial during an emergency call.

Approved by: Albert Astals Cid

commit14fc032add712274c8fddef3ae417247795dd313 authorMichael Terry <michael.terry@canonical.com> dateTue 13 Sep 2016, 06:53 (10 years ago) parente7d3d6132a8b1f
4 files changed+20−3
compare with xenial
unifiedsplit
qml/Greeter/CoverPage.qml+1−1 qml/Shell.qml+2−1 tests/qmltests/tst_Shell.qml+1−1 tests/qmltests/tst_ShellWithPin.qml+16
qml/Greeter/CoverPage.qml+1−1
@@ -31,7 +31,7 @@ Showable {
3131
3232 property alias infographics: infographics
3333
34− readonly property real showProgress: MathUtils.clamp((width - Math.abs(x)) / width, 0, 1)
34+ readonly property real showProgress: MathUtils.clamp((width - Math.abs(x + launcherOffset)) / width, 0, 1)
3535
3636 signal tease()
3737 signal clicked()
qml/Shell.qml+2−1
@@ -433,6 +433,7 @@ StyledItem {
433433 id: integratedGreeter
434434 Greeter {
435435
436+ enabled: panel.indicators.fullyClosed // hides OSK when panel is open
436437 hides: [launcher, panel.indicators]
437438 tabletMode: shell.usageScenario != "phone"
438439 launcherOffset: launcher.progress
@@ -677,7 +678,7 @@ StyledItem {
677678 objectName: "tutorial"
678679 anchors.fill: parent
679680
680− paused: callManager.hasCalls || !greeter || greeter.shown ||
681+ paused: callManager.hasCalls || !greeter || greeter.active ||
681682 wizard.active
682683 delayed: dialogs.hasActiveDialog || notifications.hasNotification ||
683684 inputMethod.visible ||
tests/qmltests/tst_Shell.qml+1−1
@@ -687,7 +687,7 @@ Rectangle {
687687 waitUntilDashIsFocused();
688688 tryCompare(greeter, "shown", false);
689689 } else {
690− compare(greeter.fullyShown, data.greeterShown);
690+ tryCompare(greeter, "fullyShown", data.greeterShown);
691691 }
692692
693693 var launcher = findChild(shell, "launcherPanel");
tests/qmltests/tst_ShellWithPin.qml+16
@@ -328,6 +328,22 @@ Item {
328328 tryCompare(greeter, "shown", true);
329329 }
330330
331+ function test_emergencyCallPausesTutorial() {
332+ var greeter = findChild(shell, "greeter");
333+ var tutorial = findChild(shell, "tutorial");
334+
335+ AccountsService.demoEdges = true;
336+ enterPin("1234");
337+ tryCompare(tutorial, "paused", false);
338+
339+ LightDM.Greeter.showGreeter();
340+ verify(tutorial.paused);
341+
342+ swipeAwayGreeter(true);
343+ tap(findChild(greeter, "emergencyCallLabel"));
344+ verify(tutorial.paused);
345+ }
346+
331347 function test_failedLoginsCount() {
332348 AccountsService.failedLogins = 0
333349