15d8c4b · unity8 · git.iko.soy

Made the forward compatible so we can continue landing improvements on autopilot to then get back and remove the ugly code in unity.

commit15d8c4bc379c498877ef2d64683a0b720aa3feec authorLeo Arias <leo.arias@canonical.com> dateWed 12 Feb 2014, 22:13 (13 years ago) parent56372c6

2 files changed+19−3

unifiedsplit

tests/autopilot/unity8/shell/__init__.py+11−2

@@ -50,13 +50,22 @@ def disable_qml_mocking(fn):

5050

5151class DragMixin(object):

5252 def _drag(self, x1, y1, x2, y2):

53+ # XXX This ugly code is here just temporarily, waiting for drag

54+ # improvements to land on autopilot so we don't have to access device

55+ # private internal attributes. --elopio - 2014-02-12

5356 cur_x = x1

5457 cur_y = y1

5558 dx = 1.0 * (x2 - x1) / 100

5659 dy = 1.0 * (y2 - y1) / 100

5760 for i in range(0, 100):

58− self.touch._device.finger_move(int(cur_x), int(cur_y))

61+ try:

62+ self.touch._finger_move(int(cur_x), int(cur_y))

63+ except AttributeError:

64+ self.touch._device.finger_move(int(cur_x), int(cur_y))

5965 sleep(0.002)

6066 cur_x += dx

6167 cur_y += dy

62− self.touch._device.finger_move(int(x2), int(y2))

68+ try:

69+ self.touch._finger_move(int(x2), int(y2))

70+ except AttributeError:

71+ self.touch._device.finger_move(int(x2), int(y2))

tests/autopilot/unity8/shell/tests/test_hud.py+8−1

@@ -184,5 +184,12 @@ class TestHud(UnityTestCase, DragMixin):

184184 # we don't.

185185 def _maybe_release_finger(self):

186186 """Only release the finger if it is in fact down."""

187− if self.touch.pressed:

187+ # XXX This ugly code is here just temporarily, waiting for uinput

188+ # improvements to land on autopilot so we don't have to access device

189+ # private internal attributes. --elopio - 2014-02-12

190+ try:

191+ pressed = self.touch._touch_finger is not None

192+ except AttributeError:

193+ pressed = self.touch.pressed

194+ if pressed:

188195 self.touch.release()