18769b8 · unity8 · git.iko.soy

CODING+2−11

compare with xenial

unifiedsplit

@@ -23,16 +23,10 @@ $ cd ~/unity8/trunk

23$ ./build --setup

24

25 this will:

26− - add ppa:ubuntu-unity/next

27 - install the required dependencies to build, as well as run on the desktop

26 - install the required dependencies to build, as well as run on the desktop

28 - it should also install unity-scope-home and unity-lens-application which

27 - it should also install unity-scope-home and unity-lens-application which

29 are technically "recommends", not strict dependencies

28 are technically "recommends", not strict dependencies

30

29

31−Note, once the PPA is added, the script runs apt-get update, if you have

32−any failures associated with it, the build script will bail out of the setup

33−and fail to install all the required dependencies.

34−

35−

36build Unity 8

30build Unity 8

37-------------

31-------------

38

32

@@ -75,14 +69,11 @@ Notes

75Running Unity 8 on devices

69Running Unity 8 on devices

76==========================

70==========================

77- Ubuntu Touch builds are currently only available in 13.10 flavour

71- Ubuntu Touch builds are currently only available in 13.10 flavour

78−- supported hardware should match one those listed here

72+- supported hardware should match one of those listed here

79 https://wiki.ubuntu.com/Touch/Devices#Running_fine

73 https://wiki.ubuntu.com/Touch/Devices#Running_fine

80- follow the Ubuntu Touch install instructions for your chosen device

74- follow the Ubuntu Touch install instructions for your chosen device

81 https://wiki.ubuntu.com/Touch/Install

75 https://wiki.ubuntu.com/Touch/Install

82−- make sure your device is connected to a WiFi network

76+- make sure your device is connected to a network

83−- If you haven’t already or if you’ve just freshly flashed your device

84− make sure you run phablet-network-setup which will allow package updates to

85− the device

86- also make sure you have your SSH key in ~/.ssh/id_rsa.pub (or install one

77- also make sure you have your SSH key in ~/.ssh/id_rsa.pub (or install one

87 on the device yourself)

78 on the device yourself)

88

79

Components/CrossFadeImage.qml+1−3

@@ -85,7 +85,7 @@ Item {

85 Connections {

86 target: __nextImage

87 onStatusChanged: {

88− if (__nextImage.status == Image.Ready || __nextImage.status == Image.Error) {

88+ if (__nextImage.status == Image.Ready) {

89 swapImages();

90 }

91 }

@@ -96,7 +96,6 @@ Item {

96 anchors.fill: parent

97 cache: false

98 asynchronous: true

99− fillMode: Image.PreserveAspectCrop

100 z: 1

99 z: 1

101 }

100 }

102

101

@@ -105,7 +104,6 @@ Item {

105 anchors.fill: parent

104 anchors.fill: parent

106 cache: false

105 cache: false

107 asynchronous: true

106 asynchronous: true

108− fillMode: Image.PreserveAspectCrop

109 z: 0

107 z: 0

110 }

108 }

111

109

Greeter/GreeterContent.qml+1

@@ -37,6 +37,7 @@ MouseArea {

37

38 source: shell.background

39 anchors.fill: parent

40+ crossFade: false

40 fadeInFirst: false

41 fadeInFirst: false

41 }

42 }

42

43

Shell.qml+8−16

@@ -15,7 +15,6 @@

15 */

16

17import QtQuick 2.0

18−import GSettings 1.0

19import Ubuntu.Application 0.1

18import Ubuntu.Application 0.1

20import Ubuntu.Components 0.1

19import Ubuntu.Components 0.1

21import Ubuntu.Gestures 0.1

20import Ubuntu.Gestures 0.1

@@ -42,8 +41,8 @@ FocusScope {

42 height: tablet ? units.gu(100) : applicationArguments.hasGeometry() ? applicationArguments.height() : units.gu(71)

41 height: tablet ? units.gu(100) : applicationArguments.hasGeometry() ? applicationArguments.height() : units.gu(71)

43

42

44 property real edgeSize: units.gu(2)

43 property real edgeSize: units.gu(2)

45− property url defaultBackground: shell.width >= units.gu(60) ? "graphics/tablet_background.jpg" : "graphics/phone_background.jpg"

44+ property url default_background: shell.width >= units.gu(60) ? "graphics/tablet_background.jpg" : "graphics/phone_background.jpg"

46− property url background: backgroundSettings.pictureUri

45+ property url background: default_background

47 readonly property real panelHeight: panel.panelHeight

46 readonly property real panelHeight: panel.panelHeight

48

47

49 property bool dashShown: dash.shown

48 property bool dashShown: dash.shown

@@ -116,11 +115,6 @@ FocusScope {

116 }

115 }

117 }

116 }

118

117

119− GSettings {

120− id: backgroundSettings

121− schema.id: "org.gnome.desktop.background"

122− }

123−

124 VolumeControl {

118 VolumeControl {

125 id: volumeControl

119 id: volumeControl

126 }

120 }

@@ -145,16 +139,12 @@ FocusScope {

145 // through the translucent parts of the shell surface.

139 // through the translucent parts of the shell surface.

146 visible: !fullyCovered && !applicationSurfaceShouldBeSeen

140 visible: !fullyCovered && !applicationSurfaceShouldBeSeen

147

141

148− CrossFadeImage {

142+ Image {

149 id: backgroundImage

143 id: backgroundImage

150− objectName: "backgroundImage"

151 source: shell.background

144 source: shell.background

145+ sourceSize.width: parent.width

146+ sourceSize.height: parent.height

152 anchors.fill: parent

147 anchors.fill: parent

153− onStatusChanged: {

154− if (status == Image.Error) {

155− backgroundSettings.pictureUri = shell.defaultBackground

156− }

157− }

158 }

148 }

159

149

160 Rectangle {

150 Rectangle {

@@ -199,6 +189,7 @@ FocusScope {

199 }

189 }

200 }

190 }

201

191

192+

202 Item {

193 Item {

203 id: stagesOuterContainer

194 id: stagesOuterContainer

204

195

@@ -263,6 +254,7 @@ FocusScope {

263 ignoreUnknownSignals: true

254 ignoreUnknownSignals: true

264 }

255 }

265

256

257+

266 Stage {

258 Stage {

267 id: mainStage

259 id: mainStage

268

260

@@ -438,7 +430,7 @@ FocusScope {

438 onUnlocked: greeter.hide()

430 onUnlocked: greeter.hide()

439 onSelected: {

431 onSelected: {

440 var bgPath = greeter.model.data(uid, LightDM.UserRoles.BackgroundPathRole)

432 var bgPath = greeter.model.data(uid, LightDM.UserRoles.BackgroundPathRole)

441− shell.background = bgPath ? bgPath : defaultBackground

433+ shell.background = bgPath ? bgPath : default_background

442 }

434 }

443

435

444 onLeftTeaserPressedChanged: {

436 onLeftTeaserPressedChanged: {

build−1

@@ -36,7 +36,6 @@ BUILD_TYPE="debug"

36[ $# -eq 1 ] && BUILD_TYPE="$1"

37

38install_dependencies() {

39− [ -f /etc/apt/sources.list.d/ubuntu-unity-next-${DISTRIB_CODENAME}.list ] || sudo add-apt-repository ppa:ubuntu-unity/next || exit 1

40 sudo apt-get update || exit 4

39 sudo apt-get update || exit 4

41 echo "Installing Unity 8 dependencies.."

40 echo "Installing Unity 8 dependencies.."

42 sudo apt-get install devscripts \

41 sudo apt-get install devscripts \

debian/changelog+27

@@ -1,3 +1,30 @@

1+unity8 (7.81.3+13.10.20130807-0ubuntu1) saucy; urgency=low

2+

3+ [ Michał Sawicz ]

4+ * Drop ppa:ubuntu-unity/next.

5+ * Revert revision 161 that causes issues with invalid background.

6+

7+ [ Albert Astals ]

8+ * Fix off by one in the culling condition If you are on 0 and your

9+ height is 1 and viewport starts at 1 you have to be culled since you

10+ are not visible.

11+

12+ [ Ubuntu daily release ]

13+ * Automatic snapshot from revision 168

14+

15+ -- Ubuntu daily release <ps-jenkins@lists.canonical.com> Wed, 07 Aug 2013 02:32:00 +0000

16+

17+unity8 (7.81.3+13.10.20130806-0ubuntu1) saucy; urgency=low

18+

19+ [ Michael Terry ]

20+ * Show the greeter when powerd tells us to, not just whenever we press

21+ the power key. (LP: #1186256)

22+

23+ [ Ubuntu daily release ]

24+ * Automatic snapshot from revision 164

25+

26+ -- Ubuntu daily release <ps-jenkins@lists.canonical.com> Tue, 06 Aug 2013 03:43:01 +0000

27+

1unity8 (7.81.3+13.10.20130805-0ubuntu1) saucy; urgency=low

28unity8 (7.81.3+13.10.20130805-0ubuntu1) saucy; urgency=low

2

29

3 [ Michael Terry ]

30 [ Michael Terry ]

debian/control+1−3

@@ -56,10 +56,8 @@ Description: Indicators client test application

56

57Package: unity8

58Architecture: any

59−Depends: gsettings-desktop-schemas,

60− qmenumodel-qml,

59+Depends: qmenumodel-qml,

61 qtdeclarative5-dee-plugin,

60 qtdeclarative5-dee-plugin,

62− qtdeclarative5-gsettings1.0,

63 qtdeclarative5-ubuntu-ui-toolkit-plugin,

61 qtdeclarative5-ubuntu-ui-toolkit-plugin,

64 qtdeclarative5-unity-notifications-plugin | unity-notifications-impl,

62 qtdeclarative5-unity-notifications-plugin | unity-notifications-impl,

65 qtdeclarative5-xmllistmodel-plugin,

63 qtdeclarative5-xmllistmodel-plugin,

plugins/ListViewWithPageHeader/listviewwithpageheader.cpp+13−1

@@ -1079,7 +1079,19 @@ void ListViewWithPageHeader::layout()

1079 // Then after the loop we'll make sure that if there's another section just below it

1080 // pushed the sticky section up to make it disappear

1081 const qreal topSectionStickPos = m_headerItemShownHeight + contentY() - m_clipItem->y();

1082+ bool showStickySectionItem;

1083+ // We need to show the "top section sticky item" when the position at the "top" of the

1084+ // viewport is bigger than the start of the position of the first visible item

1085+ // i.e. the first visible item starts before the viewport, or when the first

1086+ // visible item starts just at the viewport start and it does not have its own section item

1087+ if (topSectionStickPos > pos) {

1088+ showStickySectionItem = true;

1082− if (topSectionStickPos <= pos) {

1089+ } else if (topSectionStickPos == pos) {

1090+ showStickySectionItem = !item->m_sectionItem;

1091+ } else {

1092+ showStickySectionItem = false;

1093+ }

1094+ if (!showStickySectionItem) {

1083 QQuickItemPrivate::get(m_topSectionItem)->setCulled(true);

1095 QQuickItemPrivate::get(m_topSectionItem)->setCulled(true);

1084 if (item->m_sectionItem) {

1096 if (item->m_sectionItem) {

1085 // This seems it should happen since why would we cull the top section

1097 // This seems it should happen since why would we cull the top section

run_on_device+2−2

@@ -27,8 +27,8 @@ usage() {

27 echo " -k, --keylock Enable a Keyboard lock screen when running"

28 echo ""

29 echo "IMPORTANT:"

30− echo " * Make sure to have the networking and PPAs setup on the device beforehand (phablet-deploy-networking && phablet-ppa-fetch)."

30+ echo " * Make sure to have networking setup on the device beforehand."

31− echo " * Execute that script from a directory containing a branch the shell code."

31+ echo " * Execute that script from a directory containing unity8 code."

32 exit 1

33}

34

tests/data/unity/backgrounds/blue.pngdeleted

Binary file not shown.

tests/data/unity/backgrounds/red.pngdeleted

Binary file not shown.

tests/mocks/CMakeLists.txt−1

@@ -1,4 +1,3 @@

1−add_subdirectory(GSettings)

2add_subdirectory(libusermetrics)

1add_subdirectory(libusermetrics)

3add_subdirectory(LightDM)

2add_subdirectory(LightDM)

4add_subdirectory(QMenuModel)

3add_subdirectory(QMenuModel)

tests/mocks/GSettings/CMakeLists.txtdeleted−31

@@ -1,31 +0,0 @@

1−set(CMAKE_AUTOMOC ON)

2−

3−include(FindPkgConfig)

4−find_package(Qt5Core REQUIRED)

5−find_package(Qt5Quick REQUIRED)

6−

7−include_directories(

8− ${CMAKE_CURRENT_BINARY_DIR}

9− ${Qt5Core_INCLUDE_DIRS}

10− ${Qt5Quick_INCLUDE_DIRS}

11−)

12−

13−add_definitions(-DQT_NO_KEYWORDS)

14−

15−set(GSettingsQML_SOURCES

16− fake_gsettings.cpp

17− plugin.cpp

18−)

19−

20−add_library(FakeGSettingsQml MODULE ${GSettingsQML_SOURCES})

21−target_link_libraries(FakeGSettingsQml

22− ${Qt5Core_LIBRARIES}

23− ${Qt5Quick_LIBRARIES}

24−)

25−

26−qt5_use_modules(FakeGSettingsQml Qml)

27−

28−# copy qmldir file into build directory for shadow builds

29−file(COPY "${CMAKE_CURRENT_SOURCE_DIR}/qmldir"

30− DESTINATION ${CMAKE_CURRENT_BINARY_DIR}

31− )

tests/mocks/GSettings/fake_gsettings.cppdeleted−102

@@ -1,102 +0,0 @@

1−/*

3− *

4− * This program is free software; you can redistribute it and/or modify

5− * it under the terms of the GNU Lesser General Public License as published by

6− * the Free Software Foundation; version 3.

7− *

8− * This program is distributed in the hope that it will be useful,

9− * but WITHOUT ANY WARRANTY; without even the implied warranty of

10− * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

11− * GNU Lesser General Public License for more details.

12− *

13− * You should have received a copy of the GNU Lesser General Public License

14− * along with this program. If not, see <http://www.gnu.org/licenses/>.

15− */

16−

17−#include "fake_gsettings.h"

18−

19−#include <QList>

20−

21−GSettingsControllerQml* GSettingsControllerQml::s_controllerInstance = 0;

22−

23−GSettingsControllerQml::GSettingsControllerQml() {

24−}

25−

26−GSettingsControllerQml::~GSettingsControllerQml() {

27− s_controllerInstance = 0;

28−}

29−

30−GSettingsControllerQml* GSettingsControllerQml::instance() {

31− if(!s_controllerInstance) {

32− s_controllerInstance = new GSettingsControllerQml();

33− }

34− return s_controllerInstance;

35−}

36−

37−void GSettingsControllerQml::registerSettingsObject(GSettingsQml *obj) {

38− m_registeredGSettings.append(obj);

39−}

40−

41−void GSettingsControllerQml::unRegisterSettingsObject(GSettingsQml *obj) {

42− m_registeredGSettings.removeOne(obj);

43−}

44−

45−void GSettingsControllerQml::setPictureUri(const QString &str) {

46− Q_FOREACH (GSettingsQml *obj, m_registeredGSettings) {

47− obj->setPictureUri(str);

48− }

49−}

50−

51−GSettingsSchemaQml::GSettingsSchemaQml(QObject *parent): QObject(parent) {

52−}

53−

54−QByteArray GSettingsSchemaQml::id() const {

55− return m_id;

56−}

57−

58−void GSettingsSchemaQml::setId(const QByteArray &id) {

59− if (m_id.isEmpty()) {

60− qWarning("GSettings.schema.id may only be set on construction");

61− return;

62− }

63−

64− m_id = id;

65−}

66−

67−QByteArray GSettingsSchemaQml::path() const {

68− return m_path;

69−}

70−

71−void GSettingsSchemaQml::setPath(const QByteArray &path) {

72− if (m_path.isEmpty()) {

73− qWarning("GSettings.schema.path may only be set on construction");

74− return;

75− }

76−

77− m_path = path;

78−}

79−

80−GSettingsQml::GSettingsQml(QObject *parent): QObject(parent) {

81− m_schema = new GSettingsSchemaQml(this);

82− GSettingsControllerQml::instance()->registerSettingsObject(this);

83−}

84−

85−GSettingsQml::~GSettingsQml() {

86− GSettingsControllerQml::instance()->unRegisterSettingsObject(this);

87−}

88−

89−GSettingsSchemaQml * GSettingsQml::schema() const {

90− return m_schema;

91−}

92−

93−QString GSettingsQml::pictureUri() const {

94− return m_pictureUri;

95−}

96−

97−void GSettingsQml::setPictureUri(const QString &str) {

98− if (str != m_pictureUri) {

99− m_pictureUri = str;

100− Q_EMIT pictureUriChanged(m_pictureUri);

101− }

102−}

tests/mocks/GSettings/fake_gsettings.hdeleted−90

@@ -1,90 +0,0 @@

1−/*

3− *

4− * This program is free software; you can redistribute it and/or modify

5− * it under the terms of the GNU Lesser General Public License as published by

6− * the Free Software Foundation; version 3.

7− *

8− * This program is distributed in the hope that it will be useful,

9− * but WITHOUT ANY WARRANTY; without even the implied warranty of

10− * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

11− * GNU Lesser General Public License for more details.

12− *

13− * You should have received a copy of the GNU Lesser General Public License

14− * along with this program. If not, see <http://www.gnu.org/licenses/>.

15− */

16−

17−#ifndef FAKE_GSETTINGS_H

18−#define FAKE_GSETTINGS_H

19−

20−#include <QList>

21−#include <QtQml>

22−

23−class GSettingsSchemaQml: public QObject

24−{

25− Q_OBJECT

26−

27− Q_PROPERTY(QByteArray id READ id WRITE setId)

28−

29−public:

30− GSettingsSchemaQml(QObject *parent = NULL);

31−

32− QByteArray id() const;

33− void setId(const QByteArray &id);

34−

35− QByteArray path() const;

36− void setPath(const QByteArray &path);

37−

38−private:

39− QByteArray m_id;

40− QByteArray m_path;

41−};

42−

43−class GSettingsQml: public QObject

44−{

45− Q_OBJECT

46−

47− Q_PROPERTY(GSettingsSchemaQml* schema READ schema NOTIFY schemaChanged)

48− Q_PROPERTY(QString pictureUri READ pictureUri WRITE setPictureUri NOTIFY pictureUriChanged)

49−

50−public:

51− GSettingsQml(QObject *parent = NULL);

52− ~GSettingsQml();

53−

54− GSettingsSchemaQml * schema() const;

55− QString pictureUri() const;

56−

57− void setPictureUri(const QString &str);

58−

59−Q_SIGNALS:

60− void schemaChanged();

61− void pictureUriChanged(const QString&);

62−

63−private:

64− GSettingsSchemaQml* m_schema;

65−

66− QString m_pictureUri;

67−

68− friend class GSettingsSchemaQml;

69−};

70−

71−class GSettingsControllerQml: public QObject

72−{

73− Q_OBJECT

74−

75−public:

76− static GSettingsControllerQml* instance();

77− ~GSettingsControllerQml();

78−

79− void registerSettingsObject(GSettingsQml *obj);

80− void unRegisterSettingsObject(GSettingsQml *obj);

81− Q_INVOKABLE void setPictureUri(const QString &str);

82−

83−private:

84− GSettingsControllerQml();

85−

86− static GSettingsControllerQml* s_controllerInstance;

87− QList<GSettingsQml *> m_registeredGSettings;

88−};

89−

90−#endif // FAKE_GSETTINGS_H

tests/mocks/GSettings/plugin.cppdeleted−33

@@ -1,33 +0,0 @@

1−/*

3− *

4− * This program is free software; you can redistribute it and/or modify

5− * it under the terms of the GNU General Public License as published by

6− * the Free Software Foundation; version 3.

7− *

8− * This program is distributed in the hope that it will be useful,

9− * but WITHOUT ANY WARRANTY; without even the implied warranty of

10− * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

11− * GNU General Public License for more details.

12− *

13− * You should have received a copy of the GNU General Public License

14− * along with this program. If not, see <http://www.gnu.org/licenses/>.

15− */

16−

17−#include "plugin.h"

18−#include "fake_gsettings.h"

19−

20−#include <QtQml>

21−

22−static QObject* controllerProvider(QQmlEngine* /* engine */, QJSEngine* /* scriptEngine */)

23−{

24− return GSettingsControllerQml::instance();

25−}

26−

27−void FakeGSettingsQmlPlugin::registerTypes(const char *uri)

28−{

29− qmlRegisterSingletonType<GSettingsControllerQml>(uri, 1, 0, "GSettingsController", controllerProvider);

30− qmlRegisterType<GSettingsQml>(uri, 1, 0, "GSettings");

31− qmlRegisterUncreatableType<GSettingsSchemaQml>(uri, 1, 0, "GSettingsSchema",

32− "GSettingsSchema can only be used inside of a GSettings component");

33−}

tests/mocks/GSettings/plugin.hdeleted−31

@@ -1,31 +0,0 @@

1−/*

3− *

4− * This program is free software; you can redistribute it and/or modify

5− * it under the terms of the GNU General Public License as published by

6− * the Free Software Foundation; version 3.

7− *

8− * This program is distributed in the hope that it will be useful,

9− * but WITHOUT ANY WARRANTY; without even the implied warranty of

10− * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

11− * GNU General Public License for more details.

12− *

13− * You should have received a copy of the GNU General Public License

14− * along with this program. If not, see <http://www.gnu.org/licenses/>.

15− */

16−

17−#ifndef PLUGIN_H

18−#define PLUGIN_H

19−

20−#include <QtQml/QQmlExtensionPlugin>

21−

22−class FakeGSettingsQmlPlugin : public QQmlExtensionPlugin

23−{

24− Q_OBJECT

25− Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface")

26−

27−public:

28− void registerTypes(const char *uri);

29−};

30−

31−#endif // PLUGIN_H

tests/mocks/GSettings/qmldirdeleted−2

@@ -1,2 +0,0 @@

1−module GSettings

2−plugin FakeGSettingsQml

tests/plugins/ListViewWithPageHeader/listviewwithpageheadertestsection.cpp+44

@@ -1711,6 +1711,50 @@ private Q_SLOTS:

1711 QVERIFY(QQuickItemPrivate::get(lvwph->m_topSectionItem)->culled);

1712 }

1713

1714+ void testSectionItemCullOnFirstSectionItemTopEdge()

1715+ {

1716+ changeContentY(50);

1717+

1718+ verifyItem(0, 0., 190., false, "Agressive", false);

1719+ verifyItem(1, 190., 240., false, "Regular", false);

1720+ verifyItem(2, 430., 390., false, "Mild", false);

1721+ QCOMPARE(lvwph->m_minYExtent, 0.);

1722+ QCOMPARE(lvwph->m_clipItem->y(), 50.);

1723+ QCOMPARE(lvwph->m_clipItem->clip(), false);

1724+ QCOMPARE(lvwph->m_headerItem->y(), 0.);

1725+ QCOMPARE(lvwph->m_headerItem->height(), 50.);

1726+ QCOMPARE(lvwph->contentY(), 50.);

1727+ QCOMPARE(lvwph->m_headerItemShownHeight, 0.);

1728+ QVERIFY(QQuickItemPrivate::get(lvwph->m_topSectionItem)->culled);

1729+ }

1730+

1731+ void testSectionItemCullOnSecondSectionItemTopEdge()

1732+ {

1733+ QMetaObject::invokeMethod(model, "insertItem", Q_ARG(QVariant, 0), Q_ARG(QVariant, 50), Q_ARG(QVariant, "Agressive"));

1734+ QMetaObject::invokeMethod(model, "insertItem", Q_ARG(QVariant, 0), Q_ARG(QVariant, 50), Q_ARG(QVariant, "Agressive"));

1735+

1736+ changeContentY(140);

1737+

1738+ QTRY_COMPARE(lvwph->m_visibleItems.count(), 5);

1739+ QCOMPARE(lvwph->m_firstVisibleIndex, 0);

1740+ verifyItem(0, -90., 90., true, "Agressive", true);

1741+ verifyItem(1, 0., 50., false, QString(), false);

1742+ verifyItem(2, 50., 150., false, QString(), false);

1743+ verifyItem(3, 200., 240., false, "Regular", false);

1744+ verifyItem(4, 440., 390., false, "Mild", false);

1745+ QCOMPARE(lvwph->m_minYExtent, 0.);

1746+ QCOMPARE(lvwph->m_clipItem->y(), 140.);

1747+ QCOMPARE(lvwph->m_clipItem->clip(), false);

1748+ QCOMPARE(lvwph->m_headerItem->y(), 0.);

1749+ QCOMPARE(lvwph->m_headerItem->height(), 50.);

1750+ QCOMPARE(lvwph->contentY(), 140.);

1751+ QCOMPARE(lvwph->m_headerItemShownHeight, 0.);

1752+ QVERIFY(!QQuickItemPrivate::get(lvwph->m_topSectionItem)->culled);

1753+ QCOMPARE(section(lvwph->m_topSectionItem), QString("Agressive"));

1754+ QCOMPARE(sectionDelegateIndex(lvwph->m_topSectionItem), 0);

1755+ QCOMPARE(lvwph->m_topSectionItem->y(), 0.);

1756+ }

1757+

1714 void testMaximizeVisibleArea()

1758 void testMaximizeVisibleArea()

1715 {

1759 {

1716 bool res = lvwph->maximizeVisibleArea(2);

1760 bool res = lvwph->maximizeVisibleArea(2);

tests/qmltests/CMakeLists.txt+1−1

@@ -26,7 +26,7 @@ set(qmltest_DEFAULT_TARGETS qmluitests)

26set(qmltest_DEFAULT_NO_ADD_TEST TRUE)

27set(qmltest_DEFAULT_PROPERTIES "")

28

29−add_qml_test(. Shell IMPORT_PATHS ${CMAKE_BINARY_DIR}/plugins ${qmltest_DEFAULT_IMPORT_PATHS} ${CMAKE_BINARY_DIR}/tests/mocks

29+add_qml_test(. Shell IMPORT_PATHS ${CMAKE_BINARY_DIR}/plugins ${qmltest_DEFAULT_IMPORT_PATHS}

30 ENVIRONMENT "LD_LIBRARY_PATH=${CMAKE_BINARY_DIR}/tests/mocks/LightDM/single")

31add_manual_qml_test(Components DragHandle IMPORT_PATHS ${CMAKE_BINARY_DIR}/plugins)

32add_qml_test(Components DraggingArea)

tests/qmltests/tst_Shell.qml−14

@@ -19,7 +19,6 @@

19

20import QtQuick 2.0

21import QtTest 1.0

22−import GSettings 1.0

23import Ubuntu.Application 0.1

22import Ubuntu.Application 0.1

24import Unity.Test 0.1 as UT

23import Unity.Test 0.1 as UT

25

24

@@ -278,18 +277,5 @@ Item {

278 }

277 }

279 } while (!isStill);

278 } while (!isStill);

280 }

279 }

281−

282− function test_wallpaper_data() {

283− return [

284− {tag: "red", url: "tests/data/unity/backgrounds/red.png"},

285− {tag: "blue", url: "tests/data/unity/backgrounds/blue.png"}

286− ]

287− }

288−

289− function test_wallpaper(data) {

290− var backgroundImage = findChild(shell, "backgroundImage")

291− GSettingsController.setPictureUri(data.url)

292− tryCompareFunction(function() { return backgroundImage.source.toString().indexOf(data.url) !== -1; }, true)

293− }

294 }

280 }

295}

281}