git.iko.soy/unity8
on xenial help sign in
Use art height as implicitHeight when the header is overlayed
1a48b18Albert Astals Cid
plugins/Dash/CardCreator.js+2
compare with xenial
unifiedsplit
@@ -631,6 +631,8 @@ function cardString(template, components) {
631 var implicitHeight = 'implicitHeight: ';
631 var implicitHeight = 'implicitHeight: ';
632 if (hasSummary) {
632 if (hasSummary) {
633 implicitHeight += 'summary.y + summary.height + units.gu(1);\n';
633 implicitHeight += 'summary.y + summary.height + units.gu(1);\n';
634+ } else if (headerAsOverlay) {
635+ implicitHeight += 'artShapeHolder.height;\n';
634 } else if (hasHeaderRow) {
636 } else if (hasHeaderRow) {
635 implicitHeight += 'row.y + row.height + units.gu(1);\n';
637 implicitHeight += 'row.y + row.height + units.gu(1);\n';
636 } else if (hasMascot) {
638 } else if (hasMascot) {
tests/plugins/Dash/cardcreator/5.res+1−1
@@ -150,5 +150,5 @@ UbuntuShape {
150 radius: "medium";
150 radius: "medium";
151 borderSource: "radius_pressed.sci"
151 borderSource: "radius_pressed.sci"
152}
152}
153−implicitHeight: subtitleLabel.y + subtitleLabel.height + units.gu(1);
153+implicitHeight: artShapeHolder.height;
154}
154}