on xenial help sign in
more cleanup
commit1bcaf728872fcf3ca8ceca409421b893911e2ea3 authorMichael Terry <michael.terry@canonical.com> dateThu 11 Dec 2014, 12:32 (12 years ago) parent550a77a
3 files changed+11−11
qml/Greeter/Greeter.qml+2−1 qml/Greeter/GreeterContent.qml+1−1 qml/Shell.qml+8−9
qml/Greeter/Greeter.qml+2−1
@@ -141,12 +141,13 @@ Showable {
141141 anchors.fill: parent
142142 property var model: LightDM.Users
143143 property int currentIndex: 0
144+ property var infographicModel: LightDM.Infographic
144145 readonly property int backgroundTopMargin: -greeter.y
145146
146147 source: loadContent ? "GreeterContent.qml" : ""
147148
148149 onLoaded: {
149− greeterContentLoader.item.selected(currentIndex);
150+ selected(currentIndex);
150151 }
151152
152153 Connections {
qml/Greeter/GreeterContent.qml+1−1
@@ -122,7 +122,7 @@ Item {
122122 property string infographicUser: AccountsService.statsWelcomeScreen ? selectedUser : ""
123123 onInfographicUserChanged: greeterContentLoader.infographicModel.username = infographicUser
124124
125− Component.onCompleted {
125+ Component.onCompleted: {
126126 selectedUser = greeterContentLoader.model.data(greeterContentLoader.currentIndex, LightDM.UserRoles.NameRole)
127127 greeterContentLoader.infographicModel.username = infographicUser
128128 greeterContentLoader.infographicModel.readyForDataChange()
qml/Shell.qml+8−9
@@ -655,15 +655,14 @@ Item {
655655 if (Powerd.status === Powerd.Off && reason !== Powerd.Proximity &&
656656 !callManager.hasCalls && !edgeDemo.running) {
657657 // We don't want to simply call greeter.showNow() here, because
658− // that will take too long (especially if the wallpaper image
659− // is large). Qt will delay button event handling until the
660− // greeter is done loading and may think the user held down the
661− // power button the whole time, leading to a power dialog being
662− // shown. Instead, delay showing the greeter until we've
663− // finished handling the event. We could make the greeter load
664− // asynchronously instead, but that introduces a whole host of
665− // timing issues, especially with its animations. So this is
666− // simpler.
658+ // that will take too long. Qt will delay button event
659+ // handling until the greeter is done loading and may think the
660+ // user held down the power button the whole time, leading to a
661+ // power dialog being shown. Instead, delay showing the
662+ // greeter until we've finished handling the event. We could
663+ // make the greeter load asynchronously instead, but that
664+ // introduces a whole host of timing issues, especially with
665+ // its animations. So this is simpler.
667666 showGreeterDelayed.start();
668667 }
669668 }