git.iko.soy/unity8
on xenial help sign in
Make rating stars in PreviewReviewDisplay.qml non-interactive. Fixes: 1337508
20f4848Michał Sawicz
qml/Dash/Previews/PreviewRatingDisplay.qml+1
compare with xenial
unifiedsplit
@@ -61,6 +61,7 @@ PreviewWidget {
61 size: 5
61 size: 5
62 value: modelData["rating"] || -1
62 value: modelData["rating"] || -1
63 visible: value >= 0
63 visible: value >= 0
64+ interactive: false
64
65
65 property var urlIconEmpty: widgetData["rating-icon-empty"]
66 property var urlIconEmpty: widgetData["rating-icon-empty"]
66 property var urlIconFull: widgetData["rating-icon-full"]
67 property var urlIconFull: widgetData["rating-icon-full"]
tests/qmltests/Dash/Previews/tst_PreviewRatingDisplay.qml+13
@@ -108,5 +108,18 @@ Rectangle {
108 }
108 }
109 }
109 }
110 }
110 }
111+
112+ function test_non_interactive() {
113+ previewRatingDisplay.widgetData = reviewsModel1;
114+
115+ var reviewItem = findChild(previewRatingDisplay, "reviewItem1");
116+ var rating = findChild(reviewItem, "rating");
117+
118+ compare(rating.value, reviewsModel1["reviews"][1]["rating"]);
119+
120+ // Tap on first star
121+ mouseClick(rating, 0, 0);
122+ compare(rating.value, reviewsModel1["reviews"][1]["rating"]);
123+ }
111 }
124 }
112}
125}