on xenial help sign in
Slightly better comment
2ea8705Gerry Boland
Components/ApplicationManagerWrapper.qml+6−3
@@ -67,7 +67,8 @@ Item {
67 function activateApplication(desktopFile, argument) {
67 function activateApplication(desktopFile, argument) {
68 var appId;
68 var appId;
69
69
70− // HACK: might be called with appId, but mostly with desktopFile
70+ // HACK: Applications identified sometimes with with appId, but mostly with desktopFile.
71+ // TODO: convert entire shell to use appId only.
71 if (desktopFile.indexOf(".desktop") >= 0) {
72 if (desktopFile.indexOf(".desktop") >= 0) {
72 appId = desktopFileToAppId(desktopFile);
73 appId = desktopFileToAppId(desktopFile);
73 } else {
74 } else {
@@ -91,7 +92,8 @@ Item {
91 function stopApplication(application) {
92 function stopApplication(application) {
92 var appId;
93 var appId;
93
94
94− // HACK: might be called with appId, or else with Application object
95+ // HACK: Applications identified sometimes with with appId, but mostly with desktopFile.
96+ // TODO: convert entire shell to use appId only.
95 if (typeof application == "string") {
97 if (typeof application == "string") {
96 appId = application;
98 appId = application;
97 } else {
99 } else {
@@ -126,7 +128,8 @@ Item {
126 function getApplicationFromDesktopFile(desktopFile, stage) {
128 function getApplicationFromDesktopFile(desktopFile, stage) {
127 var appId;
129 var appId;
128
130
129− // HACK: might be called with appId, but mostly with desktopFile
131+ // HACK: Applications identified sometimes with with appId, but mostly with desktopFile.
132+ // TODO: convert entire shell to use appId only.
130 if (desktopFile.indexOf(".desktop") >= 0) {
133 if (desktopFile.indexOf(".desktop") >= 0) {
131 appId = desktopFileToAppId(desktopFile);
134 appId = desktopFileToAppId(desktopFile);
132 } else {
135 } else {