git.iko.soy/unity8
on xenial help sign in
Add a test to ensure getItem returns null on being unable to find the desktop file
commit345f2387cb032d212e35e4ec2545e20171fc240a authorTed Gould <ted@gould.cx> dateTue 29 Apr 2014, 09:19 (12 years ago) parent030b5bd
2 files changed+24−1
compare with xenial
unifiedsplit
plugins/Unity/Launcher/backend/launcherbackend.h+2−1 tests/plugins/Unity/Launcher/launcherbackendtest.cpp+22
plugins/Unity/Launcher/backend/launcherbackend.h+2−1
@@ -168,7 +168,6 @@ Q_SIGNALS:
168168private:
169169 QString findDesktopFile(const QString &appId) const;
170170 LauncherBackendItem* parseDesktopFile(const QString &desktopFile) const;
171− LauncherBackendItem* getItem (const QString& appId) const;
172171
173172 QVariantMap itemToVariant(const QString &appId) const;
174173 void loadFromVariant(const QVariantMap &details);
@@ -186,6 +185,8 @@ private:
186185 void emitPropChangedDbus (const QString& appId, const QString& property, QVariant &value) const;
187186
188187public: /* Only public to make them easier to test independently */
188+ LauncherBackendItem* getItem (const QString& appId) const;
189+
189190 static QString decodeAppId (const QString& path);
190191 static QString encodeAppId (const QString& appId);
191192};
tests/plugins/Unity/Launcher/launcherbackendtest.cpp+22
@@ -71,6 +71,28 @@ private Q_SLOTS:
7171 QCOMPARE(backend.icon(appId), expectedIcon);
7272 }
7373
74+ void testGetItem_data() {
75+ QTest::addColumn<QString>("appId");
76+ QTest::addColumn<bool>("exists");
77+
78+ QTest::newRow("Exists") << "rel-icon" << true;
79+ QTest::newRow("Doesn't Exist") << "does-not-exist" << false;
80+ }
81+
82+ void testGetItem() {
83+ QFETCH(QString, appId);
84+ QFETCH(bool, exists);
85+
86+ LauncherBackend backend;
87+ auto item = backend.getItem(appId);
88+
89+ if (exists) {
90+ QVERIFY(item != nullptr);
91+ } else {
92+ QVERIFY(item == nullptr);
93+ }
94+ }
95+
7496 void testCount_data() {
7597 QTest::addColumn<QString>("appId");
7698 QTest::addColumn<bool>("setCount");