git.iko.soy/unity8
on xenial help sign in
Remove Shell's underlay background image as it cannot be seen anymore

Now that the Dash has its own, opaque, background, the underlay's background image can no longer be seen. So it's just a waste of resources to have it.

commit3bf825f23caff29b35b84e0a068dd68081b26f45 authorDaniel d'Andrada <daniel.dandrada@canonical.com> dateTue 27 May 2014, 07:46 (12 years ago) parente7bd92d8aca6a0
3 files changed−22
compare with xenial
unifiedsplit
qml/Shell.qml−9 tests/autopilot/unity8/shell/emulators/main_window.py−4 tests/qmltests/tst_Shell.qml−9
qml/Shell.qml−9
@@ -117,15 +117,6 @@ FocusScope {
117117 // through the translucent parts of the shell surface.
118118 visible: !fullyCovered && !applicationSurfaceShouldBeSeen
119119
120− CrossFadeImage {
121− id: backgroundImage
122− objectName: "backgroundImage"
123−
124− anchors.fill: parent
125− source: shell.background
126− fillMode: Image.PreserveAspectCrop
127− }
128−
129120 Rectangle {
130121 anchors.fill: parent
131122 color: "black"
tests/autopilot/unity8/shell/emulators/main_window.py−4
@@ -114,10 +114,6 @@ class QQuickView(emulators.UnityEmulatorBase):
114114 self.wait_select_single('Indicators', fullyOpened=True)
115115 return self._get_indicator_page(indicator_name)
116116
117− def get_shell_background(self):
118− return self.select_single(
119− "CrossFadeImage", objectName="backgroundImage")
120−
121117 @autopilot_logging.log_action(logger.info)
122118 def show_dash_swiping(self):
123119 """Show the dash swiping from the left."""
tests/qmltests/tst_Shell.qml−9
@@ -475,15 +475,6 @@ Item {
475475 } while (!isStill);
476476 }
477477
478− function test_background_data() {
479− return [
480− {tag: "red", url: Qt.resolvedUrl("../data/unity/backgrounds/red.png"), expectedUrl: "tests/data/unity/backgrounds/red.png"},
481− {tag: "blue", url: Qt.resolvedUrl("../data/unity/backgrounds/blue.png"), expectedUrl: "tests/data/unity/backgrounds/blue.png"},
482− {tag: "invalid", url: "invalid", expectedUrl: shell.defaultBackground},
483− {tag: "empty", url: "", expectedUrl: shell.defaultBackground}
484− ]
485− }
486−
487478 function test_DashShown_data() {
488479 return [
489480 {tag: "in focus", greeter: false, app: false, launcher: false, indicators: false, expectedShown: true},