git.iko.soy/unity8
on xenial help sign in
Use art height as implicitHeight when the header is overlayed and there's no summary
3e0c31fAlbert Astals Cid
plugins/Dash/CardCreator.js+2
compare with xenial
unifiedsplit
@@ -644,6 +644,8 @@ function cardString(template, components) {
644 var implicitHeight = 'implicitHeight: ';
644 var implicitHeight = 'implicitHeight: ';
645 if (hasSummary) {
645 if (hasSummary) {
646 implicitHeight += 'summary.y + summary.height + units.gu(1);\n';
646 implicitHeight += 'summary.y + summary.height + units.gu(1);\n';
647+ } else if (headerAsOverlay) {
648+ implicitHeight += 'artShapeHolder.height;\n';
647 } else if (hasHeaderRow) {
649 } else if (hasHeaderRow) {
648 implicitHeight += 'row.y + row.height + units.gu(1);\n';
650 implicitHeight += 'row.y + row.height + units.gu(1);\n';
649 } else if (hasMascot) {
651 } else if (hasMascot) {
tests/plugins/Dash/cardcreator/5.res+1−1
@@ -163,5 +163,5 @@ UbuntuShape {
163 radius: "medium";
163 radius: "medium";
164 borderSource: "radius_pressed.sci"
164 borderSource: "radius_pressed.sci"
165}
165}
166−implicitHeight: subtitleLabel.y + subtitleLabel.height + units.gu(1);
166+implicitHeight: artShapeHolder.height;
167}
167}