on xenial help sign in
Comment on why the hardcoded size and its sillyness
4201b33Albert Astals
plugins/Dash/CardCreator.js+2
@@ -87,6 +87,8 @@ function cardString(template, components) {
87 imageWidthHeight = 'width: height * artShape.aspect; \
87 imageWidthHeight = 'width: height * artShape.aspect; \
88 height: headerHeight;'
88 height: headerHeight;'
89 } else {
89 } else {
90+ // This side of the else is a bit silly, who wants an horizontal layout without mascot and title?
91+ // So we define a "random" height of the image height + 2 gu for the margins
90 imageWidthHeight = 'width: height * artShape.aspect; \
92 imageWidthHeight = 'width: height * artShape.aspect; \
91 height: units.gu(7.625)';
93 height: units.gu(7.625)';
92 }
94 }