on xenial help sign in
Don't crash if we only ever set an empty username in our mock libusermetrics
commit44a26d2148999d89686ea59f18ca60c9e0b36a82 authorMichael Terry <michael.terry@canonical.com> dateThu 3 Oct 2013, 00:28 (13 years ago) parent72994a1
2 files changed+2−2
Greeter/GreeterContent.qml+1−1 tests/mocks/libusermetrics/UserMetrics.cpp+1−1
Greeter/GreeterContent.qml+1−1
@@ -146,7 +146,7 @@ MouseArea {
146146 Component.onCompleted: {
147147 selectedUser = greeterContentLoader.model.data(greeterContentLoader.currentIndex, LightDM.UserRoles.NameRole)
148148 greeterContentLoader.infographicModel.username = infographicUser
149− greeterContentLoader.infographicModel.readyForDataChangeSlot()
149+ greeterContentLoader.infographicModel.readyForDataChange()
150150 }
151151
152152 Connections {
tests/mocks/libusermetrics/UserMetrics.cpp+1−1
@@ -228,7 +228,7 @@ UserMetricsPrivate::~UserMetricsPrivate()
228228
229229void UserMetricsPrivate::setUsername(const QString &username)
230230{
231− if (m_username == username) {
231+ if (m_username == username && m_newData) {
232232 return;
233233 }
234234