Minor coverity fixes
Remove unused member variables
Initialize to 0/nullptr some member variables
commit47fa129d48715a072481a338868d53c4e9b41504
authorAlbert Astals Cid <albert.astals@canonical.com>
dateThu 26 May 2016, 15:15 (10 years ago)
parent64d3f31
tests/mocks/GSettings.1.0/fake_gsettings.cpp+1
@@ -22,6 +22,7 @@ GSettingsControllerQml* GSettingsControllerQml::s_controllerInstance = 0;
2222
2323GSettingsControllerQml::GSettingsControllerQml()
2424 : m_disableHeight(false)
25+ , m_lockedOutTime(0)
2526 , m_usageMode("Staged")
2627 , m_autohideLauncher(false)
2728 , m_launcherWidth(8)
tests/mocks/IntegratedLightDM/liblightdm/GreeterPrivate.h−1
@@ -41,7 +41,6 @@ public:
4141 void handleRespond(const QString &response);
4242
4343protected:
44− GreeterImpl *m_impl; // if the backend needs more private data
4544 Greeter * const q_ptr;
4645
4746private:
tests/mocks/Ubuntu/Payments/MockPayments.cpp+1
@@ -21,6 +21,7 @@
2121
2222MockPayments::MockPayments(QObject *parent)
2323 : QObject(parent)
24+ , m_price(0)
2425{
2526}
2627
tests/mocks/Unity/Application/MirSurfaceItem.cpp+1
@@ -40,6 +40,7 @@ using namespace unity::shell::application;
4040MirSurfaceItem::MirSurfaceItem(QQuickItem *parent)
4141 : MirSurfaceItemInterface(parent)
4242 , m_qmlSurface(nullptr)
43+ , m_qmlContentComponent(nullptr)
4344 , m_qmlItem(nullptr)
4445 , m_consumesInput(false)
4546 , m_surfaceWidth(0)
tests/mocks/libusermetrics/UserMetrics.cpp+1−1
@@ -220,7 +220,7 @@ int UserMetricsData::length() const
220220}
221221
222222UserMetricsPrivate::UserMetricsPrivate(UserMetrics *parent) :
223− q_ptr(parent), m_firstColor(this), m_secondColor(this)
223+ q_ptr(parent), m_firstColor(this), m_secondColor(this), m_currentDay(0)
224224{
225225 m_fakeData.insert("", UserMetricsDataPtr(new UserMetricsData(this)));
226226}
tests/plugins/Unity/Indicators/MenuContentActivatorTest.cpp+1
@@ -28,6 +28,7 @@ class FakeTimer : public UnityIndicators::AbstractTimer
2828public:
2929 FakeTimer(QObject *parent = 0)
3030 : UnityIndicators::AbstractTimer(parent)
31+ , m_duration(0)
3132 {}
3233
3334 int interval() const override { return m_duration; }
tests/uqmlscene/main.cpp−1
@@ -159,7 +159,6 @@ struct Options
159159 bool maximized;
160160 bool fullscreen;
161161 bool transparent;
162− bool scenegraphOnGraphicsview;
163162 bool clip;
164163 bool versionDetection;
165164 bool quitImmediately;