on xenial help sign in
review nits
commit4a20ff2ef4a5a64ab62594eaf9bcabaede1a4c84 authorMichael Terry <michael.terry@canonical.com> dateTue 2 Dec 2014, 12:43 (12 years ago) parent055a349
2 files changed+11−3
tests/mocks/MeeGo/QOfono/MockOfonoSimManager.qml−2 tests/qmltests/Wizard/tst_Wizard.qml+11−1
tests/mocks/MeeGo/QOfono/MockOfonoSimManager.qml−2
@@ -23,8 +23,6 @@ Item {
2323 property string modemPath
2424 readonly property alias present: d.present
2525
26− ////
27−
2826 QtObject {
2927 id: d
3028
tests/qmltests/Wizard/tst_Wizard.qml+11−1
@@ -170,8 +170,18 @@ Item {
170170 var page = goToPage("languagePage");
171171 tap(findChild(page, "languageCombo"));
172172 waitForRendering(findChild(page, "languageDelegate1"));
173− wait(100); // still needs more time to finish drawing(?) or else we sometimes fail
173+
174+ // For some reason, the delegate *sometimes* (like 1 in 10 maybe)
175+ // needs more time before it can process a tap() call. I can't
176+ // find a rhyme or reason, its properties all seem the same in
177+ // cases where it works and does not. This failure to receive a
178+ // tap() call below does *not* happen when running in xvfb, so
179+ // jenkins is unaffected (and we don't have to worry about 100 not
180+ // being enough time in its slow environment). This wait() call is
181+ // just to help local runs not trip up.
182+ wait(100);
174183 tap(findChild(page, "languageDelegate1"));
184+
175185 tryCompare(i18n, "language", "fr");
176186 tap(findChild(page, "forwardButton"));
177187 tryCompare(updateSessionLanguageSpy, "count", 1);