on xenial help sign in
Make some paramaters constant
4b79442Josh Arenson
plugins/LightDM/SessionsModel.cpp+2−2
@@ -34,7 +34,7 @@ QList<QUrl> SessionsModel::iconSearchDirectories() const
34 return m_iconSearchDirectories;
34 return m_iconSearchDirectories;
35}
35}
36
36
37−void SessionsModel::setIconSearchDirectories(QList<QUrl> searchDirectories)
37+void SessionsModel::setIconSearchDirectories(const QList<QUrl> searchDirectories)
38{
38{
39 // QML gives us a url with file:// prepended which breaks QFile::exists()
39 // QML gives us a url with file:// prepended which breaks QFile::exists()
40 // so convert the url to a local file
40 // so convert the url to a local file
@@ -47,7 +47,7 @@ void SessionsModel::setIconSearchDirectories(QList<QUrl> searchDirectories)
47 Q_EMIT iconSearchDirectoriesChanged();
47 Q_EMIT iconSearchDirectoriesChanged();
48}
48}
49
49
50−QUrl SessionsModel::iconUrl(QString sessionName) const
50+QUrl SessionsModel::iconUrl(const QString sessionName) const
51{
51{
52 Q_FOREACH(const QUrl& searchDirectory, m_iconSearchDirectories)
52 Q_FOREACH(const QUrl& searchDirectory, m_iconSearchDirectories)
53 {
53 {
plugins/LightDM/SessionsModel.h+2−2
@@ -52,9 +52,9 @@ public:
52 int rowCount(const QModelIndex& parent) const override;
52 int rowCount(const QModelIndex& parent) const override;
53 QVariant data(const QModelIndex& index, int role) const override;
53 QVariant data(const QModelIndex& index, int role) const override;
54 QList<QUrl> iconSearchDirectories() const;
54 QList<QUrl> iconSearchDirectories() const;
55− Q_INVOKABLE QUrl iconUrl(QString sessionName) const;
55+ Q_INVOKABLE QUrl iconUrl(const QString sessionName) const;
56
56
57− void setIconSearchDirectories(QList<QUrl> searchDirectories);
57+ void setIconSearchDirectories(const QList<QUrl> searchDirectories);
58private:
58private:
59 QLightDM::SessionsModel* m_model;
59 QLightDM::SessionsModel* m_model;
60 QHash<int, QByteArray> m_roleNames;
60 QHash<int, QByteArray> m_roleNames;