git.iko.soy/unity8
on xenial help sign in
Dash manage hint should not be visible in previews+test
6bd9cffAlbert Astals Cid
qml/Dash/Dash.qml+2−1
compare with xenial
unifiedsplit
@@ -302,10 +302,11 @@ Showable {
302 }
302 }
303
303
304 Image {
304 Image {
305+ objectName: "overviewHint"
305 source: "graphics/overview_hint.png"
306 source: "graphics/overview_hint.png"
306 anchors.horizontalCenter: parent.horizontalCenter
307 anchors.horizontalCenter: parent.horizontalCenter
307 opacity: !scopeItem.scope && (scopes.count == 0 || dashContent.pageHeaderTotallyVisible) &&
308 opacity: !scopeItem.scope && (scopes.count == 0 || dashContent.pageHeaderTotallyVisible) &&
308− (overviewDragHandle.enabled || overviewDragHandle.status.progress != 0) ? 1 : 0
309+ (overviewDragHandle.enabled || bottomEdgeController.progress != 0) ? 1 : 0
309 Behavior on opacity {
310 Behavior on opacity {
310 enabled: bottomEdgeController.progress == 0
311 enabled: bottomEdgeController.progress == 0
311 UbuntuNumberAnimation {}
312 UbuntuNumberAnimation {}
tests/qmltests/Dash/tst_Dash.qml+23
@@ -428,5 +428,28 @@ Item {
428 tryCompare(bottomEdgeController, "progress", 0);
428 tryCompare(bottomEdgeController, "progress", 0);
429 tryCompare(dashContentList, "currentIndex", 1)
429 tryCompare(dashContentList, "currentIndex", 1)
430 }
430 }
431+
432+ function test_preview_no_show_manage_dash_hint() {
433+ var dashContentList = findChild(dash, "dashContentList");
434+ compare(dashContentList.currentIndex, 0);
435+ compare(dashContentList.currentItem.scopeId, "MockScope1");
436+
437+ tryCompareFunction(function() {
438+ var cardGrid = findChild(dashContentList, "dashCategory0");
439+ if (cardGrid != null) {
440+ var tile = findChild(cardGrid, "delegate0");
441+ return tile != null;
442+ }
443+ return false;
444+ },
445+ true);
446+ var tile = findChild(findChild(dashContentList, "dashCategory0"), "delegate0");
447+ waitForRendering(tile);
448+ mouseClick(tile);
449+
450+ var overviewHint = findChild(dash, "overviewHint");
451+ tryCompare(overviewHint, "opacity", 0);
452+ }
431 }
453 }
454+
432}
455}