on xenial help sign in
Wrap the Q_PROPERTIES

My screen fits 58 lines and 200 columns, yet the reviewer thinks it is better to waste the few vertical space avaiable so that we can all enjoy lots of empty space on the right of the screen

commit74a9cefcf2f739f4f8ba26c8a045e37088d98840 authorAlbert Astals <albert.astals@canonical.com> dateMon 16 Dec 2013, 16:53 (13 years ago) parent7271d00
1 file changed+14−4
plugins/DashViews/verticaljournal.h+14−4
plugins/DashViews/verticaljournal.h+14−4
@@ -50,10 +50,20 @@ class QQmlDelegateModel;
5050 Q_PROPERTY(QAbstractItemModel *model READ model WRITE setModel NOTIFY modelChanged)
5151 Q_PROPERTY(QQmlComponent *delegate READ delegate WRITE setDelegate NOTIFY delegateChanged)
5252 Q_PROPERTY(qreal columnWidth READ columnWidth WRITE setColumnWidth NOTIFY columnWidthChanged)
53− Q_PROPERTY(qreal horizontalSpacing READ horizontalSpacing WRITE setHorizontalSpacing NOTIFY horizontalSpacingChanged)
54− Q_PROPERTY(qreal verticalSpacing READ verticalSpacing WRITE setVerticalSpacing NOTIFY verticalSpacingChanged)
55− Q_PROPERTY(qreal delegateCreationBegin READ delegateCreationBegin WRITE setDelegateCreationBegin NOTIFY delegateCreationBeginChanged RESET resetDelegateCreationBegin)
56− Q_PROPERTY(qreal delegateCreationEnd READ delegateCreationEnd WRITE setDelegateCreationEnd NOTIFY delegateCreationEndChanged RESET resetDelegateCreationEnd)
53+ Q_PROPERTY(qreal horizontalSpacing READ horizontalSpacing
54+ WRITE setHorizontalSpacing
55+ NOTIFY horizontalSpacingChanged)
56+ Q_PROPERTY(qreal verticalSpacing READ verticalSpacing
57+ WRITE setVerticalSpacing
58+ NOTIFY verticalSpacingChanged)
59+ Q_PROPERTY(qreal delegateCreationBegin READ delegateCreationBegin
60+ WRITE setDelegateCreationBegin
61+ NOTIFY delegateCreationBeginChanged
62+ RESET resetDelegateCreationBegin)
63+ Q_PROPERTY(qreal delegateCreationEnd READ delegateCreationEnd
64+ WRITE setDelegateCreationEnd
65+ NOTIFY delegateCreationEndChanged
66+ RESET resetDelegateCreationEnd)
5767
5868friend class VerticalJournalTest;
5969