Stop watching the old header item height once it's not our header anymore
It doesn't really matter since in ListViewWithPageHeader::itemImplicitHeightChanged
we compare with m_headerItem again so it won't break anything but better be watching
only the things we really care about
commit82069b60f98d4499af41117dca9408cc4f99337a
authorAlbert Astals Cid <albert.astals@canonical.com>
dateThu 26 May 2016, 12:32 (10 years ago)
parent64d3f31
plugins/Dash/listviewwithpageheader.cpp+1
@@ -255,6 +255,7 @@ void ListViewWithPageHeader::setHeader(QQuickItem *headerItem)
255255 oldHeaderHeight = m_headerItem->height();
256256 oldHeaderY = m_headerItem->y();
257257 m_headerItem->setParentItem(nullptr);
258+ QQuickItemPrivate::get(m_headerItem)->removeItemChangeListener(this, QQuickItemPrivate::ImplicitHeight);
258259 }
259260 m_headerItem = headerItem;
260261 if (m_headerItem) {