git.iko.soy/unity8
on xenial help sign in
should fix tests
commit96e91a669248421fa27a069d04b9b373c46eba0c authorAndrea Cimitan <andrea.cimitan@gmail.com> dateThu 7 Jul 2016, 16:10 (10 years ago) parent5600c95
3 files changed+39−34
compare with xenial
unifiedsplit
qml/Dash/DashPageHeader.qml+29−29 tests/qmltests/Dash/tst_DashContent.qml+6−3 tests/qmltests/Dash/tst_DashPageHeader.qml+4−2
qml/Dash/DashPageHeader.qml+29−29
@@ -145,6 +145,35 @@ Item {
145145
146146 property bool showSearch: false
147147
148+ state: headerContainer.showSearch ? "search" : ""
149+
150+ states: State {
151+ name: "search"
152+
153+ AnchorChanges {
154+ target: headersColumn
155+ anchors.top: parent.top
156+ anchors.bottom: undefined
157+ }
158+ }
159+
160+ transitions: Transition {
161+ id: openSearchAnimation
162+ AnchorAnimation {
163+ duration: UbuntuAnimation.FastDuration
164+ }
165+
166+ property bool openPopup: false
167+
168+ onRunningChanged: {
169+ headerContainer.clip = running;
170+ if (!running && openSearchAnimation.openPopup) {
171+ openSearchAnimation.openPopup = false;
172+ root.openPopup();
173+ }
174+ }
175+ }
176+
148177 Background {
149178 id: background
150179 objectName: "headerBackground"
@@ -159,35 +188,6 @@ Item {
159188 bottom: parent.bottom
160189 }
161190
162− state: headerContainer.showSearch ? "search" : ""
163−
164− states: State {
165− name: "search"
166−
167− AnchorChanges {
168− target: headersColumn
169− anchors.top: parent.top
170− anchors.bottom: undefined
171− }
172− }
173−
174− transitions: Transition {
175− id: openSearchAnimation
176− AnchorAnimation {
177− duration: UbuntuAnimation.FastDuration
178− }
179−
180− property bool openPopup: false
181−
182− onRunningChanged: {
183− headerContainer.clip = running;
184− if (!running && openSearchAnimation.openPopup) {
185− openSearchAnimation.openPopup = false;
186− root.openPopup();
187− }
188− }
189− }
190−
191191 PageHeader {
192192 id: searchHeader
193193 anchors { left: parent.left; right: parent.right }
tests/qmltests/Dash/tst_DashContent.qml+6−3
@@ -320,7 +320,8 @@ Item {
320320 tryCompare(navigationListView.currentItem.navigation, "navigationId", "root");
321321
322322 var headerContainer = findChild(dashContentList.currentItem, "headerContainer");
323− tryCompare(headerContainer, "contentY", headerContainer.height);
323+ tryCompare(headerContainer, "clip", false);
324+ verify(headerContainer.state != "search");
324325 mouseClick(searchButton);
325326 tryCompare(peExtraPanel, "visible", true);
326327 waitForRendering(navigationListView);
@@ -384,7 +385,8 @@ Item {
384385 mouseClick(header0);
385386 compare(peExtraPanel.visible, false);
386387
387− tryCompare(headerContainer, "contentY", headerContainer.height);
388+ tryCompare(headerContainer, "clip", false);
389+ verify(headerContainer.state != "search");
388390 mouseClick(searchButton);
389391 tryCompare(peExtraPanel, "visible", true);
390392 tryCompare(navigationListView.currentItem.navigation, "loaded", true);
@@ -544,7 +546,8 @@ Item {
544546
545547 mouseClick(cancelButton);
546548 tryCompare(headerContainer, "showSearch", false);
547− tryCompare(headerContainer, "contentY", headerContainer.height);
549+ tryCompare(headerContainer, "clip", false);
550+ verify(headerContainer.state != "search");
548551
549552 // test within a navigation
550553 goToSecondLevel();
tests/qmltests/Dash/tst_DashPageHeader.qml+4−2
@@ -37,13 +37,15 @@ Item {
3737 property var headerContainer: findChild(pageHeader, "headerContainer")
3838
3939 function doTypeString(text) {
40− tryCompare(headerContainer, "contentY", 0);
40+ tryCompare(headerContainer, "clip", false);
41+ compare(headerContainer.state, "search");
4142 typeString(text);
4243 }
4344
4445 function doResetSearch() {
4546 pageHeader.resetSearch();
46− tryCompare(headerContainer, "contentY", headerContainer.height);
47+ tryCompare(headerContainer, "clip", false);
48+ verify(headerContainer.state != "search");
4749 }
4850
4951 function init() {