993d3ba · unity8 · git.iko.soy

git.iko.soy/unity8

Rename v/hSpacing to row/colSpacing

And make it not apply at the beginning/end

commit993d3baa04112b6410acd4ad292f2198693c5b03 authorAlbert Astals <albert.astals@canonical.com> dateTue 17 Dec 2013, 12:09 (13 years ago) parent1825c13

4 files changed+161−162

compare with xenial

unifiedsplit

plugins/DashViews/verticaljournal.cpp+24−24 plugins/DashViews/verticaljournal.h+11−15 tests/plugins/DashViews/verticaljournaltest.cpp+124−121 tests/plugins/DashViews/verticaljournaltest.qml+2−2

plugins/DashViews/verticaljournal.cpp+24−24

@@ -45,8 +45,8 @@ VerticalJournal::VerticalJournal()

4545 : m_delegateModel(nullptr)

4646 , m_asyncRequestedIndex(-1)

4747 , m_columnWidth(0)

48− , m_horizontalSpacing(0)

49− , m_verticalSpacing(0)

48+ , m_columnSpacing(0)

49+ , m_rowSpacing(0)

5050 , m_delegateCreationBegin(0)

5151 , m_delegateCreationEnd(0)

5252 , m_delegateCreationBeginValid(false)

@@ -123,16 +123,16 @@ void VerticalJournal::setColumnWidth(qreal columnWidth)

123123 }

124124}

125125

126−qreal VerticalJournal::horizontalSpacing() const

126+qreal VerticalJournal::columnSpacing() const

127127{

128− return m_horizontalSpacing;

128+ return m_columnSpacing;

129129}

130130

131−void VerticalJournal::setHorizontalSpacing(qreal horizontalSpacing)

131+void VerticalJournal::setColumnSpacing(qreal columnSpacing)

132132{

133− if (horizontalSpacing != m_horizontalSpacing) {

134− m_horizontalSpacing = horizontalSpacing;

135− Q_EMIT horizontalSpacingChanged();

133+ if (columnSpacing != m_columnSpacing) {

134+ m_columnSpacing = columnSpacing;

135+ Q_EMIT columnSpacingChanged();

136136

137137 if (isComponentComplete()) {

138138 relayout();

@@ -140,16 +140,16 @@ void VerticalJournal::setHorizontalSpacing(qreal horizontalSpacing)

140140 }

141141}

142142

143−qreal VerticalJournal::verticalSpacing() const

143+qreal VerticalJournal::rowSpacing() const

144144{

145− return m_verticalSpacing;

145+ return m_rowSpacing;

146146}

147147

148−void VerticalJournal::setVerticalSpacing(qreal verticalSpacing)

148+void VerticalJournal::setRowSpacing(qreal rowSpacing)

149149{

150− if (verticalSpacing != m_verticalSpacing) {

151− m_verticalSpacing = verticalSpacing;

152− Q_EMIT verticalSpacingChanged();

150+ if (rowSpacing != m_rowSpacing) {

151+ m_rowSpacing = rowSpacing;

152+ Q_EMIT rowSpacingChanged();

153153

154154 if (isComponentComplete()) {

155155 relayout();

@@ -258,7 +258,7 @@ void VerticalJournal::findBottomModelIndexToAdd(int *modelIndex, double *yPos)

258258 Q_FOREACH(const auto &column, m_columnVisibleItems) {

259259 if (!column.isEmpty()) {

260260 const ViewItem &item = column.last();

261− *yPos = qMin(*yPos, static_cast<double>(item.y() + item.height() + m_verticalSpacing));

261+ *yPos = qMin(*yPos, static_cast<double>(item.y() + item.height() + m_rowSpacing));

262262 *modelIndex = qMax(*modelIndex, item.m_modelIndex + 1);

263263 } else {

264264 *yPos = 0;

@@ -277,7 +277,7 @@ void VerticalJournal::findTopModelIndexToAdd(int *modelIndex, double *yPos)

277277 const auto &column = m_columnVisibleItems[i];

278278 if (!column.isEmpty()) {

279279 const ViewItem &item = column.first();

280− const auto itemTopPos = item.y() - m_verticalSpacing;

280+ const auto itemTopPos = item.y() - m_rowSpacing;

281281 if (itemTopPos > *yPos) {

282282 *yPos = itemTopPos;

283283 *modelIndex = item.m_modelIndex - 1;

@@ -393,11 +393,11 @@ void VerticalJournal::positionItem(int modelIndex, QQuickItem *item)

393393{

394394 // Check if we add it to the bottom of existing column items

395395 const QList<ViewItem> &firstColumn = m_columnVisibleItems[0];

396− qreal columnToAddY = !firstColumn.isEmpty() ? firstColumn.last().y() + firstColumn.last().height() : 0;

396+ qreal columnToAddY = !firstColumn.isEmpty() ? firstColumn.last().y() + firstColumn.last().height() : -m_rowSpacing;

397397 int columnToAddTo = 0;

398398 for (int i = 1; i < m_columnVisibleItems.count(); ++i) {

399399 const QList<ViewItem> &column = m_columnVisibleItems[i];

400− const qreal iY = !column.isEmpty() ? column.last().y() + column.last().height() : 0;

400+ const qreal iY = !column.isEmpty() ? column.last().y() + column.last().height() : -m_rowSpacing;

401401 if (iY < columnToAddY) {

402402 columnToAddTo = i;

403403 columnToAddY = iY;

@@ -406,8 +406,8 @@ void VerticalJournal::positionItem(int modelIndex, QQuickItem *item)

406406

407407 const QList<ViewItem> &columnToAdd = m_columnVisibleItems[columnToAddTo];

408408 if (columnToAdd.isEmpty() || columnToAdd.last().m_modelIndex < modelIndex) {

409− item->setX(columnToAddTo * m_columnWidth + m_horizontalSpacing * (columnToAddTo + 1));

410− item->setY(columnToAddY + m_verticalSpacing);

409+ item->setX(columnToAddTo * (m_columnWidth + m_columnSpacing));

410+ item->setY(columnToAddY + m_rowSpacing);

411411

412412 m_columnVisibleItems[columnToAddTo] << ViewItem(item, modelIndex);

413413 m_indexColumnMap[modelIndex] = columnToAddTo;

@@ -416,8 +416,8 @@ void VerticalJournal::positionItem(int modelIndex, QQuickItem *item)

416416 columnToAddTo = m_indexColumnMap[modelIndex];

417417 columnToAddY = m_columnVisibleItems[columnToAddTo].first().y();

418418

419− item->setX(columnToAddTo * m_columnWidth + m_horizontalSpacing * (columnToAddTo + 1));

420− item->setY(columnToAddY - m_verticalSpacing - item->height());

419+ item->setX(columnToAddTo * (m_columnWidth + m_columnSpacing));

420+ item->setY(columnToAddY - m_rowSpacing - item->height());

421421

422422 m_columnVisibleItems[columnToAddTo].prepend(ViewItem(item, modelIndex));

423423 }

@@ -458,7 +458,7 @@ void VerticalJournal::calculateImplicitHeight()

458458 if (!column.isEmpty()) {

459459 const ViewItem &item = column.last();

460460 lastModelIndex = qMax(lastModelIndex, item.m_modelIndex);

461− bottomMostY = qMax(bottomMostY, item.y() + item.height() + m_verticalSpacing);

461+ bottomMostY = qMax(bottomMostY, item.y() + item.height());

462462 }

463463 }

464464 if (lastModelIndex >= 0) {

@@ -512,7 +512,7 @@ void VerticalJournal::updatePolish()

512512

513513 qSort(allItems);

514514

515− const int nColumns = qMax(1., floor((double)(width() - m_horizontalSpacing) / (m_columnWidth + m_horizontalSpacing)));

515+ const int nColumns = qMax(1., floor((double)(width() + m_columnSpacing) / (m_columnWidth + m_columnSpacing)));

516516 m_columnVisibleItems.resize(nColumns);

517517 m_indexColumnMap.clear();

518518 for (int i = 0; i < nColumns; ++i)

plugins/DashViews/verticaljournal.h+11−15

@@ -33,7 +33,7 @@ class QQmlDelegateModel;

3333 *

3434 * The number of columns is calculated using the width of

3535 * the view itself, the columnWidth (i.e. the width of each individual delegate)

36− * and the horizontalSpacing between columns.

36+ * and the columnSpacing between columns.

3737 *

3838 * All delegates are forced to columnWidth if they don't have it.

3939 *

@@ -65,12 +65,8 @@ class QQmlDelegateModel;

6565 Q_PROPERTY(QAbstractItemModel *model READ model WRITE setModel NOTIFY modelChanged)

6666 Q_PROPERTY(QQmlComponent *delegate READ delegate WRITE setDelegate NOTIFY delegateChanged)

6767 Q_PROPERTY(qreal columnWidth READ columnWidth WRITE setColumnWidth NOTIFY columnWidthChanged)

68− Q_PROPERTY(qreal horizontalSpacing READ horizontalSpacing

69− WRITE setHorizontalSpacing

70− NOTIFY horizontalSpacingChanged)

71− Q_PROPERTY(qreal verticalSpacing READ verticalSpacing

72− WRITE setVerticalSpacing

73− NOTIFY verticalSpacingChanged)

68+ Q_PROPERTY(qreal columnSpacing READ columnSpacing WRITE setColumnSpacing NOTIFY columnSpacingChanged)

69+ Q_PROPERTY(qreal rowSpacing READ rowSpacing WRITE setRowSpacing NOTIFY rowSpacingChanged)

7470 Q_PROPERTY(qreal delegateCreationBegin READ delegateCreationBegin

7571 WRITE setDelegateCreationBegin

7672 NOTIFY delegateCreationBeginChanged

@@ -94,11 +90,11 @@ public:

9490 qreal columnWidth() const;

9591 void setColumnWidth(qreal columnWidth);

9692

97− qreal horizontalSpacing() const;

98− void setHorizontalSpacing(qreal horizontalSpacing);

93+ qreal columnSpacing() const;

94+ void setColumnSpacing(qreal columnSpacing);

9995

100− qreal verticalSpacing() const;

101− void setVerticalSpacing(qreal verticalSpacing);

96+ qreal rowSpacing() const;

97+ void setRowSpacing(qreal rowSpacing);

10298

10399 qreal delegateCreationBegin() const;

104100 void setDelegateCreationBegin(qreal);

@@ -112,8 +108,8 @@ Q_SIGNALS:

112108 void modelChanged();

113109 void delegateChanged();

114110 void columnWidthChanged();

115− void horizontalSpacingChanged();

116− void verticalSpacingChanged();

111+ void columnSpacingChanged();

112+ void rowSpacingChanged();

117113 void delegateCreationBeginChanged();

118114 void delegateCreationEndChanged();

119115

@@ -168,8 +164,8 @@ private:

168164 QVector<QList<ViewItem>> m_columnVisibleItems;

169165 QHash<int, int> m_indexColumnMap;

170166 int m_columnWidth;

171− int m_horizontalSpacing;

172− int m_verticalSpacing;

167+ int m_columnSpacing;

168+ int m_rowSpacing;

173169 qreal m_delegateCreationBegin;

174170 qreal m_delegateCreationEnd;

175171 bool m_delegateCreationBeginValid;

tests/plugins/DashViews/verticaljournaltest.cpp+124−121

@@ -22,7 +22,10 @@

2222#include <QtQml/qqml.h>

2323#include <QStringListModel>

2424#include <QQmlContext>

25+#pragma GCC diagnostic push

26+#pragma GCC diagnostic ignored "-pedantic"

2527#include <private/qquickitem_p.h>

28+#pragma GCC diagnostic pop

2629

2730#include "verticaljournal.h"

2831

@@ -56,25 +59,25 @@ private:

5659 QTRY_COMPARE(vj->m_columnVisibleItems[0].count(), 5);

5760 QTRY_COMPARE(vj->m_columnVisibleItems[1].count(), 7);

5861 QTRY_COMPARE(vj->m_columnVisibleItems[2].count(), 6);

59− verifyItem(vj->m_columnVisibleItems[0][0], 0, 10, 10, true);

60− verifyItem(vj->m_columnVisibleItems[1][0], 1, 170, 10, true);

61− verifyItem(vj->m_columnVisibleItems[2][0], 2, 330, 10, true);

62− verifyItem(vj->m_columnVisibleItems[1][1], 3, 170, 70, true);

63− verifyItem(vj->m_columnVisibleItems[1][2], 4, 170, 90, true);

64− verifyItem(vj->m_columnVisibleItems[0][1], 5, 10, 120, true);

65− verifyItem(vj->m_columnVisibleItems[1][3], 6, 170, 140, true);

66− verifyItem(vj->m_columnVisibleItems[2][1], 7, 330, 145, true);

67− verifyItem(vj->m_columnVisibleItems[0][2], 8, 10, 200, true);

68− verifyItem(vj->m_columnVisibleItems[2][2], 9, 330, 265, true);

69− verifyItem(vj->m_columnVisibleItems[2][3], 10, 330, 295, true);

70− verifyItem(vj->m_columnVisibleItems[2][4], 11, 330, 325, true);

71− verifyItem(vj->m_columnVisibleItems[1][4], 12, 170, 350, true);

72− verifyItem(vj->m_columnVisibleItems[0][3], 13, 10, 370, true);

73− verifyItem(vj->m_columnVisibleItems[2][5], 14, 330, 400, false);

74− verifyItem(vj->m_columnVisibleItems[1][5], 15, 170, 440, false);

75− verifyItem(vj->m_columnVisibleItems[0][4], 16, 10, 580, false);

76− verifyItem(vj->m_columnVisibleItems[1][6], 17, 170, 580, false);

77− QCOMPARE(vj->implicitHeight(), 990. + 2. * 990. / 18.);

62+ verifyItem(vj->m_columnVisibleItems[0][0], 0, 0, 0, true);

63+ verifyItem(vj->m_columnVisibleItems[1][0], 1, 160, 0, true);

64+ verifyItem(vj->m_columnVisibleItems[2][0], 2, 320, 0, true);

65+ verifyItem(vj->m_columnVisibleItems[1][1], 3, 160, 60, true);

66+ verifyItem(vj->m_columnVisibleItems[1][2], 4, 160, 80, true);

67+ verifyItem(vj->m_columnVisibleItems[0][1], 5, 0, 110, true);

68+ verifyItem(vj->m_columnVisibleItems[1][3], 6, 160, 130, true);

69+ verifyItem(vj->m_columnVisibleItems[2][1], 7, 320, 135, true);

70+ verifyItem(vj->m_columnVisibleItems[0][2], 8, 0, 190, true);

71+ verifyItem(vj->m_columnVisibleItems[2][2], 9, 320, 255, true);

72+ verifyItem(vj->m_columnVisibleItems[2][3], 10, 320, 285, true);

73+ verifyItem(vj->m_columnVisibleItems[2][4], 11, 320, 315, true);

74+ verifyItem(vj->m_columnVisibleItems[1][4], 12, 160, 340, true);

75+ verifyItem(vj->m_columnVisibleItems[0][3], 13, 0, 360, true);

76+ verifyItem(vj->m_columnVisibleItems[2][5], 14, 320, 390, true);

77+ verifyItem(vj->m_columnVisibleItems[1][5], 15, 160, 430, false);

78+ verifyItem(vj->m_columnVisibleItems[0][4], 16, 0, 570, false);

79+ verifyItem(vj->m_columnVisibleItems[1][6], 17, 160, 570, false);

80+ QCOMPARE(vj->implicitHeight(), 970. + 2. * 970. / 18.);

7881 }

7982

8083private Q_SLOTS:

@@ -99,7 +102,7 @@ private Q_SLOTS:

99102 view->setSource(QUrl::fromLocalFile(DASHVIEWSTEST_FOLDER "/verticaljournaltest.qml"));

100103

101104 view->show();

102− view->resize(490, 400);

105+ view->resize(470, 400);

103106 QTest::qWaitForWindowExposed(view);

104107

105108 vj = view->rootObject()->findChild<VerticalJournal*>();

@@ -116,41 +119,41 @@ private Q_SLOTS:

116119

117120 void testWidthResize()

118121 {

119− view->resize(649, 400);

122+ view->resize(629, 400);

120123

121124 // This is exactly the same block as above as nothing changed, just white space on the right

122125 checkInitialPositions();

123126

124− view->resize(650, 400);

127+ view->resize(630, 400);

125128

126129 QTRY_COMPARE(vj->m_columnVisibleItems.count(), 4);

127130 QTRY_COMPARE(vj->m_columnVisibleItems[0].count(), 4);

128131 QTRY_COMPARE(vj->m_columnVisibleItems[1].count(), 7);

129132 QTRY_COMPARE(vj->m_columnVisibleItems[2].count(), 4);

130133 QTRY_COMPARE(vj->m_columnVisibleItems[3].count(), 5);

131− verifyItem(vj->m_columnVisibleItems[0][0], 0, 10, 10, true);

132− verifyItem(vj->m_columnVisibleItems[1][0], 1, 170, 10, true);

133− verifyItem(vj->m_columnVisibleItems[2][0], 2, 330, 10, true);

134− verifyItem(vj->m_columnVisibleItems[3][0], 3, 490, 10, true);

135− verifyItem(vj->m_columnVisibleItems[3][1], 4, 490, 30, true);

136− verifyItem(vj->m_columnVisibleItems[1][1], 5, 170, 70, true);

137− verifyItem(vj->m_columnVisibleItems[3][2], 6, 490, 80, true);

138− verifyItem(vj->m_columnVisibleItems[0][1], 7, 10, 120, true);

139− verifyItem(vj->m_columnVisibleItems[2][1], 8, 330, 145, true);

140− verifyItem(vj->m_columnVisibleItems[1][2], 9, 170, 150, true);

141− verifyItem(vj->m_columnVisibleItems[1][3], 10, 170, 180, true);

142− verifyItem(vj->m_columnVisibleItems[1][4], 11, 170, 210, true);

143− verifyItem(vj->m_columnVisibleItems[0][2], 12, 10, 240, true);

144− verifyItem(vj->m_columnVisibleItems[1][5], 13, 170, 285, true);

145− verifyItem(vj->m_columnVisibleItems[3][3], 14, 490, 290, true);

146− verifyItem(vj->m_columnVisibleItems[2][2], 15, 330, 315, true);

147− verifyItem(vj->m_columnVisibleItems[0][3], 16, 10, 330, true);

148− verifyItem(vj->m_columnVisibleItems[2][3], 17, 330, 455, false);

149− verifyItem(vj->m_columnVisibleItems[1][6], 18, 170, 495, false);

150− verifyItem(vj->m_columnVisibleItems[3][4], 19, 490, 600, false);

151− QTRY_COMPARE(vj->implicitHeight(), 1005.);

152−

153− view->resize(490, 400);

134+ verifyItem(vj->m_columnVisibleItems[0][0], 0, 0, 0, true);

135+ verifyItem(vj->m_columnVisibleItems[1][0], 1, 160, 0, true);

136+ verifyItem(vj->m_columnVisibleItems[2][0], 2, 320, 0, true);

137+ verifyItem(vj->m_columnVisibleItems[3][0], 3, 480, 0, true);

138+ verifyItem(vj->m_columnVisibleItems[3][1], 4, 480, 20, true);

139+ verifyItem(vj->m_columnVisibleItems[1][1], 5, 160, 60, true);

140+ verifyItem(vj->m_columnVisibleItems[3][2], 6, 480, 70, true);

141+ verifyItem(vj->m_columnVisibleItems[0][1], 7, 0, 110, true);

142+ verifyItem(vj->m_columnVisibleItems[2][1], 8, 320, 135, true);

143+ verifyItem(vj->m_columnVisibleItems[1][2], 9, 160, 140, true);

144+ verifyItem(vj->m_columnVisibleItems[1][3], 10, 160, 170, true);

145+ verifyItem(vj->m_columnVisibleItems[1][4], 11, 160, 200, true);

146+ verifyItem(vj->m_columnVisibleItems[0][2], 12, 0, 230, true);

147+ verifyItem(vj->m_columnVisibleItems[1][5], 13, 160, 275, true);

148+ verifyItem(vj->m_columnVisibleItems[3][3], 14, 480, 280, true);

149+ verifyItem(vj->m_columnVisibleItems[2][2], 15, 320, 305, true);

150+ verifyItem(vj->m_columnVisibleItems[0][3], 16, 0, 320, true);

151+ verifyItem(vj->m_columnVisibleItems[2][3], 17, 320, 445, false);

152+ verifyItem(vj->m_columnVisibleItems[1][6], 18, 160, 485, false);

153+ verifyItem(vj->m_columnVisibleItems[3][4], 19, 480, 590, false);

154+ QTRY_COMPARE(vj->implicitHeight(), 985.);

155+

156+ view->resize(470, 400);

154157

155158 // This is exactly the same block as the first again

156159 checkInitialPositions();

@@ -158,29 +161,29 @@ private Q_SLOTS:

158161

159162 void testHorizontalSpacing()

160163 {

161− vj->setHorizontalSpacing(11);

164+ vj->setColumnSpacing(11);

162165

163166 QTRY_COMPARE(vj->m_needsRelayout, false);

164167 QTRY_COMPARE(vj->m_columnVisibleItems.count(), 2);

165168 QTRY_COMPARE(vj->m_columnVisibleItems[0].count(), 7);

166169 QTRY_COMPARE(vj->m_columnVisibleItems[1].count(), 7);

167− verifyItem(vj->m_columnVisibleItems[0][0], 0, 11, 10, true);

168− verifyItem(vj->m_columnVisibleItems[1][0], 1, 172, 10, true);

169− verifyItem(vj->m_columnVisibleItems[1][1], 2, 172, 70, true);

170− verifyItem(vj->m_columnVisibleItems[0][1], 3, 11, 120, true);

171− verifyItem(vj->m_columnVisibleItems[0][2], 4, 11, 140, true);

172− verifyItem(vj->m_columnVisibleItems[0][3], 5, 11, 190, true);

173− verifyItem(vj->m_columnVisibleItems[1][2], 6, 172, 205, true);

174− verifyItem(vj->m_columnVisibleItems[0][4], 7, 11, 270, true);

175− verifyItem(vj->m_columnVisibleItems[0][5], 8, 11, 390, true);

176− verifyItem(vj->m_columnVisibleItems[1][3], 9, 172, 415, false);

177− verifyItem(vj->m_columnVisibleItems[1][4], 10, 172, 445, false);

178− verifyItem(vj->m_columnVisibleItems[1][5], 11, 172, 475, false);

179− verifyItem(vj->m_columnVisibleItems[1][6], 12, 172, 550, false);

180− verifyItem(vj->m_columnVisibleItems[0][6], 13, 11, 560, false);

181− QCOMPARE(vj->implicitHeight(), 770. + 6. * 770. / 14.);

182−

183− vj->setHorizontalSpacing(10);

170+ verifyItem(vj->m_columnVisibleItems[0][0], 0, 0, 0, true);

171+ verifyItem(vj->m_columnVisibleItems[1][0], 1, 161, 0, true);

172+ verifyItem(vj->m_columnVisibleItems[1][1], 2, 161, 60, true);

173+ verifyItem(vj->m_columnVisibleItems[0][1], 3, 0, 110, true);

174+ verifyItem(vj->m_columnVisibleItems[0][2], 4, 0, 130, true);

175+ verifyItem(vj->m_columnVisibleItems[0][3], 5, 0, 180, true);

176+ verifyItem(vj->m_columnVisibleItems[1][2], 6, 161, 195, true);

177+ verifyItem(vj->m_columnVisibleItems[0][4], 7, 0, 260, true);

178+ verifyItem(vj->m_columnVisibleItems[0][5], 8, 0, 380, true);

179+ verifyItem(vj->m_columnVisibleItems[1][3], 9, 161, 405, false);

180+ verifyItem(vj->m_columnVisibleItems[1][4], 10, 161, 435, false);

181+ verifyItem(vj->m_columnVisibleItems[1][5], 11, 161, 465, false);

182+ verifyItem(vj->m_columnVisibleItems[1][6], 12, 161, 540, false);

183+ verifyItem(vj->m_columnVisibleItems[0][6], 13, 0, 550, false);

184+ QCOMPARE(vj->implicitHeight(), 750. + 6. * 750. / 14.);

185+

186+ vj->setColumnSpacing(10);

184187 QTRY_COMPARE(vj->m_needsRelayout, false);

185188

186189 // This is exactly the same block as the first again

@@ -189,34 +192,34 @@ private Q_SLOTS:

189192

190193 void testVerticalSpacing()

191194 {

192− vj->setVerticalSpacing(11);

195+ vj->setRowSpacing(11);

193196

194197 QTRY_COMPARE(vj->m_needsRelayout, false);

195198 QTRY_COMPARE(vj->m_columnVisibleItems.count(), 3);

196199 QTRY_COMPARE(vj->m_columnVisibleItems[0].count(), 5);

197200 QTRY_COMPARE(vj->m_columnVisibleItems[1].count(), 7);

198201 QTRY_COMPARE(vj->m_columnVisibleItems[2].count(), 6);

199− verifyItem(vj->m_columnVisibleItems[0][0], 0, 10, 11, true);

200− verifyItem(vj->m_columnVisibleItems[1][0], 1, 170, 11, true);

201− verifyItem(vj->m_columnVisibleItems[2][0], 2, 330, 11, true);

202− verifyItem(vj->m_columnVisibleItems[1][1], 3, 170, 72, true);

203− verifyItem(vj->m_columnVisibleItems[1][2], 4, 170, 93, true);

204− verifyItem(vj->m_columnVisibleItems[0][1], 5, 10, 122, true);

205− verifyItem(vj->m_columnVisibleItems[1][3], 6, 170, 144, true);

206− verifyItem(vj->m_columnVisibleItems[2][1], 7, 330, 147, true);

207− verifyItem(vj->m_columnVisibleItems[0][2], 8, 10, 203, true);

208− verifyItem(vj->m_columnVisibleItems[2][2], 9, 330, 268, true);

209− verifyItem(vj->m_columnVisibleItems[2][3], 10, 330, 299, true);

210− verifyItem(vj->m_columnVisibleItems[2][4], 11, 330, 330, true);

211− verifyItem(vj->m_columnVisibleItems[1][4], 12, 170, 355, true);

212− verifyItem(vj->m_columnVisibleItems[0][3], 13, 10, 374, true);

213− verifyItem(vj->m_columnVisibleItems[2][5], 14, 330, 406, false);

214− verifyItem(vj->m_columnVisibleItems[1][5], 15, 170, 446, false);

215− verifyItem(vj->m_columnVisibleItems[0][4], 16, 10, 585, false);

216− verifyItem(vj->m_columnVisibleItems[1][6], 17, 170, 587, false);

217− QCOMPARE(vj->implicitHeight(), 990. + 2. * 990. / 18.);

218−

219− vj->setVerticalSpacing(10);

202+ verifyItem(vj->m_columnVisibleItems[0][0], 0, 0, 0, true);

203+ verifyItem(vj->m_columnVisibleItems[1][0], 1, 160, 0, true);

204+ verifyItem(vj->m_columnVisibleItems[2][0], 2, 320, 0, true);

205+ verifyItem(vj->m_columnVisibleItems[1][1], 3, 160, 61, true);

206+ verifyItem(vj->m_columnVisibleItems[1][2], 4, 160, 82, true);

207+ verifyItem(vj->m_columnVisibleItems[0][1], 5, 0, 111, true);

208+ verifyItem(vj->m_columnVisibleItems[1][3], 6, 160, 133, true);

209+ verifyItem(vj->m_columnVisibleItems[2][1], 7, 320, 136, true);

210+ verifyItem(vj->m_columnVisibleItems[0][2], 8, 0, 192, true);

211+ verifyItem(vj->m_columnVisibleItems[2][2], 9, 320, 257, true);

212+ verifyItem(vj->m_columnVisibleItems[2][3], 10, 320, 288, true);

213+ verifyItem(vj->m_columnVisibleItems[2][4], 11, 320, 319, true);

214+ verifyItem(vj->m_columnVisibleItems[1][4], 12, 160, 344, true);

215+ verifyItem(vj->m_columnVisibleItems[0][3], 13, 0, 363, true);

216+ verifyItem(vj->m_columnVisibleItems[2][5], 14, 320, 395, true);

217+ verifyItem(vj->m_columnVisibleItems[1][5], 15, 160, 435, false);

218+ verifyItem(vj->m_columnVisibleItems[0][4], 16, 0, 574, false);

219+ verifyItem(vj->m_columnVisibleItems[1][6], 17, 160, 576, false);

220+ QCOMPARE(vj->implicitHeight(), 970. + 2. * 970. / 18.);

221+

222+ vj->setRowSpacing(10);

220223 QTRY_COMPARE(vj->m_needsRelayout, false);

221224

222225 // This is exactly the same block as the first again

@@ -232,21 +235,21 @@ private Q_SLOTS:

232235 QTRY_COMPARE(vj->m_columnVisibleItems[0].count(), 4);

233236 QTRY_COMPARE(vj->m_columnVisibleItems[1].count(), 4);

234237 QTRY_COMPARE(vj->m_columnVisibleItems[2].count(), 6);

235− verifyItem(vj->m_columnVisibleItems[0][0], 0, 10, 10, false);

236− verifyItem(vj->m_columnVisibleItems[2][0], 2, 330, 10, false);

237− verifyItem(vj->m_columnVisibleItems[1][0], 4, 170, 90, false);

238− verifyItem(vj->m_columnVisibleItems[0][1], 5, 10, 120, false);

239− verifyItem(vj->m_columnVisibleItems[1][1], 6, 170, 140, true);

240− verifyItem(vj->m_columnVisibleItems[2][1], 7, 330, 145, true);

241− verifyItem(vj->m_columnVisibleItems[0][2], 8, 10, 200, true);

242− verifyItem(vj->m_columnVisibleItems[2][2], 9, 330, 265, true);

243− verifyItem(vj->m_columnVisibleItems[2][3], 10, 330, 295, true);

244− verifyItem(vj->m_columnVisibleItems[2][4], 11, 330, 325, true);

245− verifyItem(vj->m_columnVisibleItems[1][2], 12, 170, 350, true);

246− verifyItem(vj->m_columnVisibleItems[0][3], 13, 10, 370, true);

247− verifyItem(vj->m_columnVisibleItems[2][5], 14, 330, 400, false);

248− verifyItem(vj->m_columnVisibleItems[1][3], 15, 170, 440, false);

249− QCOMPARE(vj->implicitHeight(), 710. + 4. * 710. / 16.);

238+ verifyItem(vj->m_columnVisibleItems[0][0], 0, 0, 0, false);

239+ verifyItem(vj->m_columnVisibleItems[2][0], 2, 320, 0, false);

240+ verifyItem(vj->m_columnVisibleItems[1][0], 4, 160, 80, false);

241+ verifyItem(vj->m_columnVisibleItems[0][1], 5, 0, 110, false);

242+ verifyItem(vj->m_columnVisibleItems[1][1], 6, 160, 130, true);

243+ verifyItem(vj->m_columnVisibleItems[2][1], 7, 320, 135, true);

244+ verifyItem(vj->m_columnVisibleItems[0][2], 8, 0, 190, true);

245+ verifyItem(vj->m_columnVisibleItems[2][2], 9, 320, 255, true);

246+ verifyItem(vj->m_columnVisibleItems[2][3], 10, 320, 285, true);

247+ verifyItem(vj->m_columnVisibleItems[2][4], 11, 320, 315, true);

248+ verifyItem(vj->m_columnVisibleItems[1][2], 12, 160, 340, true);

249+ verifyItem(vj->m_columnVisibleItems[0][3], 13, 0, 360, true);

250+ verifyItem(vj->m_columnVisibleItems[2][5], 14, 320, 390, true);

251+ verifyItem(vj->m_columnVisibleItems[1][3], 15, 160, 430, false);

252+ QCOMPARE(vj->implicitHeight(), 690. + 4. * 690. / 16.);

250253

251254 vj->resetDelegateCreationBegin();

252255 vj->resetDelegateCreationEnd();

@@ -262,21 +265,21 @@ private Q_SLOTS:

262265 QTRY_COMPARE(vj->m_columnVisibleItems.count(), 2);

263266 QTRY_COMPARE(vj->m_columnVisibleItems[0].count(), 7);

264267 QTRY_COMPARE(vj->m_columnVisibleItems[1].count(), 7);

265− verifyItem(vj->m_columnVisibleItems[0][0], 0, 10, 10, true);

266− verifyItem(vj->m_columnVisibleItems[1][0], 1, 220, 10, true);

267− verifyItem(vj->m_columnVisibleItems[1][1], 2, 220, 70, true);

268− verifyItem(vj->m_columnVisibleItems[0][1], 3, 10, 120, true);

269− verifyItem(vj->m_columnVisibleItems[0][2], 4, 10, 140, true);

270− verifyItem(vj->m_columnVisibleItems[0][3], 5, 10, 190, true);

271− verifyItem(vj->m_columnVisibleItems[1][2], 6, 220, 205, true);

272− verifyItem(vj->m_columnVisibleItems[0][4], 7, 10, 270, true);

273− verifyItem(vj->m_columnVisibleItems[0][5], 8, 10, 390, true);

274− verifyItem(vj->m_columnVisibleItems[1][3], 9, 220, 415, false);

275− verifyItem(vj->m_columnVisibleItems[1][4], 10, 220, 445, false);

276− verifyItem(vj->m_columnVisibleItems[1][5], 11, 220, 475, false);

277− verifyItem(vj->m_columnVisibleItems[1][6], 12, 220, 550, false);

278− verifyItem(vj->m_columnVisibleItems[0][6], 13, 10, 560, false);

279− QCOMPARE(vj->implicitHeight(), 770. + 6. * 770. / 14.);

268+ verifyItem(vj->m_columnVisibleItems[0][0], 0, 0, 0, true);

269+ verifyItem(vj->m_columnVisibleItems[1][0], 1, 210, 0, true);

270+ verifyItem(vj->m_columnVisibleItems[1][1], 2, 210, 60, true);

271+ verifyItem(vj->m_columnVisibleItems[0][1], 3, 0, 110, true);

272+ verifyItem(vj->m_columnVisibleItems[0][2], 4, 0, 130, true);

273+ verifyItem(vj->m_columnVisibleItems[0][3], 5, 0, 180, true);

274+ verifyItem(vj->m_columnVisibleItems[1][2], 6, 210, 195, true);

275+ verifyItem(vj->m_columnVisibleItems[0][4], 7, 0, 260, true);

276+ verifyItem(vj->m_columnVisibleItems[0][5], 8, 0, 380, true);

277+ verifyItem(vj->m_columnVisibleItems[1][3], 9, 210, 405, false);

278+ verifyItem(vj->m_columnVisibleItems[1][4], 10, 210, 435, false);

279+ verifyItem(vj->m_columnVisibleItems[1][5], 11, 210, 465, false);

280+ verifyItem(vj->m_columnVisibleItems[1][6], 12, 210, 540, false);

281+ verifyItem(vj->m_columnVisibleItems[0][6], 13, 0, 550, false);

282+ QCOMPARE(vj->implicitHeight(), 750. + 6. * 750. / 14.);

280283

281284 vj->setColumnWidth(150);

282285

@@ -297,12 +300,12 @@ private Q_SLOTS:

297300 QTRY_COMPARE(vj->m_columnVisibleItems[0].count(), 1);

298301 QTRY_COMPARE(vj->m_columnVisibleItems[1].count(), 2);

299302 QTRY_COMPARE(vj->m_columnVisibleItems[2].count(), 3);

300− verifyItem(vj->m_columnVisibleItems[0][0], 0, 10, 10, true);

301− verifyItem(vj->m_columnVisibleItems[1][0], 1, 170, 10, true);

302− verifyItem(vj->m_columnVisibleItems[2][0], 2, 330, 10, true);

303− verifyItem(vj->m_columnVisibleItems[2][1], 3, 330, 45, true);

304− verifyItem(vj->m_columnVisibleItems[1][1], 4, 170, 70, true);

305− verifyItem(vj->m_columnVisibleItems[2][2], 5, 330, 80, true);

303+ verifyItem(vj->m_columnVisibleItems[0][0], 0, 0, 0, true);

304+ verifyItem(vj->m_columnVisibleItems[1][0], 1, 160, 0, true);

305+ verifyItem(vj->m_columnVisibleItems[2][0], 2, 320, 0, true);

306+ verifyItem(vj->m_columnVisibleItems[2][1], 3, 320, 35, true);

307+ verifyItem(vj->m_columnVisibleItems[1][1], 4, 160, 60, true);

308+ verifyItem(vj->m_columnVisibleItems[2][2], 5, 320, 70, true);

306309 }

307310

308311private:

tests/plugins/DashViews/verticaljournaltest.qml+2−2

@@ -23,8 +23,8 @@ Item {

2323 id: vj

2424 anchors.fill: parent

2525 columnWidth: 150

26− horizontalSpacing: 10

27− verticalSpacing: 10

26+ columnSpacing: 10

27+ rowSpacing: 10

2828

2929 delegate: Rectangle {

3030 property real randomValue: Math.random()