add outter margin and a comment explaining the dummy container
commit9aff648fc0dc638f72c8f3e03b517718b6dd80bd
authorLukáš Tinkl <lukas.tinkl@canonical.com>
dateWed 11 May 2016, 13:09 (10 years ago)
parent3e44d9c
qml/Components/KeyboardShortcutsOverlay.qml+1−1
@@ -28,7 +28,7 @@ Rectangle {
2828 readonly property int maxTextSize: (root.parent.width / 4) - padding
2929 readonly property int padding: units.gu(4)
3030
31− Item {
31+ Item { // dummy container to break binding loops *and* keep the margins in topLayout working
3232 GridLayout {
3333 id: topLayout
3434 anchors.fill: parent
qml/Shell.qml+2−2
@@ -619,8 +619,8 @@ Item {
619619
620620 KeyboardShortcutsOverlay {
621621 objectName: "shortcutsOverlay"
622− visible: launcher.shortcutHintsShown && width < parent.width - (launcher.lockedVisible ? launcher.panelWidth : 0)
623− && height < parent.height
622+ visible: launcher.shortcutHintsShown && width < parent.width - (launcher.lockedVisible ? launcher.panelWidth : 0) - padding
623+ && height < parent.height - padding
624624 enabled: visible
625625 anchors.centerIn: parent
626626 anchors.horizontalCenterOffset: launcher.lockedVisible ? launcher.panelWidth/2 : 0