on xenial help sign in
Removed _ prefixes.
commit9fa879e149091242fd2a8dc04023c77559c1a814 authorNick Dedekind <nicholas.dedekind@gmail.com> dateWed 3 Jul 2013, 11:39 (13 years ago) parent68669d9
21 files changed+123−136
modules/Unity/Indicators/Messaging/qml/ActionButton.qml+3−3 modules/Unity/Indicators/Messaging/qml/ActionTextField.qml+9−9 modules/Unity/Indicators/Messaging/qml/GroupedMessage.qml+2−2 modules/Unity/Indicators/Messaging/qml/HeroMessage.qml+5−5 modules/Unity/Indicators/Messaging/qml/HeroMessageHeader.qml+14−14 modules/Unity/Indicators/Messaging/qml/MessageMenuItem.qml+15−17 modules/Unity/Indicators/Messaging/qml/QuickReply.qml+12−12 modules/Unity/Indicators/Messaging/qml/SimpleTextMessage.qml+8−8 modules/Unity/Indicators/Messaging/qml/SnapDecision.qml+15−15 modules/Unity/Indicators/Messaging/qml/TextMessage.qml+2−2 modules/Unity/Indicators/Network/qml/AccessPoint.qml+2−2 modules/Unity/Indicators/Network/qml/WifiSection.qml+2−2 modules/Unity/Indicators/qml/BasicMenuItem.qml+4−4 modules/Unity/Indicators/qml/ButtonMenuItem.qml+2−2 modules/Unity/Indicators/qml/MenuItem.qml−1 modules/Unity/Indicators/qml/MenuItemFactory.qml+10−10 modules/Unity/Indicators/qml/ProgressMenuItem.qml+3−3 modules/Unity/Indicators/qml/RemoveBackground.qml+5−9 modules/Unity/Indicators/qml/SectionMenuItem.qml−6 modules/Unity/Indicators/qml/SwitchMenuItem.qml+2−2 modules/Unity/Indicators/qml/TextMenuItem.qml+8−8
modules/Unity/Indicators/Messaging/qml/ActionButton.qml+3−3
@@ -23,7 +23,7 @@ import Ubuntu.Components 0.1
2323import Unity.Indicators 0.1 as Indicators
2424
2525Button {
26− id: __button
26+ id: button
2727 property QtObject actionGroup: null
2828 property string action
2929
@@ -31,8 +31,8 @@ Button {
3131
3232 Indicators.MenuAction {
3333 id: menuAction
34− actionGroup: __button.actionGroup
35− action: __button.action
34+ actionGroup: button.actionGroup
35+ action: button.action
3636 }
3737
3838 onClicked: {
modules/Unity/Indicators/Messaging/qml/ActionTextField.qml+9−9
@@ -22,20 +22,20 @@ import QtQuick 2.0
2222import Ubuntu.Components 0.1
2323
2424Item {
25− property alias actionGroup: __sendButton.actionGroup
26− property alias action: __sendButton.action
25+ property alias actionGroup: sendButton.actionGroup
26+ property alias action: sendButton.action
2727
28− property alias text: __replyField.text
29− property alias buttonText: __sendButton.text
28+ property alias text: replyField.text
29+ property alias buttonText: sendButton.text
3030
3131 TextField {
32− id: __replyField
32+ id: replyField
3333
3434 anchors {
3535 top: parent.top
3636 bottom: parent.bottom
3737 left: parent.left
38− right: __sendButton.left
38+ right: sendButton.left
3939 rightMargin: units.gu(1)
4040 }
4141 placeholderText: "Reply"
@@ -51,16 +51,16 @@ Item {
5151 }
5252
5353 ActionButton {
54− id: __sendButton
54+ id: sendButton
5555
56− actionParameter: __replyField.text
56+ actionParameter: replyField.text
5757 anchors {
5858 top: parent.top
5959 bottom: parent.bottom
6060 right: parent.right
6161 }
6262 width: units.gu(9)
63− enabled: __replyField.text !== ""
63+ enabled: replyField.text !== ""
6464 color: enabled ? "#c94212" : "#bababa"
6565 }
6666}
modules/Unity/Indicators/Messaging/qml/GroupedMessage.qml+2−2
@@ -23,7 +23,7 @@ import Ubuntu.Components 0.1
2323import Unity.Indicators 0.1 as Indicators
2424
2525Indicators.BasicMenuItem {
26− id: __groupedMessage
26+ id: groupedMessage
2727 property alias count: label.text
2828
2929 color: "#221e1b"
@@ -31,7 +31,7 @@ Indicators.BasicMenuItem {
3131
3232 Indicators.MenuAction {
3333 id: menuAction
34− actionGroup: __groupedMessage.actionGroup
34+ actionGroup: groupedMessage.actionGroup
3535 action: menu ? menu.action : ""
3636 }
3737
modules/Unity/Indicators/Messaging/qml/HeroMessage.qml+5−5
@@ -23,7 +23,7 @@ import Ubuntu.Components 0.1
2323import Unity.Indicators 0.1 as Indicators
2424
2525Indicators.BasicMenuItem {
26− id: __heroMessage
26+ id: heroMessage
2727
2828 property variant actionsDescription: null
2929 property alias heroMessageHeader: __heroMessageHeader
@@ -37,7 +37,7 @@ Indicators.BasicMenuItem {
3737
3838 Indicators.MenuAction {
3939 id: menuAction
40− actionGroup: __heroMessage.actionGroup
40+ actionGroup: heroMessage.actionGroup
4141 action: menu ? menu.action : ""
4242 }
4343
@@ -52,7 +52,7 @@ Indicators.BasicMenuItem {
5252 icon: menu && (menu.extra.canonical_app_icon.length > 0) ? "image://gicon/" + encodeURI(menu.extra.canonical_app_icon) : ""
5353 appIcon: icon
5454
55− state: __heroMessage.state
55+ state: heroMessage.state
5656
5757 onAppIconClicked: {
5858 if (menuAction.valid) {
@@ -87,9 +87,9 @@ Indicators.BasicMenuItem {
8787 when: menuActivated
8888
8989 PropertyChanges {
90− target: __heroMessage
90+ target: heroMessage
9191 color: "#333130"
92− implicitHeight: __heroMessage.expandedHeight
92+ implicitHeight: heroMessage.expandedHeight
9393 }
9494 PropertyChanges {
9595 target: __topHLine
modules/Unity/Indicators/Messaging/qml/HeroMessageHeader.qml+14−14
@@ -22,22 +22,22 @@ import QtQuick 2.0
2222import Ubuntu.Components 0.1
2323
2424Item {
25− id: __heroMessageHeader
25+ id: heroMessageHeader
2626
27− property alias avatar: __avatarImage.source
28− property alias icon: __iconImage.source
29− property alias appIcon: __appIconImage.source
27+ property alias avatar: avatarImage.source
28+ property alias icon: iconImage.source
29+ property alias appIcon: appIconImage.source
3030 property alias titleText: __titleText
3131 property alias subtitleText: __subtitleText
3232 property alias bodyText: __bodyText
33− property real bodyBottom: __bodyText.y + __bodyText.height
33+ property real bodyBottom: bodyText.y + bodyText.height
3434
3535 signal appIconClicked()
3636
3737 height: units.gu(9)
3838
3939 UbuntuShape {
40− id: __avatarImageContainer
40+ id: avatarImageContainer
4141 anchors {
4242 top: parent.top
4343 topMargin: units.gu(2)
@@ -47,17 +47,17 @@ Item {
4747 height: units.gu(6)
4848 width: units.gu(6)
4949 image: Image {
50− id: __avatarImage
50+ id: avatarImage
5151 fillMode: Image.PreserveAspectFit
5252 }
5353 }
5454
5555 Image {
56− id: __iconImage
56+ id: iconImage
5757 anchors {
5858 top: parent.top
5959 topMargin: units.gu(2)
60− left: __avatarImageContainer.right
60+ left: avatarImageContainer.right
6161 leftMargin: units.gu(1)
6262 }
6363 height: units.gu(1.5)
@@ -70,8 +70,8 @@ Item {
7070 Label {
7171 id: __titleText
7272 anchors {
73− baseline: __iconImage.bottom
74− left: __iconImage.right
73+ baseline: iconImage.bottom
74+ left: iconImage.right
7575 leftMargin: units.gu(1)
7676 right: __appIcon.left
7777 rightMargin: units.gu(2)
@@ -120,10 +120,10 @@ Item {
120120 right: parent.right
121121 }
122122 opacity: 0.0
123− enabled: __heroMessageHeader.state === "expanded"
123+ enabled: heroMessageHeader.state === "expanded"
124124
125125 Image {
126− id: __appIconImage
126+ id: appIconImage
127127 height: width
128128 anchors {
129129 left: parent.left
@@ -138,7 +138,7 @@ Item {
138138
139139 MouseArea {
140140 anchors.fill: parent
141− onClicked: __heroMessageHeader.appIconClicked()
141+ onClicked: heroMessageHeader.appIconClicked()
142142 }
143143 }
144144
modules/Unity/Indicators/Messaging/qml/MessageMenuItem.qml+15−17
@@ -23,50 +23,48 @@ import Ubuntu.Components 0.1
2323import Unity.Indicators 0.1 as Indicators
2424
2525Indicators.BasicMenuItem {
26− id: __messageItem
27−
2826 property variant actionsDescription: menu ? menu.extra.canonical_message_actions : undefined
2927
3028 onActionGroupChanged: loadItem()
3129 onActionsDescriptionChanged: loadItem()
32− implicitHeight: __contents.status == Loader.Ready ? __contents.item.implicitHeight : 0
30+ implicitHeight: contents.status == Loader.Ready ? contents.item.implicitHeight : 0
3331
3432 Loader {
35− id: __contents
33+ id: contents
3634
3735 anchors.fill: parent
3836 // Binding all properties for the item, to make sure that any change in the
39− // property will be propagated to the __contents.item at any time
37+ // property will be propagated to the contents.item at any time
4038 Binding {
41− target: __contents.item
39+ target: contents.item
4240 property: "menuActivated"
4341 value: menuActivated
44− when: (__contents.status == Loader.Ready)
42+ when: (contents.status == Loader.Ready)
4543 }
4644
4745 Binding {
48− target: __contents.item
46+ target: contents.item
4947 property: "actionGroup"
5048 value: actionGroup
51− when: (__contents.status == Loader.Ready)
49+ when: (contents.status == Loader.Ready)
5250 }
5351
5452 Binding {
55− target: __contents.item
53+ target: contents.item
5654 property: "menu"
5755 value: menu
58− when: (__contents.status == Loader.Ready)
56+ when: (contents.status == Loader.Ready)
5957 }
6058
6159 Binding {
62− target: __contents.item
60+ target: contents.item
6361 property: "actionsDescription"
6462 value: actionsDescription
65− when: (__contents.status == Loader.Ready)
63+ when: (contents.status == Loader.Ready)
6664 }
6765
6866 Connections {
69− target: __contents.item ? __contents.item : null
67+ target: contents.item ? contents.item : null
7068 onActivateMenu: activateMenu()
7169 onDeactivateMenu: deactivateMenu()
7270 }
@@ -86,11 +84,11 @@ Indicators.BasicMenuItem {
8684 }
8785
8886 if (parameterType === "") {
89− __contents.source = "SimpleTextMessage.qml";
87+ contents.source = "SimpleTextMessage.qml";
9088 } else if (parameterType === "s") {
91− __contents.source = "TextMessage.qml";
89+ contents.source = "TextMessage.qml";
9290 } else if (parameterType === "_s") {
93− __contents.source = "SnapDecision.qml";
91+ contents.source = "SnapDecision.qml";
9492 } else {
9593 console.debug("Unknown paramater type: " + parameterType);
9694 }
modules/Unity/Indicators/Messaging/qml/QuickReply.qml+12−12
@@ -23,15 +23,15 @@ import Ubuntu.Components 0.1
2323import Unity.Indicators 0.1 as Indicators
2424
2525Item {
26− property alias actionGroup: __actionTextField.actionGroup
27− property alias action: __actionTextField.action
26+ property alias actionGroup: actionTextField.actionGroup
27+ property alias action: actionTextField.action
2828
29− property alias buttonText: __actionTextField.buttonText
29+ property alias buttonText: actionTextField.buttonText
3030 property real expandedHeight: childrenRect.height
31− property alias messages : __messagelistRepeater.model
31+ property alias messages : messagelistRepeater.model
3232
3333 Item {
34− id: __header
34+ id: header
3535 anchors.top: parent.top
3636 anchors.left: parent.left
3737 anchors.right: parent.right
@@ -70,21 +70,21 @@ Item {
7070 }
7171
7272 Column {
73− id: __messagelist
73+ id: messagelist
7474 anchors {
7575 left: parent.left
7676 right: parent.right
77− top: __header.bottom
77+ top: header.bottom
7878 }
7979 height: childrenRect.height
8080
8181 Repeater {
82− id: __messagelistRepeater
82+ id: messagelistRepeater
8383
8484 height: childrenRect.height
8585
8686 Rectangle {
87− width: __messagelist.width
87+ width: messagelist.width
8888 height: units.gu(5)
8989 color: "#333230"
9090
@@ -117,7 +117,7 @@ Item {
117117
118118 anchors.fill: parent
119119 onClicked: {
120− __actionTextField.text = modelData;
120+ actionTextField.text = modelData;
121121 }
122122 }
123123
@@ -140,13 +140,13 @@ Item {
140140 }
141141
142142 Item {
143− anchors.top: __messagelist.bottom
143+ anchors.top: messagelist.bottom
144144 anchors.left: parent.left
145145 anchors.right: parent.right
146146 height: units.gu(6)
147147
148148 ActionTextField {
149− id: __actionTextField
149+ id: actionTextField
150150
151151 anchors.fill: parent
152152 anchors.margins: units.gu(1)
modules/Unity/Indicators/Messaging/qml/SimpleTextMessage.qml+8−8
@@ -25,15 +25,15 @@ import "utils.js" as Utils
2525HeroMessage {
2626 id: __heroMessage
2727
28− property alias footer: __footer.sourceComponent
28+ property alias footer: footerLoader.sourceComponent
2929
30− expandedHeight: __fullMessage.y + __fullMessage.height + units.gu(2)
30+ expandedHeight: fullMessage.y + fullMessage.height + units.gu(2)
3131 heroMessageHeader.titleText.text: menu ? menu.label : ""
3232 heroMessageHeader.subtitleText.text: menu ? Utils.formatDate(menu.extra.canonical_time) : ""
3333 heroMessageHeader.bodyText.text: menu ? menu.extra.canonical_text : ""
3434
3535 Item {
36− id: __fullMessage
36+ id: fullMessage
3737
3838 anchors {
3939 left: parent.left
@@ -47,7 +47,7 @@ HeroMessage {
4747 enabled: false
4848
4949 Label {
50− id: __bodyText
50+ id: bodyText
5151 anchors {
5252 top: parent.top
5353 left: parent.left
@@ -61,15 +61,15 @@ HeroMessage {
6161 }
6262
6363 Loader {
64− id: __footer
64+ id: footerLoader
6565
6666 anchors {
67− top: __bodyText.bottom
67+ top: bodyText.bottom
6868 topMargin: units.gu(2)
6969 left: parent.left
7070 right: parent.right
7171 }
72− height: __footer.item != undefined ? units.gu(4) : 0
72+ height: item != undefined ? units.gu(4) : 0
7373 }
7474
7575 states: State {
@@ -82,7 +82,7 @@ HeroMessage {
8282 }
8383
8484 PropertyChanges {
85− target: __fullMessage
85+ target: fullMessage
8686 opacity: 1.0
8787 enabled: true
8888 }
modules/Unity/Indicators/Messaging/qml/SnapDecision.qml+15−15
@@ -24,9 +24,9 @@ import Unity.Indicators 0.1 as Indicators
2424import "utils.js" as Utils
2525
2626HeroMessage {
27− id: __snapDecision
27+ id: snapDecision
2828
29− expandedHeight: __buttons.y + __buttons.height + __quickreply.height + units.gu(2)
29+ expandedHeight: buttons.y + buttons.height + quickreply.height + units.gu(2)
3030 heroMessageHeader.titleText.text: menu ? menu.label : ""
3131 heroMessageHeader.subtitleText.text: menu ? menu.extra.canonical_text : ""
3232 heroMessageHeader.subtitleText.color: "#e8e1d0"
@@ -34,7 +34,7 @@ HeroMessage {
3434 heroMessageHeader.bodyText.color: "#8f8f88"
3535
3636 Item {
37− id: __buttons
37+ id: buttons
3838
3939 anchors.left: parent.left
4040 anchors.leftMargin: units.gu(2)
@@ -54,16 +54,16 @@ HeroMessage {
5454 width: (parent.width - units.gu(1)) / 2
5555
5656 onClicked: {
57− if (__quickreply.state === "") {
58− __quickreply.state = "expanded";
57+ if (quickreply.state === "") {
58+ quickreply.state = "expanded";
5959 } else {
60− __quickreply.state = "";
60+ quickreply.state = "";
6161 }
6262 }
6363 }
6464
6565 ActionButton {
66− actionGroup: __snapDecision.actionGroup
66+ actionGroup: snapDecision.actionGroup
6767 action: actionsDescription[0].name
6868
6969 text: actionsDescription ? actionsDescription[0].label : "Call back"
@@ -76,10 +76,10 @@ HeroMessage {
7676
7777 states: State {
7878 name: "expanded"
79− when: __snapDecision.state === "expanded"
79+ when: snapDecision.state === "expanded"
8080
8181 PropertyChanges {
82− target: __buttons
82+ target: buttons
8383 opacity: 1.0
8484 }
8585 }
@@ -93,15 +93,15 @@ HeroMessage {
9393 }
9494
9595 QuickReply {
96− id: __quickreply
96+ id: quickreply
9797
98− actionGroup: __snapDecision.actionGroup
98+ actionGroup: snapDecision.actionGroup
9999 action: actionsDescription[1].name
100100
101101 messages: actionsDescription ? actionsDescription[1]["parameter-hint"] : ""
102102 buttonText: actionsDescription ? actionsDescription[1].label : "send"
103103 anchors {
104− top: __buttons.bottom
104+ top: buttons.bottom
105105 topMargin: units.gu(2)
106106 left: parent.left
107107 right: parent.right
@@ -114,13 +114,13 @@ HeroMessage {
114114 name: "expanded"
115115
116116 PropertyChanges {
117− target: __quickreply
117+ target: quickreply
118118 height: expandedHeight
119119 opacity: 1.0
120120 }
121121
122122 PropertyChanges {
123− target: __quickreply
123+ target: quickreply
124124 enabled: true
125125 }
126126 }
@@ -136,7 +136,7 @@ HeroMessage {
136136
137137 onStateChanged: {
138138 if (state === "") {
139− __quickreply.state = "";
139+ quickreply.state = "";
140140 }
141141 }
142142}
modules/Unity/Indicators/Messaging/qml/TextMessage.qml+2−2
@@ -23,11 +23,11 @@ import Ubuntu.Components 0.1
2323import Unity.Indicators 0.1 as Indicators
2424
2525SimpleTextMessage {
26− id: __simpleMessage
26+ id: simpleMessage
2727
2828 footer: ActionTextField {
2929 anchors.fill: parent
30− actionGroup: __simpleMessage.actionGroup
30+ actionGroup: simpleMessage.actionGroup
3131 action: actionsDescription[0].name
3232
3333 buttonText: actionsDescription ? actionsDescription[0].label : "Send"
modules/Unity/Indicators/Network/qml/AccessPoint.qml+2−2
@@ -23,7 +23,7 @@ import Ubuntu.Components.ListItems 0.1 as ListItem
2323import Unity.Indicators 0.1 as Indicators
2424
2525Indicators.MenuItem {
26− id: _accessPoint
26+ id: accessPoint
2727 property variant actionWifiApStrength : menu && actionGroup ? actionGroup.action(menu.extra.canonical_wifi_ap_strength_action) : null
2828 property variant wifiApStrength : actionWifiApStrength && actionWifiApStrength.valid ? actionWifiApStrength.state : "0"
2929
@@ -60,7 +60,7 @@ Indicators.MenuItem {
6060 }
6161
6262 Indicators.MenuActionBinding {
63− actionGroup: _accessPoint.actionGroup
63+ actionGroup: accessPoint.actionGroup
6464 action: menu ? menu.action : ""
6565 target: checkBoxActive
6666 property: "checked"
modules/Unity/Indicators/Network/qml/WifiSection.qml+2−2
@@ -22,11 +22,11 @@ import Ubuntu.Components 0.1
2222import Unity.Indicators 0.1 as Indicators
2323
2424Indicators.SectionMenuItem {
25− id: __wifiSectionMenu
25+ id: wifiSectionMenu
2626
2727 Indicators.MenuAction {
2828 id: busyAction
29− actionGroup: __wifiSectionMenu.actionGroup
29+ actionGroup: wifiSectionMenu.actionGroup
3030 action: menu ? menu.extra.canonical_busy_action : ""
3131 }
3232
modules/Unity/Indicators/qml/BasicMenuItem.qml+4−4
@@ -21,12 +21,12 @@ import QtQuick 2.0
2121import Ubuntu.Components.ListItems 0.1 as ListItem
2222
2323ListItem.Standard {
24− id: _priv
24+ id: stdListItem
2525
2626 property bool menuActivated: false
2727 property QtObject menu
2828 property QtObject actionGroup
29− property alias color: __bg.color
29+ property alias color: background.color
3030
3131 signal activateMenu()
3232 signal deactivateMenu()
@@ -35,11 +35,11 @@ ListItem.Standard {
3535 __foregroundColor: "#e8e1d0"
3636
3737 backgroundIndicator: RemoveBackground {
38− state: _priv.swipingState
38+ state: stdListItem.swipingState
3939 }
4040
4141 Rectangle {
42− id: __bg
42+ id: background
4343
4444 anchors.fill: parent
4545 color: "#221e1c"
modules/Unity/Indicators/qml/ButtonMenuItem.qml+2−2
@@ -21,7 +21,7 @@ import QtQuick 2.0
2121import Ubuntu.Components 0.1
2222
2323BasicMenuItem {
24− id: _buttonMenu
24+ id: buttonMenu
2525 color: "#221e1b"
2626 implicitHeight: units.gu(7)
2727
@@ -41,7 +41,7 @@ BasicMenuItem {
4141
4242 MenuAction {
4343 id: menuAction
44− actionGroup: _buttonMenu.actionGroup
44+ actionGroup: buttonMenu.actionGroup
4545 action: menu ? menu.action : ""
4646 }
4747}
modules/Unity/Indicators/qml/MenuItem.qml−1
@@ -22,7 +22,6 @@ import Ubuntu.Components 0.1
2222import Ubuntu.Components.ListItems 0.1 as ListItem
2323
2424BasicMenuItem {
25− id: __menu
2625 objectName: menu ? menu.action : ""
2726 progression: menu && (menu.linkSubMenu !== undefined)
2827 text: menu && menu.label ? menu.label : ""
modules/Unity/Indicators/qml/MenuItemFactory.qml+10−10
@@ -23,15 +23,15 @@ import Unity.Indicators.Messaging 0.1 as ICMessaging
2323import Unity.Indicators.Network 0.1 as ICNetwork
2424
2525Item {
26− id: __menuFactory
26+ id: menuFactory
2727
2828 property QtObject menu
2929 property QtObject listView
3030 property QtObject actionGroup
3131 property bool isCurrentItem
32− readonly property bool empty: (__loader.item !== undefined && __loader.status == Loader.Ready) ? __loader.item.state === "EMPTY" : true
32+ readonly property bool empty: (loader.item !== undefined && loader.status == Loader.Ready) ? loader.item.state === "EMPTY" : true
3333
34− implicitHeight: __loader.height
34+ implicitHeight: loader.height
3535
3636 signal activated()
3737 signal deactivated()
@@ -70,7 +70,7 @@ Item {
7070 Component { id: indicatorMenu; Indicators.MenuItem {} }
7171
7272 Loader {
73− id: __loader
73+ id: loader
7474 asynchronous: true
7575
7676 anchors {
@@ -79,11 +79,11 @@ Item {
7979 }
8080
8181 sourceComponent: {
82− if (!__menuFactory.menu || !__menuFactory.menu.extra) {
82+ if (!menuFactory.menu || !menuFactory.menu.extra) {
8383 return undefined;
8484 }
8585
86− var widgetType = __menuFactory.menu.extra.canonical_type;
86+ var widgetType = menuFactory.menu.extra.canonical_type;
8787 if (widgetType) {
8888 return _map[widgetType];
8989 } else {
@@ -100,11 +100,11 @@ Item {
100100
101101 onLoaded: {
102102 item.menuActivated = Qt.binding(function() { return isCurrentItem; });
103− item.actionGroup = Qt.binding(function() { return __menuFactory.actionGroup; });
104− item.menu = Qt.binding(function() { return __menuFactory.menu; });
103+ item.actionGroup = Qt.binding(function() { return menuFactory.actionGroup; });
104+ item.menu = Qt.binding(function() { return menuFactory.menu; });
105105
106− item.activateMenu.connect(function() { __menuFactory.activated(); });
107− item.deactivateMenu.connect(function() { __menuFactory.deactivated(); });
106+ item.activateMenu.connect(function() { menuFactory.activated(); });
107+ item.deactivateMenu.connect(function() { menuFactory.deactivated(); });
108108 }
109109 }
110110}
modules/Unity/Indicators/qml/ProgressMenuItem.qml+3−3
@@ -21,7 +21,7 @@ import QtQuick 2.0
2121import Ubuntu.Components 0.1
2222
2323MenuItem {
24− id: _progressMenu
24+ id: progressMenu
2525 property alias value : progressBar.value
2626
2727 // TODO: Replace this with the official ProgressBar component as soon as
@@ -36,7 +36,7 @@ MenuItem {
3636 }
3737 height: units.gu(4)
3838 anchors.verticalCenter: parent.verticalCenter
39− color: "#00000000"
39+ color: "transparent"
4040
4141 property int minimumValue: 0
4242 property int maximumValue: 100
@@ -57,7 +57,7 @@ MenuItem {
5757 }
5858
5959 MenuActionBinding {
60− actionGroup: _progressMenu.actionGroup
60+ actionGroup: progressMenu.actionGroup
6161 action: menu ? menu.action : ""
6262 target: progressBar
6363 property: "value"
modules/Unity/Indicators/qml/RemoveBackground.qml+5−9
@@ -18,14 +18,10 @@ import QtQuick 2.0
1818import Ubuntu.Components 0.1
1919
2020Rectangle {
21− id: __backgroundItem
22−
2321 anchors.fill: parent
2422 color: "#333130"
2523 Label {
26− id: __backgroundText
27−
28− property int slidingMargin: units.gu(3)
24+ id: backgroundText
2925
3026 anchors.fill: parent
3127 verticalAlignment: Text.AlignVCenter
@@ -39,8 +35,8 @@ Rectangle {
3935 State {
4036 name: "SwipingRight"
4137 PropertyChanges {
42− target: __backgroundText
43− anchors.rightMargin: __backgroundText.slidingMargin
38+ target: backgroundText
39+ anchors.rightMargin: units.gu(3)
4440 anchors.leftMargin: 0
4541 horizontalAlignment: Text.AlignRight
4642
@@ -49,9 +45,9 @@ Rectangle {
4945 State {
5046 name: "SwipingLeft"
5147 PropertyChanges {
52− target: __backgroundText
48+ target: backgroundText
5349 anchors.rightMargin: 0
54− anchors.leftMargin: __backgroundText.slidingMargin
50+ anchors.leftMargin: units.gu(3)
5551 horizontalAlignment: Text.AlignLeft
5652 }
5753 }
modules/Unity/Indicators/qml/SectionMenuItem.qml−6
@@ -22,17 +22,11 @@ import Ubuntu.Components 0.1
2222import Ubuntu.Components.ListItems 0.1 as ListItem
2323
2424BasicMenuItem {
25− id: __sectionMenu
26−
2725 property string label: menu && menu.label ? menu.label : ""
2826 property bool busy: false
2927 property int count: menu && menu.linkSection ? menu.linkSection.count : 0
3028
3129 color: "#221e1b"
32− anchors {
33− left: parent ? parent.left : undefined
34− right: parent ? parent.right : undefined
35− }
3630 implicitHeight: label !== "" ? __header.height : 0
3731 state: count === 0 ? "EMPTY" : ""
3832
modules/Unity/Indicators/qml/SwitchMenuItem.qml+2−2
@@ -21,7 +21,7 @@ import QtQuick 2.0
2121import Ubuntu.Components 0.1
2222
2323MenuItem {
24− id: _switchMenu
24+ id: switchMenu
2525
2626 property alias checked: switcher.checked
2727
@@ -35,7 +35,7 @@ MenuItem {
3535
3636 MenuActionBinding {
3737 id: menuAction
38− actionGroup: _switchMenu.actionGroup
38+ actionGroup: switchMenu.actionGroup
3939 action: menu ? menu.action : ""
4040 target: switcher
4141 property: "checked"
modules/Unity/Indicators/qml/TextMenuItem.qml+8−8
@@ -21,10 +21,10 @@ import QtQuick 2.0
2121import Ubuntu.Components 0.1
2222
2323MenuItem {
24− id: _textMenu
24+ id: textMenu
2525
26− property alias text: _textField.text
27− property alias password: _showPassword.visible
26+ property alias text: textField.text
27+ property alias password: showPassword.visible
2828
2929 implicitHeight: password ? units.gu(10) : units.gu(7)
3030
@@ -39,7 +39,7 @@ MenuItem {
3939 }
4040
4141 TextField {
42− id: _textField
42+ id: textField
4343
4444 anchors {
4545 left: parent.left
@@ -47,11 +47,11 @@ MenuItem {
4747 }
4848
4949 placeholderText: "Password"
50− echoMode: _textMenu.password && !_checkBox.checked ? TextInput.Password : TextInput.Normal
50+ echoMode: textMenu.password && !_checkBox.checked ? TextInput.Password : TextInput.Normal
5151 }
5252
5353 Row {
54− id: _showPassword
54+ id: showPassword
5555
5656 visible: false
5757 anchors {
@@ -74,9 +74,9 @@ MenuItem {
7474 }
7575
7676 MenuActionBinding {
77− actionGroup: _textMenu.actionGroup
77+ actionGroup: textMenu.actionGroup
7878 action: menu ? menu.action : ""
79− target: _textField
79+ target: textField
8080 property: "text"
8181 }
8282}