on xenial help sign in
Fix previews being requested when calling activate
a211228Albert Astals
qml/Dash/GenericScopeView.qml+7−7
@@ -191,16 +191,16 @@ FocusScope {
191 Connections {
191 Connections {
192 target: rendererLoader.item
192 target: rendererLoader.item
193 onClicked: {
193 onClicked: {
194− // Prepare the preview in case activate() triggers a preview only
195− previewListView.model = target.model;
196− previewListView.currentIndex = -1
197− previewListView.currentIndex = index;
198−
199− var item = target.model.get(index);
200−
201 if (scopeView.scope.id === "scopes" || (scopeView.scope.id == "clickscope" && categoryId == "local")) {
194 if (scopeView.scope.id === "scopes" || (scopeView.scope.id == "clickscope" && categoryId == "local")) {
195+ // TODO Techincally it is possible that calling activate() will make the scope emit
196+ // previewRequested so that we show a preview but there's no scope that does that yet
197+ // so it's not implemented
198+ var item = target.model.get(index);
202 scopeView.scope.activate(item.result)
199 scopeView.scope.activate(item.result)
203 } else {
200 } else {
201+ previewListView.model = target.model;
202+ previewListView.currentIndex = -1
203+ previewListView.currentIndex = index;
204 previewListView.open = true
204 previewListView.open = true
205 }
205 }
206 }
206 }