git.iko.soy/unity8
on xenial help sign in
Don't check for sound-playback if check is not intended.
b5fc9dbMirco Müller
tests/qmltests/Notifications/tst_Notifications.qml+4−2
compare with xenial
unifiedsplit
@@ -602,8 +602,10 @@ Item {
602 compare(bodyLabel.visible, data.bodyVisible, "body-text visibility is incorrect")
602 compare(bodyLabel.visible, data.bodyVisible, "body-text visibility is incorrect")
603 compare(buttonRow.visible, data.buttonRowVisible, "button visibility is incorrect")
603 compare(buttonRow.visible, data.buttonRowVisible, "button visibility is incorrect")
604
604
605+ if (data.hasSound) {
605− var audioItem = findInvisibleChild(notification, "sound")
606+ var audioItem = findInvisibleChild(notification, "sound")
606− compare(audioItem.playbackState, data.hasSound ? Audio.PlayingState : Audio.StoppedState, "Audio has wrong state")
607+ compare(audioItem.playbackState, data.hasSound ? Audio.PlayingState : Audio.StoppedState, "Audio has wrong state")
608+ }
607
609
608 if(data.buttonRowVisible) {
610 if(data.buttonRowVisible) {
609 var buttonCancel = findChild(buttonRow, "notify_button1")
611 var buttonCancel = findChild(buttonRow, "notify_button1")
tests/qmltests/Notifications/tst_OptionToggle.qml+4−2
@@ -238,8 +238,10 @@ Row {
238 compare(bodyLabel.visible, data.bodyVisible, "body-text visibility is incorrect")
238 compare(bodyLabel.visible, data.bodyVisible, "body-text visibility is incorrect")
239 compare(buttonRow.visible, data.buttonRowVisible, "button visibility is incorrect")
239 compare(buttonRow.visible, data.buttonRowVisible, "button visibility is incorrect")
240
240
241+ if (data.hasSound) {
241− var audioItem = findInvisibleChild(notification, "sound")
242+ var audioItem = findInvisibleChild(notification, "sound")
242− compare(audioItem.playbackState, data.hasSound ? Audio.PlayingState : Audio.StoppedState, "Audio has wrong state")
243+ compare(audioItem.playbackState, data.hasSound ? Audio.PlayingState : Audio.StoppedState, "Audio has wrong state")
244+ }
243
245
244 if(data.buttonRowVisible) {
246 if(data.buttonRowVisible) {
245 var buttonCancel = findChild(buttonRow, "notify_button1")
247 var buttonCancel = findChild(buttonRow, "notify_button1")