b9bc8a3 · unity8 · git.iko.soy

debian/changelog+36

@@ -1,3 +1,39 @@

1+unity8 (7.84+14.04.20140314-0ubuntu1) trusty; urgency=low

2+

3+ [ Michał Sawicz ]

4+ * Fix tests under Qt 5.2.

5+ * CardHeader improvements depending on background. Also drop prices,

6+ they need to be reworked into attributes.

7+ * Bring Cards closer to design

8+ * Add back the workaround for not being able scroll the image gallery

9+ Taken from AppPreview.qml (LP: #1281709)

10+ * Only allow searching when preview isn't open. (LP: #1282475)

11+ * Adds carousel dynamic switch

12+

13+ [ Leo Arias ]

14+ * Update the url dispatcher test to use the fake app fixture from the

15+ toolkit.

16+

17+ [ Albert Astals ]

18+ * Fix tests under Qt 5.2.

19+ * Workaround compiz/unity7 behaviour change/bug

20+

21+ [ Michael Zanetti ]

22+ * Fix tests under Qt 5.2.

23+ * Disable HUD from the bottom edge.

24+

25+ [ Andrea Cimitan ]

26+ * Adds carousel dynamic switch

27+

28+ [ CI bot ]

29+ * Resync trunk

30+

31+ [ Michał Karnicki ]

32+ * CardHeader improvements depending on background. Also drop prices,

33+ they need to be reworked into attributes.

34+

35+ -- Ubuntu daily release <ps-jenkins@lists.canonical.com> Fri, 14 Mar 2014 15:46:10 +0000

36+

137unity8 (7.84+14.04.20140307-0ubuntu1) trusty; urgency=low

238

339 * New rebuild forced

plugins/DashViews/listviewwithpageheader.cpp+33−10

@@ -91,6 +91,7 @@

9191

9292#include "listviewwithpageheader.h"

9393

94+#include <QCoreApplication>

9495#include <QDebug>

9596#include <qqmlinfo.h>

9697#include <qqmlengine.h>

@@ -477,6 +478,11 @@ void ListViewWithPageHeader::componentComplete()

477478 polish();

478479}

479480

481+static inline bool uFuzzyCompare(qreal r1, qreal r2)

482+{

483+ return qFuzzyCompare(r1, r2) || (qFuzzyIsNull(r1) && qFuzzyIsNull(r2));

484+}

485+

480486void ListViewWithPageHeader::viewportMoved(Qt::Orientations orient)

481487{

482488 // Check we are not being taken down and don't paint anything

@@ -491,11 +497,7 @@ void ListViewWithPageHeader::viewportMoved(Qt::Orientations orient)

491497 const bool showHeaderAnimationRunning = m_contentYAnimation->isRunning() && contentYAnimationType == ContentYAnimationShowHeader;

492498 if (m_headerItem) {

493499 const auto oldHeaderItemShownHeight = m_headerItemShownHeight;

494− if (contentY() < -m_minYExtent) {

495− // Stick the header item to the top when dragging down

496− m_headerItem->setY(contentY());

497− m_headerItem->setHeight(m_headerItem->implicitHeight() + (-m_minYExtent - contentY()));

498− } else {

500+ if (uFuzzyCompare(contentY(), -m_minYExtent) || contentY() > -m_minYExtent) {

499501 m_headerItem->setHeight(m_headerItem->implicitHeight());

500502 // We are going down (but it's not because of the rebound at the end)

501503 // (but the header was not shown by it's own position)

@@ -509,21 +511,32 @@ void ListViewWithPageHeader::viewportMoved(Qt::Orientations orient)

509511 m_headerItemShownHeight = 0;

510512 m_headerItem->setY(-m_minYExtent);

511513 } else if ((scrolledUp && notRebounding && notShownByItsOwn && !maximizeVisibleAreaRunning) || (m_headerItemShownHeight > 0) || m_inContentHeightKeepHeaderShown) {

512− if (maximizeVisibleAreaRunning && diff > 0) // If we are maximizing and the header was shown, make sure we hide it

514+ if (maximizeVisibleAreaRunning && diff > 0) {

515+ // If we are maximizing and the header was shown, make sure we hide it

513516 m_headerItemShownHeight -= diff;

514− else

517+ } else {

515518 m_headerItemShownHeight += diff;

516− if (contentY() == -m_minYExtent) {

519+ }

520+ if (uFuzzyCompare(contentY(), -m_minYExtent)) {

517521 m_headerItemShownHeight = 0;

518522 } else {

519523 m_headerItemShownHeight = qBound(static_cast<qreal>(0.), m_headerItemShownHeight, m_headerItem->height());

520524 }

521525 if (m_headerItemShownHeight > 0) {

522− m_headerItem->setY(contentY() - m_headerItem->height() + m_headerItemShownHeight);

526+ if (uFuzzyCompare(m_headerItem->height(), m_headerItemShownHeight)) {

527+ m_headerItem->setY(contentY());

528+ m_headerItemShownHeight = m_headerItem->height();

529+ } else {

530+ m_headerItem->setY(contentY() - m_headerItem->height() + m_headerItemShownHeight);

531+ }

523532 } else {

524533 m_headerItem->setY(-m_minYExtent);

525534 }

526535 }

536+ } else {

537+ // Stick the header item to the top when dragging down

538+ m_headerItem->setY(contentY());

539+ m_headerItem->setHeight(m_headerItem->implicitHeight() + (-m_minYExtent - contentY()));

527540 }

528541 // We will be changing the clip item, need to accomadate for it

529542 // otherwise we move the firstItem down/up twice (unless the

@@ -1128,7 +1141,12 @@ void ListViewWithPageHeader::adjustMinYExtent()

11281141 nonCreatedHeight = m_firstVisibleIndex * visibleItemsHeight / visibleItems;

11291142// qDebug() << m_firstVisibleIndex << visibleItemsHeight << visibleItems << nonCreatedHeight;

11301143 }

1131− m_minYExtent = nonCreatedHeight - m_visibleItems.first()->y() - m_clipItem->y() + (m_headerItem ? m_headerItem->implicitHeight() : 0);

1144+ const qreal headerHeight = (m_headerItem ? m_headerItem->implicitHeight() : 0);

1145+ m_minYExtent = nonCreatedHeight - m_visibleItems.first()->y() - m_clipItem->y() + headerHeight;

1146+ if (m_minYExtent != 0 && qFuzzyIsNull(m_minYExtent)) {

1147+ m_minYExtent = 0;

1148+ m_visibleItems.first()->setY(nonCreatedHeight - m_clipItem->y() + headerHeight);

1149+ }

11321150 }

11331151}

11341152

@@ -1264,6 +1282,11 @@ void ListViewWithPageHeader::updatePolish()

12641282 refill();

12651283

12661284 if (m_contentHeightDirty) {

1285+ // We need to make sure all bindings have updated otherwise

1286+ // we may end up with bindings updating when we call setContentHeight

1287+ // and then everything gets out of sync, i.e. testHeaderPositionBug1240118

1288+ QCoreApplication::instance()->processEvents();

1289+

12671290 qreal contentHeight;

12681291 if (m_visibleItems.isEmpty()) {

12691292 contentHeight = m_headerItem ? m_headerItem->height() : 0;

plugins/Utils/CMakeLists.txt−1

@@ -12,7 +12,6 @@ include_directories(

1212

1313set(QMLPLUGIN_SRC

1414 albumartprovider.cpp

15− bottombarvisibilitycommunicatorshell.cpp

1615 mediaartcache.cpp

1716 qlimitproxymodelqml.cpp

1817 qsortfilterproxymodelqml.cpp

plugins/Utils/bottombarvisibilitycommunicatorshell.cppdeleted−49

@@ -1,49 +0,0 @@

1−/*

3− *

4− * This program is free software; you can redistribute it and/or modify

5− * it under the terms of the GNU General Public License as published by

6− * the Free Software Foundation; version 3.

7− *

8− * This program is distributed in the hope that it will be useful,

9− * but WITHOUT ANY WARRANTY; without even the implied warranty of

10− * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

11− * GNU General Public License for more details.

12− *

13− * You should have received a copy of the GNU General Public License

14− * along with this program. If not, see <http://www.gnu.org/licenses/>.

15− */

16−

17−#include "bottombarvisibilitycommunicatorshell.h"

18−

19−BottomBarVisibilityCommunicatorShell::BottomBarVisibilityCommunicatorShell()

20− : m_forceHidden(false),

21− m_position(0)

22−{

23−}

24−

25−bool BottomBarVisibilityCommunicatorShell::forceHidden() const

26−{

27− return m_forceHidden;

28−}

29−

30−double BottomBarVisibilityCommunicatorShell::position() const

31−{

32− return m_position;

33−}

34−

35−void BottomBarVisibilityCommunicatorShell::setForceHidden(bool forceHidden)

36−{

37− if (forceHidden != m_forceHidden) {

38− m_forceHidden = forceHidden;

39− Q_EMIT forceHiddenChanged(forceHidden);

40− }

41−}

42−

43−void BottomBarVisibilityCommunicatorShell::setPosition(double position)

44−{

45− if (position != m_position) {

46− m_position = position;

47− Q_EMIT positionChanged(position);

48− }

49−}

plugins/Utils/bottombarvisibilitycommunicatorshell.hdeleted−59

@@ -1,59 +0,0 @@

1−/*

3− *

4− * This program is free software; you can redistribute it and/or modify

5− * it under the terms of the GNU General Public License as published by

6− * the Free Software Foundation; version 3.

7− *

8− * This program is distributed in the hope that it will be useful,

9− * but WITHOUT ANY WARRANTY; without even the implied warranty of

10− * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

11− * GNU General Public License for more details.

12− *

13− * You should have received a copy of the GNU General Public License

14− * along with this program. If not, see <http://www.gnu.org/licenses/>.

15− */

16−

17−#ifndef BOTTOMBARVISIBILITYCOMMUNICATORSHELL_H

18−#define BOTTOMBARVISIBILITYCOMMUNICATORSHELL_H

19−

20−#include <QObject>

21−

22−class QDBusInterface;

23−

24−/** This is an internal class used to talk with the bottom bar used by either

25− * applications or the SDK.

26− * There is a method to force the bottom bar to be hidden or otherwise behave as usual

27− */

28−

29−class BottomBarVisibilityCommunicatorShell : public QObject

30−{

31− Q_OBJECT

32− Q_PROPERTY(bool forceHidden READ forceHidden WRITE setForceHidden NOTIFY forceHiddenChanged)

33− Q_PROPERTY(double position READ position WRITE setPosition NOTIFY positionChanged)

34−

35− Q_CLASSINFO("D-Bus Interface", "com.canonical.Shell.BottomBarVisibilityCommunicator")

36−public:

37− static BottomBarVisibilityCommunicatorShell& instance() {

38− static BottomBarVisibilityCommunicatorShell instance;

39− return instance;

40− }

41−

42− bool forceHidden() const;

43− void setForceHidden(bool forceHidden);

44−

45− double position() const;

46− void setPosition(double position);

47−

48−Q_SIGNALS:

49− void forceHiddenChanged(bool forceHidden);

50− void positionChanged(double position);

51−

52−private:

53− BottomBarVisibilityCommunicatorShell();

54−

55− bool m_forceHidden;

56− double m_position;

57−};

58−

59−#endif

plugins/Utils/plugin.cpp−10

@@ -27,15 +27,11 @@

2727

2828// local

2929#include "albumartprovider.h"

30−#include "bottombarvisibilitycommunicatorshell.h"

3130#include "qlimitproxymodelqml.h"

3231#include "qsortfilterproxymodelqml.h"

3332#include "timeformatter.h"

3433#include "unitymenumodelpaths.h"

3534

36−static const char* BOTTOM_BAR_VISIBILITY_COMMUNICATOR_DBUS_PATH = "/BottomBarVisibilityCommunicator";

37−static const char* DBUS_SERVICE = "com.canonical.Shell.BottomBarVisibilityCommunicator";

38−

3935void UtilsPlugin::registerTypes(const char *uri)

4036{

4137 Q_ASSERT(uri == QLatin1String("Utils"));

@@ -45,7 +41,6 @@ void UtilsPlugin::registerTypes(const char *uri)

4541 qmlRegisterType<UnityMenuModelPaths>(uri, 0, 1, "UnityMenuModelPaths");

4642 qmlRegisterType<TimeFormatter>(uri, 0, 1, "TimeFormatter");

4743 qmlRegisterType<GDateTimeFormatter>(uri, 0, 1, "GDateTimeFormatter");

48− qmlRegisterUncreatableType<BottomBarVisibilityCommunicatorShell>(uri, 0, 1, "BottomBarVisibilityCommunicatorShell", "Can't create BottomBarVisibilityCommunicatorShell");

4944}

5045

5146void UtilsPlugin::initializeEngine(QQmlEngine *engine, const char *uri)

@@ -64,9 +59,4 @@ void UtilsPlugin::initializeEngine(QQmlEngine *engine, const char *uri)

6459 {

6560 qWarning() << "Failed to register image provider for albumart (unknown error)";

6661 }

67−

68− QDBusConnection::sessionBus().registerService(DBUS_SERVICE);

69− BottomBarVisibilityCommunicatorShell *bottomBarVisibilityCommunicator = &BottomBarVisibilityCommunicatorShell::instance();

70− QDBusConnection::sessionBus().registerObject(BOTTOM_BAR_VISIBILITY_COMMUNICATOR_DBUS_PATH, bottomBarVisibilityCommunicator, QDBusConnection::ExportAllContents);

71− engine->rootContext()->setContextProperty("bottomBarVisibilityCommunicatorShell", bottomBarVisibilityCommunicator);

7262}

qml/Components/Stage.qml+4−6

@@ -329,13 +329,11 @@ Showable {

329329

330330 ScriptAction {

331331 script: {

332− if (!stage.focusedApplicationWhenUsingScreenshots) {

333− // FIXME: only here to support case where application does

334− // not exist yet but is about to

335− return;

332+ // FIXME: only here to support case where application does

333+ // not exist yet but is about to

334+ if (stage.focusedApplicationWhenUsingScreenshots) {

335+ stage.__focusApplication(stage.focusedApplicationWhenUsingScreenshots);

336336 }

337−

338− stage.__focusApplication(stage.focusedApplicationWhenUsingScreenshots);

339337 }

340338 }

341339 }

qml/Dash/Card.qml+7

@@ -44,6 +44,8 @@ Item {

4444 anchors.fill: parent

4545 image: backgroundImage.source ? backgroundImage : null

4646

47+ property real luminance: 0.2126 * color.r + 0.7152 * color.g + 0.0722 * color.b

48+

4749 property Image backgroundImage: Image {

4850 objectName: "backgroundImage"

4951 source: {

@@ -163,6 +165,9 @@ Item {

163165 titleWeight: components && components["subtitle"] ? Font.DemiBold : Font.Normal

164166

165167 opacity: showHeader ? 1 : 0

168+ inOverlay: template["overlay"] === true

169+ fontColor: inOverlay ? "white" : summary.color

170+ useMascotShape: !background.visible && !inOverlay

166171

167172 Behavior on opacity { NumberAnimation { duration: UbuntuAnimation.SnapDuration } }

168173 }

@@ -183,5 +188,7 @@ Item {

183188 text: cardData && cardData["summary"] || ""

184189 height: text ? implicitHeight : 0

185190 fontSize: "small"

191+ // TODO karni: Change "grey" to Ubuntu.Components.Palette color once updated.

192+ color: background.visible && background.luminance < 0.7 ? "white" : "grey"

186193 }

187194}

qml/Dash/CardHeader.qml+31−59

@@ -22,18 +22,20 @@ Item {

2222 property alias mascot: mascotImage.source

2323 property alias title: titleLabel.text

2424 property alias subtitle: subtitleLabel.text

25− property alias price: priceLabel.text

26− property alias oldPrice: oldPriceLabel.text

27− property alias altPrice: altPriceLabel.text

2825

2926 property alias titleWeight: titleLabel.font.weight

27+ property alias titleSize: titleLabel.fontSize

3028

3129 // FIXME: Saviq, used to scale fonts down in Carousel

3230 property real fontScale: 1.0

3331

3432 property alias headerAlignment: titleLabel.horizontalAlignment

3533

36− visible: mascotImage.status === Image.Ready || title || price

34+ property bool inOverlay: false

35+ property bool useMascotShape: true

36+ property color fontColor: Theme.palette.selected.backgroundText

37+

38+ visible: mascotImage.status === Image.Ready || title

3739 height: row.height > 0 ? row.height + row.margins * 2 : 0

3840

3941 Row {

@@ -42,13 +44,13 @@ Item {

4244

4345 property real margins: units.gu(1)

4446

47+ spacing: mascotShape.visible || mascotImage.visible || inOverlay ? margins : 0

4548 anchors {

4649 top: parent.top; left: parent.left; right: parent.right

4750 margins: margins

4851 leftMargin: spacing

4952 rightMargin: spacing

5053 }

51− spacing: mascotShape.visible || (template && template["overlay"]) ? margins : 0

5254

5355 UbuntuShape {

5456 id: mascotShape

@@ -57,35 +59,45 @@ Item {

5759 // TODO karni: Icon aspect-ratio is 8:7.5. Revisit these values to avoid fraction of pixels.

5860 width: units.gu(6)

5961 height: units.gu(5.625)

60− visible: image.status === Image.Ready

62+ anchors.verticalCenter: parent.verticalCenter

63+ visible: useMascotShape && image && image.status === Image.Ready

6164 readonly property int maxSize: Math.max(width, height)

6265

63− image: Image {

64− id: mascotImage

66+ image: useMascotShape ? mascotImage : null

67+ }

6568

66− sourceSize { width: mascotShape.maxSize; height: mascotShape.maxSize }

67− fillMode: Image.PreserveAspectCrop

68− horizontalAlignment: Image.AlignHCenter

69− verticalAlignment: Image.AlignVCenter

70− }

69+ Image {

70+ id: mascotImage

71+ objectName: "mascotImage"

72+

73+ width: source ? mascotShape.width : 0

74+ height: mascotShape.height

75+ anchors.verticalCenter: parent.verticalCenter

76+ visible: !useMascotShape && status === Image.Ready

77+

78+ sourceSize { width: mascotShape.maxSize; height: mascotShape.maxSize }

79+ fillMode: Image.PreserveAspectCrop

80+ horizontalAlignment: Image.AlignHCenter

81+ verticalAlignment: Image.AlignVCenter

7182 }

7283

7384 Column {

7485 objectName: "column"

7586 width: parent.width - x

76− spacing: units.gu(0.5)

87+ spacing: units.gu(0.25)

88+ anchors.verticalCenter: parent.verticalCenter

7789

7890 Label {

7991 id: titleLabel

8092 objectName: "titleLabel"

8193 anchors { left: parent.left; right: parent.right }

8294 elide: Text.ElideRight

83− font.weight: Font.DemiBold

95+ font.weight: Font.Normal

96+ fontSize: "small"

8497 wrapMode: Text.Wrap

8598 maximumLineCount: 2

86− fontSize: "small"

8799 font.pixelSize: Math.round(FontUtils.sizeToPixels(fontSize) * fontScale)

88− color: template["overlay"] === true ? "white" : Theme.palette.selected.backgroundText

100+ color: fontColor

89101 }

90102

91103 Label {

@@ -93,51 +105,11 @@ Item {

93105 objectName: "subtitleLabel"

94106 anchors { left: parent.left; right: parent.right }

95107 elide: Text.ElideRight

108+ fontSize: "small"

96109 font.weight: Font.Light

97110 visible: titleLabel.text && text

98− fontSize: "x-small"

99111 font.pixelSize: Math.round(FontUtils.sizeToPixels(fontSize) * fontScale)

100− color: template["overlay"] === true ? "white" : Theme.palette.selected.backgroundText

101− }

102−

103− Row {

104− id: prices

105− objectName: "prices"

106− anchors { left: parent.left; right: parent.right }

107−

108− property int labels: {

109− var labels = 1; // price always visible

110− if (oldPriceLabel.text !== "") labels += 1;

111− if (altPriceLabel.text !== "") labels += 1;

112− return labels;

113− }

114− property real labelWidth: width / labels

115−

116− Label {

117− id: priceLabel

118− width: parent.labelWidth

119− elide: Text.ElideRight

120− font.weight: Font.DemiBold

121− color: Theme.palette.selected.foreground

122− visible: text

123− }

124−

125− Label {

126− id: oldPriceLabel

127− objectName: "oldPriceLabel"

128− width: parent.labelWidth

129− elide: Text.ElideRight

130− horizontalAlignment: parent.labels === 3 ? Text.AlignHCenter : Text.AlignRight

131− visible: text

132− }

133−

134− Label {

135− id: altPriceLabel

136− width: parent.labelWidth

137− elide: Text.ElideRight

138− horizontalAlignment: Text.AlignRight

139− visible: text

140− }

112+ color: fontColor

141113 }

142114 }

143115 }

qml/Dash/CardTool.qml+46−8

@@ -28,6 +28,22 @@ import QtQuick 2.0

2828

2929Item {

3030 id: cardTool

31+

32+ /*!

33+ \brief Number of cards.

34+ */

35+ property int count

36+

37+ /*!

38+ \brief Width of the category view.

39+ */

40+ property real viewWidth

41+

42+ /*!

43+ \brief Scaling factor of selected Carousel item.

44+ */

45+ readonly property real carouselSelectedItemScaleFactor: 1.38 // XXX assuming 1.38 carousel scaling factor for cards

46+

3147 /*!

3248 \brief Template supplied for the category.

3349 */

@@ -39,9 +55,15 @@ Item {

3955 property var components

4056

4157 /*!

42− \brief Width of the view, based on which carousel width is calculated.

58+ \brief The category layout for this card tool.

4359 */

44− property var viewWidth

60+ property string categoryLayout: {

61+ var layout = template["category-layout"];

62+

63+ // carousel fallback mode to grid

64+ if (layout === "carousel" && count <= Math.ceil(carouselTool.realPathItemCount)) layout = "grid";

65+ return layout;

66+ }

4567

4668 // FIXME: Saviq

4769 // Only way for the card below to actually be laid out completely.

@@ -56,7 +78,7 @@ Item {

5678 If undefined, should use implicit width of the actual card.

5779 */

5880 readonly property var cardWidth: {

59− switch (template !== undefined && template["category-layout"]) {

81+ switch (categoryLayout) {

6082 case "grid":

6183 case "vertical-journal":

6284 if (template["card-layout"] === "horizontal") return units.gu(38);

@@ -66,10 +88,7 @@ Item {

6688 }

6789 return units.gu(18.5);

6890 case "carousel":

69− if (viewWidth === undefined) return undefined

70− if (viewWidth <= units.gu(40)) return units.gu(18)

71− if (viewWidth >= units.gu(128)) return units.gu(26)

72− return units.gu(18 + Math.round((viewWidth - units.gu(40))/ units.gu(11)))

91+ return carouselTool.minimumTileWidth;

7392 case undefined:

7493 case "organic-grid":

7594 case "journal":

@@ -84,7 +103,7 @@ Item {

84103 If undefined, should use implicit height of the actual card.

85104 */

86105 readonly property var cardHeight: {

87− switch (template !== undefined && template["category-layout"]) {

106+ switch (categoryLayout) {

88107 case "journal":

89108 if (template["card-size"] >= 12 && template["card-size"] <= 38) return units.gu(template["card-size"]);

90109 return units.gu(18.5);

@@ -123,6 +142,25 @@ Item {

123142 return (template["card-layout"] === "horizontal") ? Text.AlignLeft : Text.AlignHCenter;

124143 }

125144

145+ QtObject {

146+ id: carouselTool

147+

148+ property real minimumTileWidth: {

149+ if (cardTool.viewWidth === undefined) return undefined;

150+ if (cardTool.viewWidth <= units.gu(40)) return units.gu(18);

151+ if (cardTool.viewWidth >= units.gu(128)) return units.gu(26);

152+ return units.gu(18 + Math.round((cardTool.viewWidth - units.gu(40)) / units.gu(11)));

153+ }

154+

155+ readonly property real pathItemCount: 4.8457 /// (848 / 175) reference values

156+

157+ property real realPathItemCount: {

158+ var scaledMinimumTileWidth = minimumTileWidth / cardTool.carouselSelectedItemScaleFactor;

159+ var tileWidth = Math.max(cardTool.viewWidth / pathItemCount, scaledMinimumTileWidth);

160+ return Math.min(cardTool.viewWidth / tileWidth, pathItemCount);

161+ }

162+ }

163+

126164 Card {

127165 id: card

128166 objectName: "card"

qml/Dash/Dash.qml+1

@@ -27,6 +27,7 @@ Showable {

2727 visible: shown

2828

2929 property ListModel searchHistory: SearchHistoryModel {}

30+ property bool searchable: !dashContent.previewOpen

3031

3132 property string showScopeOnLoaded: "home.scope"

3233 property real contentScale: 1.0

qml/Dash/DashContent.qml+1

@@ -25,6 +25,7 @@ Item {

2525 property var model: null

2626 property var scopes: null

2727 property alias currentIndex: dashContentList.currentIndex

28+ property alias previewOpen: previewListView.open

2829

2930 property ScopeDelegateMapper scopeMapper : ScopeDelegateMapper {}

3031 property ListModel searchHistory

qml/Dash/Previews/PreviewActions.qml+1−1

@@ -24,7 +24,7 @@ import QtQuick 2.1

2424PreviewWidget {

2525 id: root

2626

27− height: row.height

27+ height: row.height + units.gu(1)

2828

2929 Row {

3030 id: row

qml/Dash/Previews/PreviewHeader.qml+3−1

@@ -34,5 +34,7 @@ PreviewWidget {

3434 title: root.widgetData["title"] || ""

3535 subtitle: root.widgetData["subtitle"] || ""

3636 width: parent.width

37+

38+ titleSize: "large"

3739 }

38−}

40+}

qml/Dash/Previews/PreviewImageGallery.qml+9

@@ -33,6 +33,15 @@ PreviewWidget {

3333 cacheBuffer: width * 3

3434 model: root.widgetData["sources"]

3535

36+ // FIXME: Because of ListViews inside ListViews inside Flickables inside ListViews (and some more)

37+ // we finally reached the point where this ListView doesn't correctly get swipe input any more but

38+ // instead the parent ListView is the one that is swiped. This MouseArea sort of creates a blocking

39+ // layer to make sure this ListView can be swiped, regardless of what's behind it.

40+ MouseArea {

41+ anchors.fill: parent

42+ enabled: parent.contentWidth > parent.width

43+ }

44+

3645 LazyImage {

3746 objectName: "placeholderScreenshot"

3847 anchors {

qml/Dash/Previews/PreviewTextSummary.qml+2−1

@@ -58,7 +58,8 @@ PreviewWidget {

5858 }

5959 height: (!seeMore.visible || seeMore.more) ? contentHeight : contentHeight / lineCount * (maximumCollapsedLineCount - 2)

6060 clip: true

61− fontSize: "medium"

61+ fontSize: "small"

62+ lineHeight: 1.2

6263 color: Theme.palette.selected.backgroundText

6364 opacity: .8

6465 text: widgetData["text"]

qml/Shell.qml+4−50

@@ -28,9 +28,7 @@ import "Dash"

2828import "Greeter"

2929import "Launcher"

3030import "Panel"

31−import "Hud"

3231import "Components"

33−import "Bottombar"

3432import "SideStage"

3533import "Notifications"

3634import Unity.Notifications 1.0 as NotificationBackend

@@ -403,7 +401,7 @@ FocusScope {

403401

404402 readonly property int backgroundTopMargin: -panel.panelHeight

405403

406− hides: [launcher, panel.indicators, hud]

404+ hides: [launcher, panel.indicators]

407405 shown: false

408406 enabled: true

409407 showAnimation: StandardAnimation { property: "opacity"; to: 1 }

@@ -458,7 +456,7 @@ FocusScope {

458456 objectName: "greeter"

459457

460458 available: true

461− hides: [launcher, panel.indicators, hud]

459+ hides: [launcher, panel.indicators]

462460 shown: true

463461

464462 defaultBackground: shell.background

@@ -545,7 +543,7 @@ FocusScope {

545543 InputFilterArea {

546544 anchors.fill: parent

547545 blockInput: !applicationFocused || greeter.shown || lockscreen.shown || launcher.shown

548− || panel.indicators.shown || hud.shown

546+ || panel.indicators.shown

549547 }

550548

551549 Connections {

@@ -594,7 +592,7 @@ FocusScope {

594592 contentEnabled: edgeDemo.panelContentEnabled

595593 }

596594 fullscreenMode: shell.fullscreenMode

597− searchVisible: !greeter.shown && !lockscreen.shown && dash.shown

595+ searchVisible: !greeter.shown && !lockscreen.shown && dash.shown && dash.searchable

598596

599597 InputFilterArea {

600598 anchors {

@@ -607,48 +605,6 @@ FocusScope {

607605 }

608606 }

609607

610− Hud {

611− id: hud

612−

613− width: parent.width > units.gu(60) ? units.gu(40) : parent.width

614− height: parent.height

615−

616− available: !greeter.shown && !panel.indicators.shown && !lockscreen.shown && edgeDemo.dashEnabled

617− shown: false

618− showAnimation: StandardAnimation { property: "y"; duration: hud.showableAnimationDuration; to: 0; easing.type: Easing.Linear }

619− hideAnimation: StandardAnimation { property: "y"; duration: hud.showableAnimationDuration; to: hudRevealer.closedValue; easing.type: Easing.Linear }

620−

621− Connections {

622− target: shell.applicationManager

623− onMainStageFocusedApplicationChanged: hud.hide()

624− onSideStageFocusedApplicationChanged: hud.hide()

625− }

626− }

627−

628− Revealer {

629− id: hudRevealer

630−

631− enabled: hud.shown

632− width: hud.width

633− anchors.left: hud.left

634− height: parent.height

635− target: hud.revealerTarget

636− closedValue: height

637− openedValue: 0

638− direction: Qt.RightToLeft

639− orientation: Qt.Vertical

640− handleSize: hud.handleHeight

641− onCloseClicked: target.hide()

642− }

643−

644− Bottombar {

645− id: bottombar

646− theHud: hud

647− anchors.fill: parent

648− enabled: hud.available

649− applicationIsOnForeground: applicationFocused

650− }

651−

652608 InputFilterArea {

653609 blockInput: launcher.shown

654610 anchors {

@@ -693,8 +649,6 @@ FocusScope {

693649 onShownChanged: {

694650 if (shown) {

695651 panel.indicators.hide()

696− hud.hide()

697− bottombar.hide()

698652 }

699653 }

700654 }

tests/autopilot/unity8/application_lifecycle/tests/test_url_dispatcher.py+5−40

@@ -20,12 +20,11 @@

2020"""Test the integration with the URL dispatcher service."""

2121

2222import os

23−import tempfile

2423

2524from autopilot import platform

2625from autopilot.matchers import Eventually

2726from testtools.matchers import Equals

28−from ubuntuuitoolkit import base as toolkit_base

27+from ubuntuuitoolkit import fixture_setup

2928

3029from unity8 import process_helpers

3130from unity8.shell import tests

@@ -47,13 +46,6 @@ MainView {

4746 text: 'Test application.'

4847 }

4948}

50−""")

51−

52− desktop_file_contents = ("""[Desktop Entry]

53−Type=Application

54−Name=test

55−Exec={qmlscene} {qml_file_path}

56−Icon=Not important

5749""")

5850

5951 def setUp(self):

@@ -66,37 +58,10 @@ Icon=Not important

6658 process_helpers.unlock_unity(unity_proxy)

6759

6860 def create_test_application(self):

69− # FIXME most of this code is duplicated in the toolkit. We should

70− # create a fixture on the toolkit for other projects to use.

71− # http://pad.lv/1277334 --elopio - 2014-02-06

72− qml_file_path = self._write_test_qml_file()

73− self.addCleanup(os.remove, qml_file_path)

74− desktop_file_path = self._write_test_desktop_file(qml_file_path)

75− self.addCleanup(os.remove, desktop_file_path)

76− return qml_file_path, desktop_file_path

77−

78− def _write_test_qml_file(self):

79− qml_file = tempfile.NamedTemporaryFile(suffix='.qml', delete=False)

80− qml_file.write(self.test_qml.encode('utf-8'))

81− qml_file.close()

82− return qml_file.name

83−

84− def _write_test_desktop_file(self, qml_file_path):

85− desktop_file_dir = self._get_local_desktop_file_directory()

86− if not os.path.exists(desktop_file_dir):

87− os.makedirs(desktop_file_dir)

88− desktop_file = tempfile.NamedTemporaryFile(

89− suffix='.desktop', dir=desktop_file_dir, delete=False)

90− contents = self.desktop_file_contents.format(

91− qmlscene=toolkit_base.get_qmlscene_launch_command(),

92− qml_file_path=qml_file_path)

93− desktop_file.write(contents.encode('utf-8'))

94− desktop_file.close()

95− return desktop_file.name

96−

97− def _get_local_desktop_file_directory(self):

98− return os.path.join(

99− os.environ.get('HOME'), '.local', 'share', 'applications')

61+ fake_application = fixture_setup.FakeApplication(self.test_qml)

62+ self.useFixture(fake_application)

63+ return (

64+ fake_application.qml_file_path, fake_application.desktop_file_path)

10065

10166 def test_swipe_out_application_started_by_url_dispatcher(self):

10267 _, desktop_file_path = self.create_test_application()

tests/plugins/DashViews/listviewwithpageheadertest.cpp−6

@@ -1281,9 +1281,6 @@ private Q_SLOTS:

12811281

12821282 void testShowHeaderHalfShown()

12831283 {

1284−#if (QT_VERSION < QT_VERSION_CHECK(5, 1, 0))

1285− QSKIP("This test is extremely unstable in 5.0.x");

1286−#endif

12871284 changeContentY(20);

12881285

12891286 QTRY_COMPARE(lvwph->m_visibleItems.count(), 4);

@@ -1860,9 +1857,6 @@ private Q_SLOTS:

18601857 model->setProperty(4, "size", 10);

18611858 model->setProperty(5, "size", 10);

18621859 model->setProperty(6, "size", 10);

1863−#if (QT_VERSION > QT_VERSION_CHECK(5, 0, 3))

1864− QTRY_COMPARE(lvwph->m_minYExtent, 210.);

1865−#endif

18661860 QTRY_COMPARE(lvwph->m_headerItem->y(), -lvwph->m_minYExtent);

18671861 }

18681862

tests/plugins/DashViews/listviewwithpageheadertestsection.cpp−3

@@ -1486,9 +1486,6 @@ private Q_SLOTS:

14861486

14871487 void testShowHeaderHalfShown()

14881488 {

1489−#if (QT_VERSION < QT_VERSION_CHECK(5, 1, 0))

1490− QSKIP("This test is extremely unstable in 5.0.x");

1491−#endif

14921489 changeContentY(20);

14931490

14941491 QTRY_COMPARE(lvwph->m_visibleItems.count(), 3);

tests/plugins/DashViews/organicgridtest.cpp+2−1

@@ -134,11 +134,12 @@ private Q_SLOTS:

134134 view->setSource(QUrl::fromLocalFile(DASHVIEWSTEST_FOLDER "/organicgridtest.qml"));

135135

136136 view->show();

137− view->resize(470, 400);

138137 QTest::qWaitForWindowExposed(view);

138+ view->resize(470, 400);

139139

140140 grid = dynamic_cast<OrganicGrid*>(view->rootObject()->findChild<QObject*>("grid"));

141141 grid->setModel(model);

142+ QTRY_COMPARE(grid->width(), 470.);

142143

143144 checkInitialPositions();

144145 }

tests/plugins/DashViews/verticaljournaltest.cpp+2−1

@@ -135,11 +135,12 @@ private Q_SLOTS:

135135 view->setSource(QUrl::fromLocalFile(DASHVIEWSTEST_FOLDER "/verticaljournaltest.qml"));

136136

137137 view->show();

138− view->resize(470, 400);

139138 QTest::qWaitForWindowExposed(view);

139+ view->resize(470, 400);

140140

141141 vj = dynamic_cast<VerticalJournal*>(view->rootObject()->findChild<QObject*>("vj"));

142142 vj->setModel(model);

143+ QTRY_COMPARE(vj->width(), 470.);

143144

144145 checkInitialPositions();

145146 }

tests/plugins/Ubuntu/Gestures/tst_DirectionalDragArea.cpp+8

@@ -103,6 +103,14 @@ void tst_DirectionalDragArea::init()

103103{

104104 GestureTest::init();

105105

106+ // We shouldn't need the three lines below, but a compiz/unity7

107+ // regression means we don't pass the test without them because

108+ // the window doesn't have the proper size. Can be removed in the

109+ // future if the regression is fixed and tests pass again

110+ m_view->resize(m_view->rootObject()->width(), m_view->rootObject()->height());

111+ QTRY_COMPARE(m_view->width(), (int)m_view->rootObject()->width());

112+ QTRY_COMPARE(m_view->height(), (int)m_view->rootObject()->height());

113+

106114 fakeTimeSource.reset(new FakeTimeSource);

107115 fakeTimer = new FakeTimer(fakeTimeSource);

108116}

tests/qmltests/Components/tst_DragHandle.cpp−1

@@ -126,7 +126,6 @@ QQuickView *tst_DragHandle::createView()

126126{

127127 QQuickView *window = new QQuickView(0);

128128 window->setResizeMode(QQuickView::SizeRootObjectToView);

129− window->resize(600, 600);

130129 window->engine()->addImportPath(QLatin1String(UBUNTU_GESTURES_PLUGIN_DIR));

131130 window->engine()->addImportPath(QLatin1String(TEST_DIR));

132131

tests/qmltests/Components/tst_LazyImage.qml+1−1

@@ -155,7 +155,7 @@ Rectangle {

155155

156156 if (data.transition) {

157157 // wait for the transition to complete

158− var transition = findInvisibleChild(data.image, data.transition);

158+ var transition = findChildIn(data.image, "transitions", data.transition);

159159 tryCompare(transition, "running", true);

160160 tryCompare(transition, "running", false);

161161 }

tests/qmltests/Dash/Previews/tst_PreviewVideoPlayback.qml−6

@@ -53,12 +53,6 @@ Rectangle {

5353 function test_loadScreenshot() {

5454 var screenshot = findChild(videoPlayback, "screenshot");

5555

56− videoPlayback.widgetData = widgetData0;

57− tryCompare(screenshot.visible, false);

58−

59− videoPlayback.widgetData = widgetData1;

60− tryCompare(screenshot.visible, true);

61−

6256 videoPlayback.widgetData = widgetData2;

6357 var screenshotSource = screenshot.source

6458 verify(screenshotSource.toString().indexOf("image://thumbnailer/") === 0)

tests/qmltests/Dash/Previews/tst_PreviewZoomableImage.qml+3−4

@@ -30,14 +30,13 @@ Rectangle {

3030 }

3131

3232 property var widgetData1: {

33− "source": "../../graphics/phone_background.jpg",

33+ "source": Qt.resolvedUrl("../artwork/checkers.png"),

3434 "zoomable": false

3535 }

3636

3737 PreviewZoomableImage {

3838 id: zoomableImage

3939 width: parent.width

40− widgetData: widgetData1

4140 }

4241

4342 UT.UnityTestCase {

@@ -48,10 +47,10 @@ Rectangle {

4847 var image = findChild(zoomableImage, "image");

4948

5049 zoomableImage.widgetData = widgetData0;

51− tryCompare(image.state, "default");

50+ tryCompare(image, "state", "default");

5251

5352 zoomableImage.widgetData = widgetData1;

54− tryCompare(image.state, "ready");

53+ tryCompare(image, "state", "ready");

5554 }

5655 }

5756}

tests/qmltests/Dash/tst_Card.qml+49

@@ -427,5 +427,54 @@ Rectangle {

427427

428428 tryCompare(testCase.title.font, "weight", data.weight);

429429 }

430+

431+ function test_fontColor_data() {

432+ return [

433+ { tag: "#ffffff", dark: true },

434+ { tag: "#fdfdfd", dark: true },

435+ { tag: "#f9f9f9", dark: true },

436+ { tag: "#000000", dark: false },

437+ { tag: "#ef814c", dark: false },

438+ { tag: "#312f2c", dark: false },

439+ { tag: "#be332d", dark: false },

440+ { tag: "#52ace4", dark: false },

441+ { tag: "#3a5897", dark: false },

442+ { tag: "#1caeeb", dark: false },

443+ { tag: "#87c341", dark: false },

444+ { tag: "#50893b", dark: false },

445+ ];

446+ }

447+

448+ function test_fontColor(data) {

449+ selector.selectedIndex = 10;

450+

451+ background.color = data.tag;

452+

453+ var fontColor = data.dark ? "grey" : "white";

454+

455+ tryCompareFunction(function() { return Qt.colorEqual(summary.color, fontColor); }, true);

456+ tryCompareFunction(function() { return Qt.colorEqual(header.fontColor, fontColor); }, true);

457+ }

458+

459+ function test_mascotShape_data() {

460+ return [

461+ { tag: "Art and summary", shape: false, index: 0 },

462+ { tag: "No Summary", shape: true, index: 6 },

463+ { tag: "With background", shape: false, index: 10 },

464+ ];

465+ }

466+

467+ function test_mascotShape(data) {

468+ selector.selectedIndex = data.index;

469+

470+ var shape = findChild(card, "mascotShape");

471+ var image = findChild(card, "mascotImage");

472+

473+ verify(shape, "Could not find shape.");

474+ verify(image, "Could not find image.");

475+

476+ tryCompare(shape, "visible", data.shape);

477+ tryCompare(image, "visible", !data.shape);

478+ }

430479 }

431480}

tests/qmltests/Dash/tst_CardHeader.qml+1−28

@@ -46,7 +46,6 @@ Rectangle {

4646 property Item mascot: findChild(cardHeader, "mascotShape")

4747 property Item titleLabel: findChild(cardHeader, "titleLabel")

4848 property Item subtitleLabel: findChild(cardHeader, "subtitleLabel")

49− property Item prices: findChild(cardHeader, "prices")

5049 property Item oldPriceLabel: findChild(cardHeader, "oldPriceLabel")

5150 property Item outerRow: findChild(cardHeader, "outerRow")

5251 property Item column: findChild(cardHeader, "column")

@@ -55,7 +54,6 @@ Rectangle {

5554 verify(typeof testCase.mascot === "object", "Couldn't find mascot object.");

5655 verify(typeof testCase.titleLabel === "object", "Couldn't find titleLabel object.");

5756 verify(typeof testCase.subtitleLabel === "object", "Couldn't find subtitleLabel object.");

58− verify(typeof testCase.prices === "object", "Couldn't find prices object.");

5957 verify(typeof testCase.oldPriceLabel === "object", "Couldn't find oldPriceLabel object.");

6058 }

6159

@@ -63,9 +61,6 @@ Rectangle {

6361 cardHeader.mascot = "";

6462 cardHeader.title = "";

6563 cardHeader.subtitle = "";

66− cardHeader.price = "";

67− cardHeader.oldPrice = "";

68− cardHeader.altPrice = "";

6964 }

7065

7166 function test_mascot_data() {

@@ -96,33 +91,11 @@ Rectangle {

9691 tryCompare(cardHeader, "visible", data.visible);

9792 }

9893

99− function test_prices_data() {

100− return [

101− { tag: "Main", main: "$1.25", visible: true },

102− { tag: "Alt", alt: "€1.00", visible: false },

103− { tag: "Old", old: "€2.00", visible: false },

104− { tag: "Main and Alt", main: "$1.25", alt: "€1.00", visible: true },

105− { tag: "Main and Old", main: "$1.25", old: "$2.00", visible: true, oldAlign: Text.AlignRight },

106− { tag: "Alt and Old", alt: "€1.00", old: "$2.00", visible: false },

107− { tag: "All", main: "$1.25", alt: "€1.00", old: "$2.00", visible: true, oldAlign: Text.AlignHCenter },

108− ]

109− }

110−

111− function test_prices(data) {

112− cardHeader.price = data.main !== undefined ? data.main : "";

113− cardHeader.oldPrice = data.old !== undefined ? data.old : "";

114− cardHeader.altPrice = data.alt !== undefined ? data.alt : "";

115− tryCompare(cardHeader, "visible", data.visible);

116− if (data.hasOwnProperty("oldAlign")) {

117− compare(testCase.oldPriceLabel.horizontalAlignment, data.oldAlign, "Old price label is aligned wrong.")

118− }

119− }

120−

12194 function test_dimensions_data() {

12295 return [

12396 { tag: "Column width", object: column, width: cardHeader.width },

12497 { tag: "Column width with mascot", object: column, width: cardHeader.width - mascot.width - outerRow.margins * 3, mascot: "artwork/avatar.png" },

125− { tag: "Header height", object: cardHeader, height: function() { return subtitleLabel.y + subtitleLabel.height + outerRow.margins * 2 } },

98+ { tag: "Header height", object: cardHeader, height: function() { return outerRow.height + outerRow.margins * 2 } },

12699 ]

127100 }

128101

tests/qmltests/Dash/tst_CardTool.qml+20

@@ -93,6 +93,7 @@ Rectangle {

9393 CardTool {

9494 id: cardTool

9595

96+ count: 8

9697 template: Helpers.update(JSON.parse(Helpers.defaultLayout), Helpers.tryParse(layoutArea.text, layoutError))['template'];

9798 components: Helpers.update(JSON.parse(Helpers.defaultLayout), Helpers.tryParse(layoutArea.text, layoutError))['components'];

9899 viewWidth: units.gu(Math.round(widthSlider.value))

@@ -343,5 +344,24 @@ Rectangle {

343344 tryCompare(cardTool, data.property, data.value);

344345 }

345346 }

347+

348+ function test_categoryLayout_data() {

349+ return [

350+ { tag: "Default Grid", layout_index: 0, count: 2, viewWidth: units.gu(40), layout: "grid" },

351+ { tag: "Long carousel", layout_index: 4, count: 6, viewWidth: units.gu(140), layout: "carousel" },

352+ { tag: "Long carousel fallback", layout_index: 4, count: 5, viewWidth: units.gu(140), layout: "grid" },

353+ { tag: "Short carousel", layout_index: 4, count: 4, viewWidth: units.gu(30), layout: "carousel" },

354+ { tag: "Short carousel fallback", layout_index: 4, count: 3, viewWidth: units.gu(30), layout: "grid" },

355+ { tag: "Journal", layout_index: 2, count: 8, viewWidth: units.gu(30), layout: "journal" }

356+ ]

357+ }

358+

359+ function test_categoryLayout(data) {

360+ selector.selectedIndex = 0;

361+ layoutSelector.selectedIndex = data.layout_index;

362+ cardTool.viewWidth = data.viewWidth;

363+ cardTool.count = data.count;

364+ compare(cardTool.categoryLayout, data.layout);

365+ }

346366 }

347367}

tests/qmltests/Dash/tst_DashContent.qml+1−1

@@ -284,7 +284,7 @@ Item {

284284 tryCompare(scopesModel, "loaded", true);

285285 var tabbar = findChild(dashContent, "tabbar");

286286

287− compare(dashContent.currentIndex, 0);

287+ tryCompare(dashContent, "currentIndex", 0);

288288 tryCompare(tabbar, "selectedIndex", 0);

289289 tryCompare(tabbar, "selectionMode", false);

290290

tests/qmltests/Dash/tst_GenericPreview.qml+2−2

@@ -22,7 +22,7 @@ import Unity.Test 0.1 as UT

2222Item {

2323 id: root

2424 width: units.gu(60)

25− height: units.gu(80)

25+ height: units.gu(90)

2626

2727 property var calls: []

2828 property int counter: 0

@@ -81,7 +81,7 @@ Item {

8181

8282 var actions = get_actions_data();

8383 for(var i = 0; i < actions.length; i++) {

84− compare(root.calls[i], actions[i].id);

84+ tryCompare(root.calls, i, actions[i].id);

8585 }

8686 }

8787

tests/qmltests/Dash/tst_GenericScopeView.qml+3−3

@@ -67,7 +67,7 @@ Item {

6767 function init() {

6868 shell.width = units.gu(120)

6969 genericScopeView.categoryView.positionAtBeginning();

70− tryCompare(genericScopeView.categoryView.contentY, 0)

70+ tryCompare(genericScopeView.categoryView, "contentY", 0)

7171 }

7272

7373 function test_isCurrent() {

@@ -184,13 +184,13 @@ Item {

184184 categoryListView.positionAtBeginning();

185185 waitForRendering(categoryListView);

186186 categoryListView.flick(0, -units.gu(60));

187− tryCompare(categoryListView.flicking, false);

187+ tryCompare(categoryListView, "flicking", false);

188188

189189 var tile = findChild(findChild(genericScopeView, "0"), "delegate0");

190190 mouseClick(tile, tile.width / 2, tile.height - 1);

191191 tryCompare(openEffect, "gap", 1);

192192

193− verify(openEffect.positionPx >= pageHeader.height + categoryListView.stickyHeaderHeight);

193+ verify(openEffect.positionPx >= Math.round(pageHeader.height + categoryListView.stickyHeaderHeight));

194194 }

195195

196196 function test_previewCycle() {

tests/qmltests/Launcher/tst_Launcher.qml+6−4

@@ -121,8 +121,7 @@ Item {

121121 revealer.dragLauncherIntoView()

122122

123123 var listView = findChild(launcher, "launcherListView");

124− listView.flick(0, units.gu(500));

125− tryCompare(listView, "flicking", false);

124+ listView.positionViewAtEnd();

126125

127126 var appIcon = findChild(launcher, "launcherDelegate0")

128127

@@ -397,8 +396,11 @@ Item {

397396

398397 // Position launcher to where we need it

399398 var listView = findChild(launcher, "launcherListView");

400− listView.flick(0, units.gu(200) * (data.flickTo === "top" ? 1 : -1));

401− tryCompare(listView, "flicking", false);

399+ if (data.flickTo == "top") {

400+ listView.positionViewAtEnd();

401+ } else {

402+ listView.positionViewAtBeginning();

403+ }

402404

403405 // Doing longpress

404406 mousePress(draggedItem, draggedItem.width / 2, draggedItem.height / 2)

tests/qmltests/tst_Shell.qml+18−2

@@ -110,6 +110,9 @@ Item {

110110 swipeUntilScopeViewIsReached(dashHome);

111111

112112 hideIndicators();

113+

114+ var dashContent = findChild(shell, "dashContent");

115+ dashContent.previewOpen = false;

113116 }

114117

115118 function killApps(apps) {

@@ -235,8 +238,8 @@ Item {

235238

236239 var dash = findChild(shell, "dash");

237240 // check that dash has normal scale and opacity

238− tryCompare(dash.contentScale, 1.0);

239− tryCompare(dash.opacity, 1.0);

241+ tryCompare(dash, "contentScale", 1.0);

242+ tryCompare(dash, "opacity", 1.0);

240243

241244 touchFlick(shell, touchX, touchY, shell.width * 0.1, touchY,

242245 true /* beginTouch */, false /* endTouch */);

@@ -549,5 +552,18 @@ Item {

549552 tryCompare(greeter, "shown", true)

550553 tryCompare(searchIndicator, "opacity", 0)

551554 }

555+

556+ function test_searchIndicatorHideOnPreviewShown() {

557+ var searchIndicator = findChild(shell, "container");

558+ var dashContent = findChild(shell, "dashContent");

559+

560+ verify(dashContent != null);

561+

562+ tryCompare(searchIndicator, "opacity", 1);

563+

564+ dashContent.previewOpen = true;

565+

566+ tryCompare(searchIndicator, "opacity", 0);

567+ }

552568 }

553569}

tests/utils/modules/Unity/Test/UnityTestCase.qml+10−16

@@ -71,19 +71,8 @@ TestCase {

7171

7272

7373 // Find an object with the given name in the children tree of "obj"

74− function findChild(obj,objectName) {

75− var childs = new Array(0);

76− childs.push(obj)

77− while (childs.length > 0) {

78− if (childs[0].objectName == objectName) {

79− return childs[0]

80− }

81− for (var i in childs[0].children) {

82− childs.push(childs[0].children[i])

83− }

84− childs.splice(0, 1);

85− }

86− return null;

74+ function findChild(obj, objectName) {

75+ return findChildIn(obj, "children", objectName);

8776 }

8877

8978 // Find an object with the given name in the children tree of "obj"

@@ -91,15 +80,20 @@ TestCase {

9180 // Note: you should use findChild if you're not sure you need this

9281 // as this tree is much bigger and might contain stuff that goes

9382 // away randomly.

94− function findInvisibleChild(obj,objectName) {

83+ function findInvisibleChild(obj, objectName) {

84+ return findChildIn(obj, "data", objectName);

85+ }

86+

87+ // Find a child in the named property

88+ function findChildIn(obj, prop, objectName) {

9589 var childs = new Array(0);

9690 childs.push(obj)

9791 while (childs.length > 0) {

9892 if (childs[0].objectName == objectName) {

9993 return childs[0]

10094 }

101− for (var i in childs[0].data) {

102− childs.push(childs[0].data[i])

95+ for (var i in childs[0][prop]) {

96+ childs.push(childs[0][prop][i])

10397 }

10498 childs.splice(0, 1);

10599 }