git.iko.soy/unity8
on xenial help sign in
workaround for bad row height on Qt 5.4 (on the phone)
ba65d48Albert Astals Cid
qml/Dash/Previews/PreviewTable.qml+3
compare with xenial
unifiedsplit
@@ -78,6 +78,9 @@ PreviewWidget {
78 Layout.alignment: Qt.AlignTop
78 Layout.alignment: Qt.AlignTop
79 Layout.maximumWidth: index == 0 ? column.width / 4 : column.width - x
79 Layout.maximumWidth: index == 0 ? column.width / 4 : column.width - x
80 Layout.minimumWidth: index == 0 ? column.width / 4 : -1
80 Layout.minimumWidth: index == 0 ? column.width / 4 : -1
81+ height: -1 // FIXME Qt 5.4 needs this otherwise wrapped columns
82+ // get the height wrong and the next row looks weird
83+ // remove once we stop supporting Qt 5.4 (if 5.5 doesn't need it)
81 }
84 }
82 }
85 }
83 }
86 }
tests/qmltests/Dash/Previews/tst_PreviewTable.qml+1−1
@@ -33,7 +33,7 @@ Rectangle {
33
33
34 property var widgetDataComplete2: {
34 property var widgetDataComplete2: {
35 "title": "Short Title here",
35 "title": "Short Title here",
36− "values": [ [ "Label A", "Long Value 1 Long Value 2 Long Value 3 Long Value 4 Long Value 5 Long Value 6 Long Value 2 Long Value 2 Long Value 2 Long Value 2"], [ "Author", "Best 3v3r"], [ "Summary", "If i knew how to write summaries i'd be working somewhere else"] ]
36+ "values": [ [ "Publisher/Creator", "Unity8 team" ], [ "Label A", "Long Value 1 Long Value 2 Long Value 3 Long Value 4 Long Value 5 Long Value 6 Long Value 2 Long Value 2 Long Value 2 Long Value 2"], [ "Author", "Best 3v3r"], [ "Summary", "If i knew how to write summaries i'd be working somewhere else"] ]
37 }
37 }
38
38
39 property var widgetDataNoTitle: {
39 property var widgetDataNoTitle: {