on xenial help sign in
Add support for the persistent alert state.

Paint pips blue when an app is in alert state (LP: #1575147, #1584348, #1586621)

commitbfaa2aa861a06f9558685531532060fc5e2d5a30 authorMichael Zanetti <michael.zanetti@canonical.com> dateFri 17 Jun 2016, 01:12 (10 years ago) parentf046f2635ade0a
13 files changed+44−54
debian/control+1−1 plugins/Greeter/Unity/Launcher/CMakeLists.txt+1−1 plugins/Greeter/Unity/Launcher/launchermodelas.cpp−7 plugins/Greeter/Unity/Launcher/launchermodelas.h−1 plugins/Unity/Launcher/CMakeLists.txt+1−1 plugins/Unity/Launcher/launcheritem.cpp−9 plugins/Unity/Launcher/launchermodel.cpp+29−24 plugins/Unity/Launcher/launchermodel.h−1 qml/Launcher/LauncherDelegate.qml+1−7 qml/Launcher/LauncherPanel.qml+1 tests/mocks/Unity/Launcher/CMakeLists.txt+1−1 tests/mocks/Unity/Launcher/MockLauncherModel.h+1−1 tests/plugins/Unity/Launcher/launchermodeltest.cpp+8
debian/control+1−1
@@ -33,7 +33,7 @@ Build-Depends: cmake,
3333 libubuntugestures5-dev,
3434 libubuntugestures5-private-dev,
3535 libudev-dev,
36− libunity-api-dev (>= 7.114),
36+ libunity-api-dev (>= 7.115),
3737 libusermetricsoutput1-dev,
3838# Need those X11 libs touch emulation from mouse events in manual QML tests on a X11 desktop
3939 libx11-dev[!armhf],
plugins/Greeter/Unity/Launcher/CMakeLists.txt+1−1
@@ -1,4 +1,4 @@
1−pkg_check_modules(LAUNCHER_API REQUIRED unity-shell-launcher=8)
1+pkg_check_modules(LAUNCHER_API REQUIRED unity-shell-launcher=9)
22pkg_check_modules(GSETTINGS_QT REQUIRED gsettings-qt)
33
44add_definitions(-DSM_BUSNAME=systemBus)
plugins/Greeter/Unity/Launcher/launchermodelas.cpp−7
@@ -76,13 +76,6 @@ QVariant LauncherModel::data(const QModelIndex &index, int role) const
7676 return QVariant();
7777}
7878
79−void LauncherModel::setAlerting(const QString &appId, bool alerting)
80−{
81− Q_UNUSED(appId)
82− Q_UNUSED(alerting)
83− qWarning() << "This is a read only implementation. Cannot set alert-state of items.";
84−}
85−
8679unity::shell::launcher::LauncherItemInterface *LauncherModel::get(int index) const
8780{
8881 if (index < 0 || index >= m_list.count()) {
plugins/Greeter/Unity/Launcher/launchermodelas.h−1
@@ -41,7 +41,6 @@ public:
4141
4242 QVariant data(const QModelIndex &index, int role) const override;
4343
44− Q_INVOKABLE void setAlerting(const QString &appId, bool alerting) override;
4544 Q_INVOKABLE unity::shell::launcher::LauncherItemInterface* get(int index) const override;
4645 Q_INVOKABLE void move(int oldIndex, int newIndex) override;
4746 Q_INVOKABLE void pin(const QString &appId, int index = -1) override;
plugins/Unity/Launcher/CMakeLists.txt+1−1
@@ -1,4 +1,4 @@
1−pkg_check_modules(LAUNCHER_API REQUIRED unity-shell-launcher=8)
1+pkg_check_modules(LAUNCHER_API REQUIRED unity-shell-launcher=9)
22pkg_check_modules(GSETTINGS_QT REQUIRED gsettings-qt)
33
44add_definitions(-DSM_BUSNAME=systemBus)
plugins/Unity/Launcher/launcheritem.cpp−9
@@ -163,9 +163,6 @@ void LauncherItem::setCount(int count)
163163 if (m_count != count) {
164164 m_count = count;
165165 Q_EMIT countChanged(count);
166− if (m_countVisible) {
167− setAlerting(true);
168− }
169166 }
170167}
171168
@@ -179,9 +176,6 @@ void LauncherItem::setCountVisible(bool countVisible)
179176 if (m_countVisible != countVisible) {
180177 m_countVisible = countVisible;
181178 Q_EMIT countVisibleChanged(countVisible);
182− if (countVisible) {
183− setAlerting(true);
184− }
185179 }
186180}
187181
@@ -194,9 +188,6 @@ void LauncherItem::setFocused(bool focused)
194188{
195189 if (m_focused != focused) {
196190 m_focused = focused;
197− if (focused) {
198− setAlerting(false);
199− }
200191 Q_EMIT focusedChanged(focused);
201192 }
202193}
plugins/Unity/Launcher/launchermodel.cpp+29−24
@@ -99,18 +99,6 @@ QVariant LauncherModel::data(const QModelIndex &index, int role) const
9999 return QVariant();
100100}
101101
102−void LauncherModel::setAlerting(const QString &appId, bool alerting) {
103− int index = findApplication(appId);
104− if (index >= 0) {
105− QModelIndex modelIndex = this->index(index);
106− LauncherItem *item = m_list.at(index);
107− if (!item->focused()) {
108− item->setAlerting(alerting);
109− Q_EMIT dataChanged(modelIndex, modelIndex, {RoleAlerting});
110− }
111− }
112−}
113−
114102unity::shell::launcher::LauncherItemInterface *LauncherModel::get(int index) const
115103{
116104 if (index < 0 || index >= m_list.count()) {
@@ -361,11 +349,13 @@ void LauncherModel::countChanged(const QString &appId, int count)
361349 if (idx >= 0) {
362350 LauncherItem *item = m_list.at(idx);
363351 item->setCount(count);
364− if (item->countVisible()) {
365− setAlerting(item->appId(), true);
352+ QVector<int> changedRoles = {RoleCount};
353+ if (item->countVisible() && !item->alerting() && !item->focused()) {
354+ changedRoles << RoleAlerting;
355+ item->setAlerting(true);
366356 }
367357 m_asAdapter->syncItems(m_list);
368− Q_EMIT dataChanged(index(idx), index(idx), {RoleCount});
358+ Q_EMIT dataChanged(index(idx), index(idx), changedRoles);
369359 }
370360}
371361
@@ -375,10 +365,12 @@ void LauncherModel::countVisibleChanged(const QString &appId, bool countVisible)
375365 if (idx >= 0) {
376366 LauncherItem *item = m_list.at(idx);
377367 item->setCountVisible(countVisible);
378− if (countVisible) {
379− setAlerting(item->appId(), true);
368+ QVector<int> changedRoles = {RoleCount};
369+ if (countVisible && !item->alerting() && !item->focused()) {
370+ changedRoles << RoleAlerting;
371+ item->setAlerting(true);
380372 }
381− Q_EMIT dataChanged(index(idx), index(idx), {RoleCountVisible});
373+ Q_EMIT dataChanged(index(idx), index(idx), changedRoles);
382374
383375 // If countVisible goes to false, and the item is neither pinned nor recent we can drop it
384376 if (!countVisible && !item->pinned() && !item->recent()) {
@@ -501,8 +493,10 @@ void LauncherModel::alert(const QString &appId)
501493 int idx = findApplication(appId);
502494 if (idx >= 0) {
503495 LauncherItem *item = m_list.at(idx);
504− setAlerting(item->appId(), true);
505− Q_EMIT dataChanged(index(idx), index(idx), {RoleAlerting});
496+ if (!item->focused() && !item->alerting()) {
497+ item->setAlerting(true);
498+ Q_EMIT dataChanged(index(idx), index(idx), {RoleAlerting});
499+ }
506500 }
507501}
508502
@@ -585,16 +579,21 @@ void LauncherModel::applicationRemoved(const QModelIndex &parent, int row)
585579 disconnect(app, &ApplicationInfoInterface::surfaceCountChanged, this, &LauncherModel::applicationSurfaceCountChanged);
586580
587581 LauncherItem * item = m_list.at(appIndex);
588− item->setRunning(false);
589582
590583 if (!item->pinned()) {
591584 beginRemoveRows(QModelIndex(), appIndex, appIndex);
592585 m_list.takeAt(appIndex)->deleteLater();
593586 endRemoveRows();
594587 m_asAdapter->syncItems(m_list);
595− Q_EMIT dataChanged(index(appIndex), index(appIndex), {RolePinned});
588+ } else {
589+ QVector<int> changedRoles = {RoleRunning};
590+ item->setRunning(false);
591+ if (item->focused()) {
592+ changedRoles << RoleFocused;
593+ item->setFocused(false);
594+ }
595+ Q_EMIT dataChanged(index(appIndex), index(appIndex), changedRoles);
596596 }
597− Q_EMIT dataChanged(index(appIndex), index(appIndex), {RoleRunning});
598597}
599598
600599void LauncherModel::focusedAppIdChanged()
@@ -603,8 +602,14 @@ void LauncherModel::focusedAppIdChanged()
603602 for (int i = 0; i < m_list.count(); ++i) {
604603 LauncherItem *item = m_list.at(i);
605604 if (!item->focused() && item->appId() == appId) {
605+ QVector<int> changedRoles;
606+ changedRoles << RoleFocused;
606607 item->setFocused(true);
607− Q_EMIT dataChanged(index(i), index(i), {RoleFocused});
608+ if (item->alerting()) {
609+ changedRoles << RoleAlerting;
610+ item->setAlerting(false);
611+ }
612+ Q_EMIT dataChanged(index(i), index(i), changedRoles);
608613 } else if (item->focused() && item->appId() != appId) {
609614 item->setFocused(false);
610615 Q_EMIT dataChanged(index(i), index(i), {RoleFocused});
plugins/Unity/Launcher/launchermodel.h−1
@@ -45,7 +45,6 @@ public:
4545
4646 QVariant data(const QModelIndex &index, int role) const override;
4747
48− Q_INVOKABLE void setAlerting(const QString &appId, bool alerting) override;
4948 Q_INVOKABLE unity::shell::launcher::LauncherItemInterface* get(int index) const override;
5049 Q_INVOKABLE void move(int oldIndex, int newIndex) override;
5150 Q_INVOKABLE void pin(const QString &appId, int index = -1) override;
qml/Launcher/LauncherDelegate.qml+1−7
@@ -115,12 +115,6 @@ Item {
115115 duration: priv.wiggleDuration
116116 easing.type: Easing.OutQuad
117117 }
118−
119− UbuntuNumberAnimation {
120− target: root
121− property: "alerting"
122− to: 0
123− }
124118 }
125119
126120 Item {
@@ -228,7 +222,7 @@ Item {
228222 objectName: "runningHighlight" + index
229223 width: units.gu(0.25)
230224 height: units.gu(.5)
231− color: "white"
225+ color: root.alerting ? theme.palette.normal.activity : "white"
232226 visible: root.itemRunning
233227 }
234228 }
qml/Launcher/LauncherPanel.qml+1
@@ -272,6 +272,7 @@ Rectangle {
272272
273273 PropertyAction { target: launcherListViewItem; property: "clip"; value: 1 }
274274 PropertyAction { target: root; property: "visible"; value: (launcher.visibleWidth === 0) ? 0 : 1 }
275+ PropertyAction { target: launcherListView; property: "peekingIndex"; value: -1 }
275276 }
276277
277278 onAlertingChanged: {
tests/mocks/Unity/Launcher/CMakeLists.txt+1−1
@@ -1,4 +1,4 @@
1−pkg_check_modules(LAUNCHER_API REQUIRED unity-shell-launcher=8)
1+pkg_check_modules(LAUNCHER_API REQUIRED unity-shell-launcher=9)
22
33include_directories(
44 ${CMAKE_CURRENT_SOURCE_DIR}
tests/mocks/Unity/Launcher/MockLauncherModel.h+1−1
@@ -38,7 +38,7 @@ public:
3838
3939 QVariant data(const QModelIndex& index, int role) const override;
4040
41− Q_INVOKABLE void setAlerting(const QString &appId, bool alerting) override;
41+ Q_INVOKABLE void setAlerting(const QString &appId, bool alerting); // Only for testing
4242 Q_INVOKABLE unity::shell::launcher::LauncherItemInterface *get(int index) const override;
4343 Q_INVOKABLE void move(int oldIndex, int newIndex) override;
4444 Q_INVOKABLE void pin(const QString &appId, int index = -1) override;
tests/plugins/Unity/Launcher/launchermodeltest.cpp+8
@@ -491,6 +491,10 @@ private Q_SLOTS:
491491
492492 // Finally check, that the change to "count" implicitly also set the alerting-state to true
493493 QVERIFY(launcherModel->get(index)->alerting() == true);
494+
495+ // Focus the app, make sure the alert gets cleared
496+ appManager->focusApplication("abs-icon");
497+ QVERIFY(launcherModel->get(index)->alerting() == false);
494498 }
495499
496500 void testCountEmblemAddsRemovesItem_data() {
@@ -562,6 +566,10 @@ private Q_SLOTS:
562566
563567 // Check that the alerting-status is now true
564568 QVERIFY(launcherModel->get(index)->alerting() == true);
569+
570+ // Focus the app, make sure the alert gets cleared
571+ appManager->focusApplication("abs-icon");
572+ QVERIFY(launcherModel->get(index)->alerting() == false);
565573 }
566574
567575 void testRefreshAfterDeletedDesktopFiles_data() {