c042d15 · unity8 · git.iko.soy

git.iko.soy/unity8

Updated Indicator model roles for fixing test suite.

commitc042d1553eb7a4ae1241d2ac90d6b2fdb5c49952 authorNick Dedekind <nicholas.dedekind@gmail.com> dateMon 1 Jul 2013, 10:40 (13 years ago) parentd88d556

12 files changed+122−62

compare with xenial

unifiedsplit

Panel/MenuContent.qml+1−1

@@ -184,7 +184,7 @@ Rectangle {

184184 if (content.overviewActive)

185185 return i18n.tr("Device");

186186 if (indicatorsModel && menus.currentIndex >= 0 && menus.currentIndex < indicatorsModel.count)

187− return indicatorsModel.data(menus.currentIndex, Indicators.IndicatorsModel.Title);

187+ return indicatorsModel.data(menus.currentIndex, Indicators.IndicatorsModelRole.Title);

188188 return "";

189189 }

190190 opacity: __shown ? 1 : 0

modules/Unity/Indicators/flatmenuproxymodel.h−10

@@ -36,16 +36,6 @@ class FlatMenuProxyModel : public QAbstractProxyModel

3636

3737 Q_ENUMS(Roles)

3838public:

39− // Because this is a proxy to qmenumodel, it may change.

40− enum Roles {

41− Action = Qt::DisplayRole + 1,

42− Label,

43− Extra,

44− Depth,

45− hasSection,

46− hasSubMenu

47− };

48−

4939 FlatMenuProxyModel(QAbstractItemModel *source=0);

5040 ~FlatMenuProxyModel();

5141

modules/Unity/Indicators/indicators.h+38

@@ -19,6 +19,8 @@

1919#ifndef INDICATORS_H

2020#define INDICATORS_H

2121

22+#include <QObject>

23+

2224class ActionState : public QObject

2325{

2426 Q_OBJECT

@@ -62,4 +64,40 @@ public:

6264 NetworkConnection(QObject*parent=0):QObject(parent) {}

6365};

6466

67+class IndicatorsModelRole : public QObject

68+{

69+ Q_OBJECT

70+public:

71+ Q_ENUMS(Roles)

72+ enum Roles {

73+ Identifier = 0,

74+ Priority,

75+ Title,

76+ Description,

77+ WidgetSource,

78+ PageSource,

79+ IndicatorProperties,

80+ IsValid

81+ };

82+

83+ IndicatorsModelRole(QObject*parent=0):QObject(parent) {}

84+};

85+

86+class FlatMenuProxyModelRole : public QObject

87+{

88+ Q_OBJECT

89+public:

90+ Q_ENUMS(Roles)

91+ enum Roles {

92+ Action = Qt::DisplayRole + 1,

93+ Label,

94+ Extra,

95+ Depth,

96+ hasSection,

97+ hasSubMenu

98+ };

99+

100+ FlatMenuProxyModelRole(QObject*parent=0):QObject(parent) {}

101+};

102+

65103#endif // INDICATORS_H

modules/Unity/Indicators/indicatorsmodel.cpp+25−24

@@ -20,6 +20,7 @@

2020#include "indicatorsmodel.h"

2121#include "indicatorsmanager.h"

2222#include "indicator.h"

23+#include "indicators.h"

2324#include "paths.h"

2425

2526#include <QQmlContext>

@@ -118,7 +119,7 @@ void IndicatorsModel::onIndicatorLoaded(const QString& indicator_name)

118119 while (pos < count())

119120 {

120121 // keep going while the existing priority is less.

121− if (indicatorData(indicator, Priority).toInt() < data(index(pos), Priority).toInt())

122+ if (indicatorData(indicator, IndicatorsModelRole::Priority).toInt() < data(index(pos), IndicatorsModelRole::Priority).toInt())

122123 break;

123124 pos++;

124125 }

@@ -160,13 +161,13 @@ void IndicatorsModel::onIndicatorAboutToBeUnloaded(const QString& indicator_name

160161/*! \internal */

161162void IndicatorsModel::onIdentifierChanged()

162163{

163− notifyDataChanged(QObject::sender(), Identifier);

164+ notifyDataChanged(QObject::sender(), IndicatorsModelRole::Identifier);

164165}

165166

166167/*! \internal */

167168void IndicatorsModel::onIndicatorPropertiesChanged()

168169{

169− notifyDataChanged(QObject::sender(), IndicatorProperties);

170+ notifyDataChanged(QObject::sender(), IndicatorsModelRole::IndicatorProperties);

170171}

171172

172173/*! \internal */

@@ -198,14 +199,14 @@ QHash<int, QByteArray> IndicatorsModel::roleNames() const

198199 static QHash<int, QByteArray> roles;

199200 if (roles.isEmpty())

200201 {

201− roles[Identifier] = "identifier";

202− roles[Priority] = "priority";

203− roles[Title] = "title";

204− roles[Description] = "description";

205− roles[WidgetSource] = "widgetSource";

206− roles[PageSource] = "pageSource";

207− roles[IndicatorProperties] = "indicatorProperties";

208− roles[IsValid] = "isValid";

202+ roles[IndicatorsModelRole::Identifier] = "identifier";

203+ roles[IndicatorsModelRole::Priority] = "priority";

204+ roles[IndicatorsModelRole::Title] = "title";

205+ roles[IndicatorsModelRole::Description] = "description";

206+ roles[IndicatorsModelRole::WidgetSource] = "widgetSource";

207+ roles[IndicatorsModelRole::PageSource] = "pageSource";

208+ roles[IndicatorsModelRole::IndicatorProperties] = "indicatorProperties";

209+ roles[IndicatorsModelRole::IsValid] = "isValid";

209210 }

210211 return roles;

211212}

@@ -221,15 +222,15 @@ QVariant IndicatorsModel::defaultData(Indicator::Ptr indicator, int role)

221222{

222223 switch (role)

223224 {

224− case Priority:

225+ case IndicatorsModelRole::Priority:

225226 return 0;

226− case Title:

227+ case IndicatorsModelRole::Title:

227228 return indicator ? indicator->identifier() : "Unknown";

228− case Description:

229+ case IndicatorsModelRole::Description:

229230 return "";

230− case WidgetSource:

231+ case IndicatorsModelRole::WidgetSource:

231232 return shellAppDirectory()+"/Panel/Indicators/DefaultIndicatorWidget.qml";

232− case PageSource:

233+ case IndicatorsModelRole::PageSource:

233234 return shellAppDirectory()+"/Panel/Indicators/DefaultIndicatorPage.qml";

234235 }

235236 return QVariant();

@@ -250,25 +251,25 @@ QVariant IndicatorsModel::data(const QModelIndex &index, int role) const

250251

251252 switch (role)

252253 {

253− case Identifier:

254+ case IndicatorsModelRole::Identifier:

254255 if (indicator)

255256 {

256257 return QVariant(indicator->identifier());

257258 }

258259 break;

259− case IndicatorProperties:

260+ case IndicatorsModelRole::IndicatorProperties:

260261 if (indicator)

261262 {

262263 return QVariant(indicator->indicatorProperties());

263264 }

264265 break;

265− case IsValid:

266+ case IndicatorsModelRole::IsValid:

266267 return (indicator ? true : false);

267− case Priority:

268− case Title:

269− case Description:

270− case WidgetSource:

271− case PageSource:

268+ case IndicatorsModelRole::Priority:

269+ case IndicatorsModelRole::Title:

270+ case IndicatorsModelRole::Description:

271+ case IndicatorsModelRole::WidgetSource:

272+ case IndicatorsModelRole::PageSource:

272273 return indicatorData(indicator, role);

273274 default:

274275 break;

modules/Unity/Indicators/indicatorsmodel.h−10

@@ -36,16 +36,6 @@ class IndicatorsModel : public QAbstractListModel

3636 Q_PROPERTY(QVariant indicatorData READ indicatorData WRITE setIndicatorData NOTIFY indicatorDataChanged)

3737

3838public:

39− enum Roles {

40− Identifier = 0,

41− Priority,

42− Title,

43− Description,

44− WidgetSource,

45− PageSource,

46− IndicatorProperties,

47− IsValid

48− };

4939

5040 IndicatorsModel(QObject *parent=0);

5141 ~IndicatorsModel();

modules/Unity/Indicators/plugin.cpp+3

@@ -35,7 +35,10 @@ void IndicatorsPlugin::registerTypes(const char *uri)

3535 qmlRegisterType<IndicatorsManager>(uri, 0, 1, "IndicatorsManager");

3636 qmlRegisterType<FlatMenuProxyModel>(uri, 0, 1, "FlatMenuProxyModel");

3737 qmlRegisterType<IndicatorsModel>(uri, 0, 1, "IndicatorsModel");

38+

3839 qmlRegisterUncreatableType<ActionState>(uri, 0, 1, "ActionState", "Can't create ActionState class");

3940 qmlRegisterUncreatableType<NetworkActionState>(uri, 0, 1, "NetworkActionState", "Can't create NetworkActionState class");

4041 qmlRegisterUncreatableType<NetworkConnection>(uri, 0, 1, "NetworkConnection", "Can't create NetworkConnection class");

42+ qmlRegisterUncreatableType<IndicatorsModelRole>(uri, 0, 1, "IndicatorsModelRole", "Can't create IndicatorsModelRole class");

43+ qmlRegisterUncreatableType<FlatMenuProxyModelRole>(uri, 0, 1, "FlatMenuProxyModelRole", "Can't create FlatMenuProxyModelRole class");

4144}

modules/Unity/Indicators/qml/IndicatorWidget.qml+2−2

@@ -46,7 +46,7 @@ IndicatorBase {

4646

4747

4848 function update_state() {

49− var extra = proxyModel.data(0, Indicators.FlatMenuProxyModel.Extra);

49+ var extra = proxyModel.data(0, Indicators.FlatMenuProxyModelRole.Extra);

5050 if (extra == undefined) {

5151 return;

5252 }

@@ -56,7 +56,7 @@ IndicatorBase {

5656 }

5757

5858 if (parseRootElement(extra.canonical_type)) {

59− action = actionGroup.action(proxyModel.data(0, Indicators.FlatMenuProxyModel.Action));

59+ action = actionGroup.action(proxyModel.data(0, Indicators.FlatMenuProxyModelRole.Action));

6060 }

6161 }

6262

tests/modules/Unity/Indicators/indicatorsmodeltest.cpp+13−12

@@ -18,6 +18,7 @@

1818 */

1919

2020#include "indicatorsmodel.h"

21+#include "indicators.h"

2122#include "paths.h"

2223

2324#include <QtTest>

@@ -78,21 +79,21 @@ private Q_SLOTS:

7879 model.setIndicatorData(map);

7980 model.load();

8081

81− QCOMPARE(model.data(0, IndicatorsModel::Identifier).toString(), QString("indicator-fake2"));

82− QCOMPARE(model.data(0, IndicatorsModel::Title).toString(), QString("fake2"));

83− QCOMPARE(model.data(0, IndicatorsModel::IndicatorProperties).toMap()["busName"].toString(), QString("com.canonical.indicator.fake2"));

82+ QCOMPARE(model.data(0, IndicatorsModelRole::Identifier).toString(), QString("indicator-fake2"));

83+ QCOMPARE(model.data(0, IndicatorsModelRole::Title).toString(), QString("fake2"));

84+ QCOMPARE(model.data(0, IndicatorsModelRole::IndicatorProperties).toMap()["busName"].toString(), QString("com.canonical.indicator.fake2"));

8485

85− QCOMPARE(model.data(1, IndicatorsModel::Identifier).toString(), QString("indicator-fake1"));

86− QCOMPARE(model.data(1, IndicatorsModel::Title).toString(), QString("fake1"));

87− QCOMPARE(model.data(1, IndicatorsModel::IndicatorProperties).toMap()["busName"].toString(), QString("com.canonical.indicator.fake1"));

86+ QCOMPARE(model.data(1, IndicatorsModelRole::Identifier).toString(), QString("indicator-fake1"));

87+ QCOMPARE(model.data(1, IndicatorsModelRole::Title).toString(), QString("fake1"));

88+ QCOMPARE(model.data(1, IndicatorsModelRole::IndicatorProperties).toMap()["busName"].toString(), QString("com.canonical.indicator.fake1"));

8889

89− QCOMPARE(model.data(2, IndicatorsModel::Identifier).toString(), QString("indicator-fake4"));

90− QCOMPARE(model.data(2, IndicatorsModel::Title).toString(), QString("fake4"));

91− QCOMPARE(model.data(2, IndicatorsModel::IndicatorProperties).toMap()["busName"].toString(), QString("com.canonical.indicator.fake4"));

90+ QCOMPARE(model.data(2, IndicatorsModelRole::Identifier).toString(), QString("indicator-fake4"));

91+ QCOMPARE(model.data(2, IndicatorsModelRole::Title).toString(), QString("fake4"));

92+ QCOMPARE(model.data(2, IndicatorsModelRole::IndicatorProperties).toMap()["busName"].toString(), QString("com.canonical.indicator.fake4"));

9293

93− QCOMPARE(model.data(3, IndicatorsModel::Identifier).toString(), QString("indicator-fake3"));

94− QCOMPARE(model.data(3, IndicatorsModel::Title).toString(), QString("fake3"));

95− QCOMPARE(model.data(3, IndicatorsModel::IndicatorProperties).toMap()["busName"].toString(), QString("com.canonical.indicator.fake3"));

94+ QCOMPARE(model.data(3, IndicatorsModelRole::Identifier).toString(), QString("indicator-fake3"));

95+ QCOMPARE(model.data(3, IndicatorsModelRole::Title).toString(), QString("fake3"));

96+ QCOMPARE(model.data(3, IndicatorsModelRole::IndicatorProperties).toMap()["busName"].toString(), QString("com.canonical.indicator.fake3"));

9697 }

9798};

9899

tests/qmltests/modules/Unity/Indicators/CMakeLists.txt+3−1

@@ -6,10 +6,12 @@ find_package(Qt5Quick REQUIRED)

66include_directories(

77 ${CMAKE_CURRENT_SOURCE_DIR}

88 ${CMAKE_CURRENT_BINARY_DIR}

9+ ${CMAKE_SOURCE_DIR}/modules/Unity/Indicators

910)

1011

1112set(IndicatorsFakeQml_SOURCES

12− plugin.cpp

13+ fakeplugin.cpp

14+ ${CMAKE_SOURCE_DIR}/modules/Unity/Indicators/indicators.h

1315)

1416

1517set(IndicatorsFakeQml_RESOURCES

tests/qmltests/modules/Unity/Indicators/IndicatorsModel.qml+28

@@ -15,6 +15,7 @@

1515 */

1616

1717import QtQuick 2.0

18+import Unity.Indicators 0.1 as Indicators

1819

1920ListModel {

2021

@@ -73,4 +74,31 @@ ListModel {

7374 isValid: "";

7475 }

7576

77+ function data(row, role) {

78+ if (role == Indicators.IndicatorsModelRole.Identifier) {

79+ return get(row).identifier;

80+ }

81+ else if (role == Indicators.IndicatorsModelRole.Priority) {

82+ return get(row).priority

83+ }

84+ else if (role == Indicators.IndicatorsModelRole.Title) {

85+ return get(row).title

86+ }

87+ else if (role == Indicators.IndicatorsModelRole.Description) {

88+ return get(row).description

89+ }

90+ else if (role == Indicators.IndicatorsModelRole.WidgetSource) {

91+ return get(row).widgetSource

92+ }

93+ else if (role == Indicators.IndicatorsModelRole.PageSource) {

94+ return get(row).pageSource

95+ }

96+ else if (role == Indicators.IndicatorsModelRole.IndicatorProperties) {

97+ return get(row).indicatorProperties

98+ }

99+ else if (role == Indicators.IndicatorsModelRole.IsValid) {

100+ return get(row).isValid

101+ }

102+ }

103+

76104}

tests/qmltests/modules/Unity/Indicators/plugin.cpp → tests/qmltests/modules/Unity/Indicators/fakeplugin.cpprenamed+9−2

@@ -20,11 +20,18 @@

2020#include <QtQml>

2121

2222// self

23−#include "plugin.h"

23+#include "fakeplugin.h"

2424

2525// local

26+#include "indicators.h"

2627

27−void IndicatorsFakePlugin::registerTypes(const char *)

28+void IndicatorsFakePlugin::registerTypes(const char * uri)

2829{

2930 Q_INIT_RESOURCE(indicators_fake);

31+

32+ qmlRegisterUncreatableType<ActionState>(uri, 0, 1, "ActionState", "Can't create ActionState class");

33+ qmlRegisterUncreatableType<NetworkActionState>(uri, 0, 1, "NetworkActionState", "Can't create NetworkActionState class");

34+ qmlRegisterUncreatableType<NetworkConnection>(uri, 0, 1, "NetworkConnection", "Can't create NetworkConnection class");

35+ qmlRegisterUncreatableType<IndicatorsModelRole>(uri, 0, 1, "IndicatorsModelRole", "Can't create IndicatorsModelRole class");

36+ qmlRegisterUncreatableType<FlatMenuProxyModelRole>(uri, 0, 1, "FlatMenuProxyModelRole", "Can't create FlatMenuProxyModelRole class");

3037}

tests/qmltests/modules/Unity/Indicators/plugin.h → tests/qmltests/modules/Unity/Indicators/fakeplugin.hrenamed

The content is the same.