git.iko.soy/unity8
on xenial help sign in
add a test to drag vertically only to trigger this codepath in the test
c1e34fdMichael Zanetti
tests/qmltests/Launcher/tst_Launcher.qml+39−13
compare with xenial
unifiedsplit
@@ -261,8 +261,9 @@ Item {
261
261
262 function test_dragndrop_data() {
262 function test_dragndrop_data() {
263 return [
263 return [
264− {tag: "startDrag", fullDrag: false},
264+ {tag: "startDrag", fullDrag: false },
265+ {tag: "fullDrag horizontal", fullDrag: true, orientation: ListView.Horizontal },
265− {tag: "fullDrag", fullDrag: true},
266+ {tag: "fullDrag vertical", fullDrag: true, orientation: ListView.Vertical },
266 ];
267 ];
267 }
268 }
268
269
@@ -272,8 +273,8 @@ Item {
272 var item0 = findChild(launcher, "launcherDelegate0")
273 var item0 = findChild(launcher, "launcherDelegate0")
273 var fakeDragItem = findChild(launcher, "fakeDragItem")
274 var fakeDragItem = findChild(launcher, "fakeDragItem")
274 var initialItemHeight = draggedItem.height
275 var initialItemHeight = draggedItem.height
275− var item5Name = LauncherModel.get(5).iconName
276+ var item5 = LauncherModel.get(5).appId
276− var item4Name = LauncherModel.get(4).iconName
277+ var item4 = LauncherModel.get(4).appId
277
278
278 // Initial state
279 // Initial state
279 compare(draggedItem.itemOpacity, 1, "Item's opacity is not 1 at beginning")
280 compare(draggedItem.itemOpacity, 1, "Item's opacity is not 1 at beginning")
@@ -281,28 +282,49 @@ Item {
281 tryCompare(findChild(draggedItem, "dropIndicator"), "opacity", 0)
282 tryCompare(findChild(draggedItem, "dropIndicator"), "opacity", 0)
282
283
283 // Doing longpress
284 // Doing longpress
285+ var currentMouseX = draggedItem.width / 2
284− mousePress(draggedItem, draggedItem.width / 2, draggedItem.height / 2)
286+ var currentMouseY = draggedItem.height / 2
287+ mousePress(draggedItem, currentMouseX, currentMouseY)
285 // DraggedItem needs to hide and fakeDragItem become visible
288 // DraggedItem needs to hide and fakeDragItem become visible
286 tryCompare(draggedItem, "itemOpacity", 0)
289 tryCompare(draggedItem, "itemOpacity", 0)
287 tryCompare(fakeDragItem, "visible", true)
290 tryCompare(fakeDragItem, "visible", true)
288
291
289 // Dragging a bit (> 1.5 gu)
292 // Dragging a bit (> 1.5 gu)
290− mouseMove(draggedItem, -units.gu(2), draggedItem.height / 2)
293+ currentMouseX -= units.gu(2)
294+ mouseMove(draggedItem, currentMouseX, currentMouseY)
291 // Other items need to expand and become 0.6 opaque
295 // Other items need to expand and become 0.6 opaque
292 tryCompare(item0, "angle", 0)
296 tryCompare(item0, "angle", 0)
293 tryCompare(item0, "itemOpacity", 0.6)
297 tryCompare(item0, "itemOpacity", 0.6)
294
298
295 if (data.fullDrag) {
299 if (data.fullDrag) {
296 // Dragging a bit more
300 // Dragging a bit more
301+ if (data.orientation == ListView.Horizontal) {
302+ currentMouseX -= units.gu(15)
303+ mouseMove(draggedItem, currentMouseX, currentMouseY, 100)
304+
305+ tryCompare(findChild(draggedItem, "dropIndicator"), "opacity", 1)
297− mouseMove(draggedItem, -units.gu(15), draggedItem.height / 2, 100)
306+ tryCompare(draggedItem, "height", units.gu(1))
307+
308+ // Dragging downwards. Item needs to move in the model
309+ currentMouseY -= initialItemHeight * 1.5
310+ mouseMove(draggedItem, currentMouseX, currentMouseY)
311+ } else if (data.orientation == ListView.Vertical) {
312+ currentMouseY -= initialItemHeight * 1.5
313+ mouseMove(draggedItem, currentMouseX, currentMouseY, 100)
314+
298− tryCompare(findChild(draggedItem, "dropIndicator"), "opacity", 1)
315+ tryCompare(findChild(draggedItem, "dropIndicator"), "opacity", 1)
299− tryCompare(draggedItem, "height", units.gu(1))
316+ tryCompare(draggedItem, "height", units.gu(1))
317+ }
300
318
301− // Dragging downwards. Item needs to move in the model
302− mouseMove(draggedItem, -units.gu(15), -initialItemHeight)
303 waitForRendering(draggedItem)
319 waitForRendering(draggedItem)
320+ print("item4 name", LauncherModel.get(4), LauncherModel.get(4).appId)
321+ print("item5 name", LauncherModel.get(5), LauncherModel.get(5).appId)
322+ print("item6 name", LauncherModel.get(6), LauncherModel.get(6).appId)
323+// tryCompareFunction(function() { LauncherModel.get(appId;}, 0);
324+ wait(200)
325+
304− compare(LauncherModel.get(5).iconName, item4Name)
326+ compare(LauncherModel.get(5).appId, item4)
305− compare(LauncherModel.get(5).iconName, item5Name)
327+ compare(LauncherModel.get(4).appId, item5)
306 }
328 }
307
329
308 // Releasing and checking if initial values are restored
330 // Releasing and checking if initial values are restored
@@ -310,6 +332,10 @@ Item {
310 tryCompare(findChild(draggedItem, "dropIndicator"), "opacity", 0)
332 tryCompare(findChild(draggedItem, "dropIndicator"), "opacity", 0)
311 tryCompare(draggedItem, "itemOpacity", 1)
333 tryCompare(draggedItem, "itemOpacity", 1)
312 tryCompare(fakeDragItem, "visible", false)
334 tryCompare(fakeDragItem, "visible", false)
335+
336+ // Click somewhere in the empty space to make it hide in case it isn't
337+ mouseClick(launcher, launcher.width - units.gu(1), units.gu(1));
338+ revealer.waitUntilLauncherDisappears();
313 }
339 }
314
340
315 function test_quicklist_dismiss() {
341 function test_quicklist_dismiss() {