on xenial help sign in
[TLWM] fix activating top most window

TLWM will activate the top most window if a window without a surface (i.e. placeholder) is requested to be closed. However, when it found the applicable window, it forgot to break after activating it. The result is every windows got activated. This commit add the missing break. This is supposed to fix the issue with closing very early window while its surface hasn't attached. However, there seems to be another race going on that prevents it to be fixed. Still, this fix is pretty obvious and may solve some other issue.

commitc2ffdb9ec4fdb6726902f0aae6c0adfdad11eaa0 authorRatchanan Srirattanamet <ratchanan@ubports.com> dateThu 19 Dec 2019, 21:27 (7 years ago) parent694e8a4
1 file changed+1
plugins/WindowManager/TopLevelWindowModel.cpp+1
plugins/WindowManager/TopLevelWindowModel.cpp+1
@@ -736,6 +736,7 @@ void TopLevelWindowModel::activateTopMostWindowWithoutId(int forbiddenId)
736736 Window *window = m_windowModel[i].window;
737737 if (window->id() != forbiddenId) {
738738 window->activate();
739+ break;
739740 }
740741 }
741742}