git.iko.soy/unity8
on xenial help sign in
Small catches from review
c43d2e3Albert Astals
qml/Dash/ScopesOverview.qml+8−9
compare with xenial
unifiedsplit
@@ -219,14 +219,14 @@ Item {
219 if (index == 0) {
219 if (index == 0) {
220 return root.height;
220 return root.height;
221 } else {
221 } else {
222− return root.height - pageHeader.height - tabBar.height - tabBar.anchors.margins - units.gu(2)
222+ return root.height - pageHeader.height - tabBar.height - tabBar.anchors.margins - units.gu(2);
223 }
223 }
224 }
224 }
225 width: {
225 width: {
226 if (index == 0) {
226 if (index == 0) {
227− return root.width / scopeScale
227+ return root.width / scopeScale;
228 } else {
228 } else {
229− return root.width
229+ return root.width;
230 }
230 }
231 }
231 }
232 x: {
232 x: {
@@ -275,7 +275,7 @@ Item {
275 }
275 }
276
276
277 onLoaded: {
277 onLoaded: {
278− item.model = Qt.binding(function() { return results })
278+ item.model = Qt.binding(function() { return results; });
279 item.cardTool = cardTool;
279 item.cardTool = cardTool;
280 if (index == 0) {
280 if (index == 0) {
281 item.scopeWidth = Qt.binding(function() { return root.width; });
281 item.scopeWidth = Qt.binding(function() { return root.width; });
@@ -291,7 +291,7 @@ Item {
291 target: loader.item
291 target: loader.item
292 onClicked: {
292 onClicked: {
293 if (tabBar.currentTab == 0) {
293 if (tabBar.currentTab == 0) {
294− root.favoriteSelected(itemModel.scopeId)
294+ root.favoriteSelected(itemModel.scopeId);
295 } else {
295 } else {
296 var favoriteScopesItem = middleItems.itemAt(0).item;
296 var favoriteScopesItem = middleItems.itemAt(0).item;
297 var scopeIndex = favoriteScopesItem.model.scopeIndex(itemModel.scopeId);
297 var scopeIndex = favoriteScopesItem.model.scopeIndex(itemModel.scopeId);
@@ -311,9 +311,9 @@ Item {
311 scopesOverviewXYScaler.restoreSize = allCardSize;
311 scopesOverviewXYScaler.restoreSize = allCardSize;
312
312
313 previewListView.model = target.model;
313 previewListView.model = target.model;
314− previewListView.currentIndex = -1
314+ previewListView.currentIndex = -1;
315 previewListView.currentIndex = index;
315 previewListView.currentIndex = index;
316− previewListView.open = true
316+ previewListView.open = true;
317 }
317 }
318 }
318 }
319 }
319 }
@@ -482,8 +482,7 @@ Item {
482 }
482 }
483 }
483 }
484
484
485− DashBackground
485+ DashBackground {
486− {
487 anchors.fill: tempScopeItem
486 anchors.fill: tempScopeItem
488 visible: tempScopeItem.visible
487 visible: tempScopeItem.visible
489 parent: tempScopeItem.parent
488 parent: tempScopeItem.parent