on xenial help sign in
resolved conflict
commitc49158af83ac4db95fd56f0b9dc51598b933a08a authorNick Dedekind <nick.dedekind@canonical.com> dateWed 16 Mar 2016, 11:49 (11 years ago) parent09e52a16f68562
20 files changed+43−107
CMakeLists.txt+1−1 debian/changelog−6 qml/Wizard/CheckableSetting.qml+1−1 qml/Wizard/Page.qml+2−1 qml/Wizard/Pages/10-welcome.qml+1−1 qml/Wizard/Pages/30-wifi.qml+1−1 qml/Wizard/Pages/40-location.qml+1−1 qml/Wizard/Pages/50-timezone.qml+1−1 qml/Wizard/Pages/70-passwd-type.qml+1−1 qml/Wizard/Pages/75-report-check.qml+1−1 qml/Wizard/Pages/80-finished.qml+1−1 qml/Wizard/Pages/here-terms.qml+1−1 qml/Wizard/Pages/passcode-confirm.qml+1−1 qml/Wizard/Pages/passcode-desktop.qml+1−1 qml/Wizard/Pages/passcode-set.qml+1−1 qml/Wizard/Pages/password-set.qml+1−1 qml/Wizard/Pages/sim.qml+1−1 qml/Wizard/StackButton.qml+1−1 qml/Wizard/WizardTextField.qml+1−1 tests/qmltests/Wizard/tst_Wizard.qml+24−83
CMakeLists.txt+1−1
@@ -58,7 +58,7 @@ find_package(Qt5Concurrent 5.4 REQUIRED)
5858find_package(Qt5Sql 5.4 REQUIRED)
5959
6060pkg_check_modules(APPLICATION_API REQUIRED unity-shell-application=14)
61−pkg_check_modules(GEONAMES REQUIRED geonames)
61+pkg_check_modules(GEONAMES REQUIRED geonames>=0.2)
6262pkg_check_modules(GIO REQUIRED gio-2.0>=2.32)
6363pkg_check_modules(GLIB REQUIRED glib-2.0>=2.32)
6464pkg_check_modules(QMENUMODEL REQUIRED qmenumodel)
debian/changelog−6
@@ -1,9 +1,3 @@
1−unity8 (8.13+15.04.20150914-0ubuntu1) UNRELEASED; urgency=medium
2−
3− * bump version to fix OOBE build
4−
5− -- Lukas Tinkl <ltinkl@canonical.com> Mon, 14 Sep 2015 19:19:23 +0200
6−
71unity8 (8.11+16.04.20160310.4-0ubuntu1) xenial; urgency=medium
82
93 [ Albert Astals Cid ]
qml/Wizard/CheckableSetting.qml+1−1
@@ -1,5 +1,5 @@
11/*
2− * Copyright (C) 2014,2015 Canonical, Ltd.
2+ * Copyright (C) 2014-2016 Canonical, Ltd.
33 *
44 * This program is free software; you can redistribute it and/or modify
55 * it under the terms of the GNU General Public License as published by
qml/Wizard/Page.qml+2−1
@@ -264,6 +264,7 @@ Item {
264264
265265 SequentialAnimation { // animations for the content
266266 id: contentAnimation
267+ objectName: "contentAnimation"
267268 property int animationDurationBase: UbuntuAnimation.BriskDuration
268269 readonly property int additionalDuration: 200
269270 property int direction: Qt.LeftToRight
@@ -296,7 +297,7 @@ Item {
296297
297298 ParallelAnimation { // animation for the secondary pages
298299 id: secondaryAnimation
299−
300+ objectName: "secondaryAnimation"
300301 NumberAnimation { // the slide-up animation
301302 target: titleLabel
302303 property: 'animatedTopMargin'
qml/Wizard/Pages/10-welcome.qml+1−1
@@ -1,5 +1,5 @@
11/*
2− * Copyright (C) 2013-2015 Canonical, Ltd.
2+ * Copyright (C) 2013-2016 Canonical, Ltd.
33 *
44 * This program is free software; you can redistribute it and/or modify
55 * it under the terms of the GNU General Public License as published by
qml/Wizard/Pages/30-wifi.qml+1−1
@@ -1,5 +1,5 @@
11/*
2− * Copyright (C) 2013, 2015 Canonical, Ltd.
2+ * Copyright (C) 2013-2016 Canonical, Ltd.
33 *
44 * This program is free software; you can redistribute it and/or modify
55 * it under the terms of the GNU General Public License as published by
qml/Wizard/Pages/40-location.qml+1−1
@@ -1,5 +1,5 @@
11/*
2− * Copyright (C) 2013-2015 Canonical, Ltd.
2+ * Copyright (C) 2013-2016 Canonical, Ltd.
33 *
44 * This program is free software; you can redistribute it and/or modify
55 * it under the terms of the GNU General Public License as published by
qml/Wizard/Pages/50-timezone.qml+1−1
@@ -1,5 +1,5 @@
11/*
2− * Copyright (C) 2015 Canonical, Ltd.
2+ * Copyright (C) 2015-2016 Canonical, Ltd.
33 *
44 * This program is free software; you can redistribute it and/or modify
55 * it under the terms of the GNU General Public License as published by
qml/Wizard/Pages/70-passwd-type.qml+1−1
@@ -1,5 +1,5 @@
11/*
2− * Copyright (C) 2014-2015 Canonical, Ltd.
2+ * Copyright (C) 2014-2016 Canonical, Ltd.
33 *
44 * This program is free software; you can redistribute it and/or modify
55 * it under the terms of the GNU General Public License as published by
qml/Wizard/Pages/75-report-check.qml+1−1
@@ -1,5 +1,5 @@
11/*
2− * Copyright (C) 2015 Canonical, Ltd.
2+ * Copyright (C) 2015-2016 Canonical, Ltd.
33 *
44 * This program is free software; you can redistribute it and/or modify
55 * it under the terms of the GNU General Public License as published by
qml/Wizard/Pages/80-finished.qml+1−1
@@ -1,5 +1,5 @@
11/*
2− * Copyright (C) 2013-2015 Canonical, Ltd.
2+ * Copyright (C) 2013-2016 Canonical, Ltd.
33 *
44 * This program is free software; you can redistribute it and/or modify
55 * it under the terms of the GNU General Public License as published by
qml/Wizard/Pages/here-terms.qml+1−1
@@ -1,5 +1,5 @@
11/*
2− * Copyright (C) 2014,2015 Canonical, Ltd.
2+ * Copyright (C) 2014-2016 Canonical, Ltd.
33 *
44 * This program is free software; you can redistribute it and/or modify
55 * it under the terms of the GNU General Public License as published by
qml/Wizard/Pages/passcode-confirm.qml+1−1
@@ -1,5 +1,5 @@
11/*
2− * Copyright (C) 2014 Canonical, Ltd.
2+ * Copyright (C) 2014-2016 Canonical, Ltd.
33 *
44 * This program is free software; you can redistribute it and/or modify
55 * it under the terms of the GNU General Public License as published by
qml/Wizard/Pages/passcode-desktop.qml+1−1
@@ -1,5 +1,5 @@
11/*
2− * Copyright (C) 2015 Canonical, Ltd.
2+ * Copyright (C) 2015-2016 Canonical, Ltd.
33 *
44 * This program is free software; you can redistribute it and/or modify
55 * it under the terms of the GNU General Public License as published by
qml/Wizard/Pages/passcode-set.qml+1−1
@@ -1,5 +1,5 @@
11/*
2− * Copyright (C) 2014 Canonical, Ltd.
2+ * Copyright (C) 2014-2016 Canonical, Ltd.
33 *
44 * This program is free software; you can redistribute it and/or modify
55 * it under the terms of the GNU General Public License as published by
qml/Wizard/Pages/password-set.qml+1−1
@@ -1,5 +1,5 @@
11/*
2− * Copyright (C) 2015 Canonical, Ltd.
2+ * Copyright (C) 2015-2016 Canonical, Ltd.
33 *
44 * This program is free software; you can redistribute it and/or modify
55 * it under the terms of the GNU General Public License as published by
qml/Wizard/Pages/sim.qml+1−1
@@ -1,5 +1,5 @@
11/*
2− * Copyright (C) 2013-2015 Canonical, Ltd.
2+ * Copyright (C) 2013-2016 Canonical, Ltd.
33 *
44 * This program is free software; you can redistribute it and/or modify
55 * it under the terms of the GNU General Public License as published by
qml/Wizard/StackButton.qml+1−1
@@ -1,5 +1,5 @@
11/*
2− * Copyright (C) 2014,2015 Canonical, Ltd.
2+ * Copyright (C) 2014-2016 Canonical, Ltd.
33 *
44 * This program is free software; you can redistribute it and/or modify
55 * it under the terms of the GNU General Public License as published by
qml/Wizard/WizardTextField.qml+1−1
@@ -1,5 +1,5 @@
11/*
2− * Copyright (C) 2015 Canonical, Ltd.
2+ * Copyright (C) 2015-2016 Canonical, Ltd.
33 *
44 * This program is free software; you can redistribute it and/or modify
55 * it under the terms of the GNU General Public License as published by
tests/qmltests/Wizard/tst_Wizard.qml+24−83
@@ -102,7 +102,6 @@ Item {
102102 }
103103
104104 Component.onCompleted: {
105− theme.name = "Ubuntu.Components.Themes.SuruDark";
106105 setup();
107106 }
108107
@@ -208,13 +207,6 @@ Item {
208207 if (name === page.objectName) return page;
209208 tap(findChild(page, "nameInput"));
210209 typeString("foobar");
211− tap(findChild(page, "passInput"));
212− typeString("12345678");
213− var pass2Input = findChild(page, "pass2Input");
214− // give it a bit of time to finish the scroll-into-view animation
215− tryCompareFunction(function() { return pass2Input !== null; }, true);
216− tap(pass2Input);
217− typeString("12345678");
218210 tap(findChild(page, "forwardButton"));
219211
220212 page = waitForPage("passwdPage");
@@ -300,21 +292,31 @@ Item {
300292 waitForPage("wifiPage"); // thus skipping passwdPage
301293 }
302294
295+ function verifyAnimationsNotRunning(page) {
296+ var contentAnimation = findInvisibleChild(page, "contentAnimation");
297+ var secondaryAnimation = findInvisibleChild(page, "secondaryAnimation");
298+ tryCompare(contentAnimation, "running", false);
299+ tryCompare(secondaryAnimation, "running", false);
300+ }
301+
303302 function test_passwdPasscode() {
304303 var page = goToPage("passwdPage");
305− tap(findChild(page, "passwdDelegate2")); // passcode option
304+ tap(findChild(page, "passwdDelegate1")); // passcode option
306305 tap(findChild(page, "forwardButton"));
307306 page = waitForPage("passcodeSetPage");
307+ verifyAnimationsNotRunning(page);
308308
309309 enterPasscode("1111");
310310 page = waitForPage("passcodeConfirmPage");
311+ verifyAnimationsNotRunning(page);
311312
312− // make sure we go back to 'set' page not 'type' page
313313 tap(findChild(page, "backButton"));
314314 page = waitForPage("passcodeSetPage");
315+ verifyAnimationsNotRunning(page);
315316
316317 enterPasscode("1111");
317318 page = waitForPage("passcodeConfirmPage");
319+ verifyAnimationsNotRunning(page);
318320
319321 enterPasscode("1112");
320322 var error = findChild(page, "wrongNoticeLabel");
@@ -337,47 +339,29 @@ Item {
337339
338340 function test_passwdPassphrase() {
339341 var page = goToPage("passwdPage");
340− tap(findChild(page, "passwdDelegate1")); // password option
342+ tap(findChild(page, "passwdDelegate0")); // password option
341343 tap(findChild(page, "forwardButton"));
342344 page = waitForPage("passwdSetPage");
343345
344346 var passwdField = findChild(page, "passwordField");
345347 verify(passwdField);
346348 tap(passwdField);
349+ waitUntilTransitionsEnd(passwdField);
347350 typeString("aaa");
348− var continueButton = findChild(page, "okButton");
349− tryCompare(continueButton, "enabled", false);
351+ var continueButton = findChild(page, "forwardButton");
352+ tryCompare(page, "passwordsMatching", false);
350353
351354 tap(passwdField);
355+ waitUntilTransitionsEnd(passwdField);
352356 passwdField.selectAll(); // overwrite the text
353357 typeString("12345678");
354− tap(continueButton);
355− wait(200);
356−
357− // make sure we go back to 'set' page not 'type' page
358− var back = findChild(page, "cancelButton");
359− tap(back);
360− wait(200);
358+ tryCompare(page, "passwordsMatching", false);
361359
362− passwdField = findChild(page, "passwordField");
363− tryCompareFunction(function() {return !!passwdField}, true);
364− tap(passwdField);
365− typeString("aaab");
366−
367− continueButton = findChild(page, "okButton");
368− tryCompare(continueButton, "enabled", false);
369− var error = findChild(page, "infoLabel");
370− tryCompareFunction(function() { return error.text !== ""; }, true);
371−
372− tap(passwdField);
373− passwdField.selectAll(); // overwrite the text
374− typeString("12345678");
375− tap(continueButton);
376− wait(200);
377−
378− tap(passwdField);
379− passwdField.selectAll(); // overwrite the text
360+ var passwd2Field = findChild(page, "password2Field");
361+ tap(passwd2Field);
362+ waitUntilTransitionsEnd(passwd2Field);
380363 typeString("12345678");
364+ tryCompare(continueButton, "enabled", true);
381365 tap(continueButton);
382366
383367 // now finish up
@@ -395,7 +379,7 @@ Item {
395379
396380 function test_passwdSwipe() {
397381 var page = goToPage("passwdPage");
398− tap(findChild(page, "passwdDelegate3")); // swipe option
382+ tap(findChild(page, "passwdDelegate2")); // swipe option
399383
400384 // now finish up
401385 tap(findChild(page, "forwardButton"));
@@ -405,10 +389,7 @@ Item {
405389 waitUntilTransitionsEnd(page);
406390 tap(findChild(page, "finishButton"));
407391
408− tryCompare(setSecuritySpy, "count", 1);
409− //compare(setSecuritySpy.signalArguments[0][0], ""); // FIXME the swipe method collides with the account password
410− //compare(setSecuritySpy.signalArguments[0][1], "");
411− compare(setSecuritySpy.signalArguments[0][2], UbuntuSecurityPrivacyPanel.Swipe);
392+ tryCompare(setSecuritySpy, "count", 0); // not called for swipe method
412393 }
413394
414395 function test_locationGpsOnly() {
@@ -501,50 +482,10 @@ Item {
501482
502483 function test_accountPage() {
503484 var page = goToPage("accountPage");
504− var password1 = findChild(page, "passInput");
505− var password2 = findChild(page, "pass2Input");
506485 var forwardButton = findChild(page, "forwardButton");
507486
508487 tap(findChild(page, "nameInput"));
509488 typeString("foobar");
510−
511− verify(forwardButton.enabled, false); // no passwords yet
512−
513− tap(password1);
514− typeString("12345");
515−
516− verify(forwardButton.enabled, false); // password too short
517−
518− tap(password2);
519− typeString("12345678");
520−
521− verify(forwardButton.enabled, false); // passwords don't match
522−
523− tap(password1);
524− password1.selectAll();
525− typeString("12345678");
526−
527− verify(forwardButton.enabled, true); // now they match
528−
529− var pages = findChild(wizard, "wizardPages");
530− var security = findInvisibleChild(pages, "securityPrivacy");
531− setSecuritySpy.target = security;
532−
533− // now finish up
534− tap(forwardButton);
535− page = waitForPage("passwdPage");
536− tap(findChild(page, "passwdDelegate0")); // account option
537− tap(findChild(page, "forwardButton"));
538− page = waitForPage("reportingPage");
539− tap(findChild(page, "forwardButton"));
540− page = waitForPage("finishedPage");
541− waitUntilTransitionsEnd(page);
542− tap(findChild(page, "finishButton"));
543−
544− tryCompare(setSecuritySpy, "count", 1);
545− compare(setSecuritySpy.signalArguments[0][0], "");
546− compare(setSecuritySpy.signalArguments[0][1], "12345678");
547− compare(setSecuritySpy.signalArguments[0][2], UbuntuSecurityPrivacyPanel.Passphrase);
548489 }
549490 }
550491}