git.iko.soy/unity8
on xenial help sign in
Rename mock phone-app to dialer-app, to match modern usage and this branch's hard-coding of the name for the dialer
commitd4c4cb1033e367948c9dc928f9f0ef798155a35d authorMichael Terry <michael.terry@canonical.com> dateMon 30 Jun 2014, 14:12 (12 years ago) parenta668bad
8 files changed+13−13
compare with xenial
unifiedsplit
qml/Dash/graphics/phone/screenshots/phone@12.png → qml/Dash/graphics/phone/screenshots/dialer@12.png qml/graphics/applicationIcons/phone-app@18.png → qml/graphics/applicationIcons/dialer-app@18.png tests/autopilot/unity8/shell/tests/test_notifications.py+4−4 tests/mocks/Unity/Application/ApplicationManager.cpp+3−3 tests/mocks/Unity/Launcher/MockLauncherModel.cpp+1−1 tests/qmltests/Dash/Apps/tst_RunningApplicationsGrid.qml+2−2 tests/qmltests/Launcher/tst_Launcher.qml+2−2 tests/qmltests/Notifications/tst_VisualSnapDecisionsQueue.qml+1−1
qml/Dash/graphics/phone/screenshots/phone@12.png → qml/Dash/graphics/phone/screenshots/dialer@12.pngrenamed

Binary file not shown.

qml/graphics/applicationIcons/phone-app@18.png → qml/graphics/applicationIcons/dialer-app@18.pngrenamed

Binary file not shown.

tests/autopilot/unity8/shell/tests/test_notifications.py+4−4
@@ -137,7 +137,7 @@ class InteractiveNotificationBase(NotificationsBase):
137137 ("x-canonical-switch-to-application", "true"),
138138 (
139139 "x-canonical-secondary-icon",
140− self._get_icon_path('applicationIcons/phone-app.png')
140+ self._get_icon_path('applicationIcons/dialer-app.png')
141141 )
142142 ]
143143
@@ -172,7 +172,7 @@ class InteractiveNotificationBase(NotificationsBase):
172172 hints = [
173173 (
174174 "x-canonical-secondary-icon",
175− self._get_icon_path('applicationIcons/phone-app.png')
175+ self._get_icon_path('applicationIcons/dialer-app.png')
176176 ),
177177 ("x-canonical-snap-decisions", "true"),
178178 ]
@@ -435,7 +435,7 @@ class EphemeralNotificationsTests(NotificationsBase):
435435 hints = [
436436 (
437437 "x-canonical-secondary-icon",
438− self._get_icon_path('applicationIcons/phone-app.png')
438+ self._get_icon_path('applicationIcons/dialer-app.png')
439439 )
440440 ]
441441
@@ -677,7 +677,7 @@ class EphemeralNotificationsTests(NotificationsBase):
677677 body = 'This bubble uses the icon-title-body layout with a ' \
678678 'secondary icon.'
679679 icon_path = self._get_icon_path('avatars/anna_olsson.png')
680− hint_icon = self._get_icon_path('applicationIcons/phone-app.png')
680+ hint_icon = self._get_icon_path('applicationIcons/dialer-app.png')
681681
682682 notification = shell.create_ephemeral_notification(
683683 summary,
tests/mocks/Unity/Application/ApplicationManager.cpp+3−3
@@ -361,9 +361,9 @@ void ApplicationManager::buildListOfAvailableApplications()
361361 ApplicationInfo *application;
362362
363363 application = new ApplicationInfo(this);
364− application->setAppId("phone-app");
365− application->setName("Phone");
366− application->setIcon(QUrl("phone"));
364+ application->setAppId("dialer-app");
365+ application->setName("Dialer");
366+ application->setIcon(QUrl("dialer"));
367367 application->setStage(ApplicationInfo::SideStage);
368368 application->setScreenshot(QString("image://application/%1/%2").arg(application->appId()).arg(QDateTime::currentMSecsSinceEpoch()));
369369 generateQmlStrings(application);
tests/mocks/Unity/Launcher/MockLauncherModel.cpp+1−1
@@ -22,7 +22,7 @@
2222
2323MockLauncherModel::MockLauncherModel(QObject* parent): LauncherModelInterface(parent)
2424{
25− MockLauncherItem *item = new MockLauncherItem("phone-app", "/usr/share/applications/phone-app.desktop", "Phone", "phone-app", this);
25+ MockLauncherItem *item = new MockLauncherItem("dialer-app", "/usr/share/applications/dialer-app.desktop", "Dialer", "dialer-app", this);
2626 item->setProgress(0);
2727 m_list.append(item);
2828 item->setFocused(true);
tests/qmltests/Dash/Apps/tst_RunningApplicationsGrid.qml+2−2
@@ -30,7 +30,7 @@ Rectangle {
3030 ApplicationManager.stopApplication(ApplicationManager.get(0).appId)
3131 }
3232
33− ApplicationManager.startApplication("phone-app");
33+ ApplicationManager.startApplication("dialer-app");
3434 ApplicationManager.startApplication("webbrowser-app");
3535 }
3636
@@ -70,7 +70,7 @@ Rectangle {
7070 verify(browserTile != undefined)
7171 browserTile.onPressAndHold.connect(onBrowserLongPressed)
7272
73− phoneTile = findChild(runningApplicationsGrid, "runningAppTile Phone")
73+ phoneTile = findChild(runningApplicationsGrid, "runningAppTile Dialer")
7474 verify(phoneTile != undefined)
7575 phoneTile.onPressAndHold.connect(onPhoneLongPressed)
7676
tests/qmltests/Launcher/tst_Launcher.qml+2−2
@@ -115,7 +115,7 @@ Item {
115115 /* If I click on the icon of an application on the launcher
116116 Launcher::launcherApplicationSelected signal should be emitted with the
117117 corresponding desktop file. E.g. clicking on phone icon should yield
118− launcherApplicationSelected("[...]phone-app.desktop") */
118+ launcherApplicationSelected("[...]dialer-app.desktop") */
119119 function test_clickingOnAppIconCausesSignalEmission() {
120120 launcher.lastSelectedApplication = ""
121121
@@ -131,7 +131,7 @@ Item {
131131 mouseClick(appIcon, appIcon.width/2, appIcon.height/2)
132132
133133 tryCompare(launcher, "lastSelectedApplication",
134− "phone-app")
134+ "dialer-app")
135135
136136 // Tapping on an application icon also dismisses the launcher
137137 revealer.waitUntilLauncherDisappears()
tests/qmltests/Notifications/tst_VisualSnapDecisionsQueue.qml+1−1
@@ -67,7 +67,7 @@ Row {
6767 summary: "Incoming call",
6868 body: "Frank Zappa\n+44 (0)7736 027340",
6969 icon: "../graphics/avatars/funky.png",
70− secondaryIcon: "../graphics/applicationIcons/phone-app.png",
70+ secondaryIcon: "../graphics/applicationIcons/dialer-app.png",
7171 actions: [{ id: "pickup_id", label: "Pick up"},
7272 { id: "decline_1_id", label: "Decline"},
7373 { id: "decline_2_id", label: "Can't talk now, what's up?"},