git.iko.soy/unity8
on xenial help sign in
MediaPlayerMenu.running -> showTrack
commitd82176e590cdf537dc81cdbe3ba7d8bcad5507d4 authorNick Dedekind <nick.dedekind@canonical.com> dateWed 24 Sep 2014, 11:00 (12 years ago) parente8da8d1
3 files changed+30−12
compare with xenial
unifiedsplit
po/unity8.pot+11−7 qml/Panel/Indicators/MenuItemFactory.qml+3−2 tests/qmltests/Panel/Indicators/tst_MenuItemFactory.qml+16−3
po/unity8.pot+11−7
@@ -8,7 +8,7 @@ msgid ""
88msgstr ""
99"Project-Id-Version: unity8\n"
1010"Report-Msgid-Bugs-To: \n"
11−"POT-Creation-Date: 2014-09-19 16:30+0100\n"
11+"POT-Creation-Date: 2014-09-24 10:43+0100\n"
1212"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
1313"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
1414"Language-Team: LANGUAGE <LL@li.org>\n"
@@ -266,27 +266,31 @@ msgstr ""
266266msgid "Conference"
267267msgstr ""
268268
269−#: qml/Panel/Indicators/MenuItemFactory.qml:747
269+#: qml/Panel/Indicators/MenuItemFactory.qml:600
270+msgid "Nothing is playing"
271+msgstr ""
272+
273+#: qml/Panel/Indicators/MenuItemFactory.qml:748
270274msgid "In queue…"
271275msgstr ""
272276
273−#: qml/Panel/Indicators/MenuItemFactory.qml:751
277+#: qml/Panel/Indicators/MenuItemFactory.qml:752
274278msgid "Downloading"
275279msgstr ""
276280
277−#: qml/Panel/Indicators/MenuItemFactory.qml:753
281+#: qml/Panel/Indicators/MenuItemFactory.qml:754
278282msgid "Paused, tap to resume"
279283msgstr ""
280284
281−#: qml/Panel/Indicators/MenuItemFactory.qml:755
285+#: qml/Panel/Indicators/MenuItemFactory.qml:756
282286msgid "Canceled"
283287msgstr ""
284288
285−#: qml/Panel/Indicators/MenuItemFactory.qml:757
289+#: qml/Panel/Indicators/MenuItemFactory.qml:758
286290msgid "Finished"
287291msgstr ""
288292
289−#: qml/Panel/Indicators/MenuItemFactory.qml:759
293+#: qml/Panel/Indicators/MenuItemFactory.qml:760
290294msgid "Failed, tap to retry"
291295msgstr ""
292296
qml/Panel/Indicators/MenuItemFactory.qml+3−2
@@ -594,15 +594,16 @@ Item {
594594 property var menuModel: menuFactory.menuModel
595595 property int menuIndex: -1
596596 property var actionState: menuData && menuData.actionState || undefined
597+ property bool running: getExtendedProperty(actionState, "running", false)
597598
598599 playerIcon: menuData && menuData.icon || "image://theme/stock_music"
599− playerName: menuData && menuData.label || ""
600+ playerName: menuData && menuData.label || i18n.tr("Nothing is playing")
600601
601602 albumArt: getExtendedProperty(actionState, "art-url", "image://theme/stock_music")
602603 song: getExtendedProperty(actionState, "title", "")
603604 artist: getExtendedProperty(actionState, "artist", "")
604605 album: getExtendedProperty(actionState, "album", "")
605− running: getExtendedProperty(actionState, "running", false)
606+ showTrack: running && (state == "Playing" || state == "Paused")
606607 state: getExtendedProperty(actionState, "state", "")
607608 enabled: menuData && menuData.sensitive || false
608609 highlightWhenPressed: false
tests/qmltests/Panel/Indicators/tst_MenuItemFactory.qml+16−3
@@ -638,7 +638,8 @@ Item {
638638 album: "album1",
639639 running: true,
640640 state: "Playing",
641− enabled: true
641+ enabled: true,
642+ showTrack: true
642643 },{
643644 label: "player2",
644645 icon: "file:://icon2",
@@ -648,7 +649,19 @@ Item {
648649 album: "album2",
649650 running: false,
650651 state: "Paused",
651− enabled: false
652+ enabled: false,
653+ showTrack: false
654+ },{
655+ label: "player3",
656+ icon: "file:://icon3",
657+ albumArt: "file:://art3",
658+ song: "song3",
659+ artist: "artist3",
660+ album: "album3",
661+ running: true,
662+ state: "Stopped",
663+ enabled: true,
664+ showTrack: false
652665 }
653666 ];
654667 }
@@ -678,7 +691,7 @@ Item {
678691 compare(loader.item.song, data.song, "Song does not match data");
679692 compare(loader.item.artist, data.artist, "Artist does not match data");
680693 compare(loader.item.album, data.album, "Album does not match data");
681− compare(loader.item.running, data.running, "Running does not match data");
694+ compare(loader.item.showTrack, data.showTrack, "Show track does not match data");
682695 compare(loader.item.state, data.state, "State does not match data");
683696 compare(loader.item.enabled, data.enabled, "Enabled does not match data");
684697 }