on xenial help sign in
Only update the "section" if we are not culling the item

If the item is not shown we should not care about its section. Approved by Michael Zanetti, PS Jenkins bot.

commitd8e5d9ae23add066dbc0cb382d9f06b2a661da4c authorAlbert Astals <albert.astals@canonical.com> dateThu 1 Aug 2013, 19:36 (13 years ago) parent5dc028849b22cd
1 file changed+5−5
plugins/ListViewWithPageHeader/listviewwithpageheader.cpp+5−5
plugins/ListViewWithPageHeader/listviewwithpageheader.cpp+5−5
@@ -1037,11 +1037,6 @@ void ListViewWithPageHeader::layout()
10371037 if (!cull && firstReallyVisibleItem == -1) {
10381038 firstReallyVisibleItem = modelIndex;
10391039 if (m_topSectionItem) {
1040− // Update the top sticky section header
1041− const QString section = m_delegateModel->stringValue(modelIndex, m_sectionProperty);
1042− QQmlContext *context = QQmlEngine::contextForObject(m_topSectionItem)->parentContext();
1043− context->setContextProperty(QLatin1String("section"), section);
1044−
10451040 // Positing the top section sticky item is a two step process
10461041 // First we set it either we cull it (because it doesn't need to be sticked to the top)
10471042 // or stick it to the top
@@ -1058,6 +1053,11 @@ void ListViewWithPageHeader::layout()
10581053 QQuickItemPrivate::get(item->m_sectionItem)->setCulled(false);
10591054 }
10601055 } else {
1056+ // Update the top sticky section header
1057+ const QString section = m_delegateModel->stringValue(modelIndex, m_sectionProperty);
1058+ QQmlContext *context = QQmlEngine::contextForObject(m_topSectionItem)->parentContext();
1059+ context->setContextProperty(QLatin1String("section"), section);
1060+
10611061 QQuickItemPrivate::get(m_topSectionItem)->setCulled(false);
10621062 m_topSectionItem->setY(topSectionStickPos);
10631063 if (item->m_sectionItem) {