on xenial help sign in
Merge refactor-carousel-activation.
commitdfaee26fc89fa6f01394b9a1c6b8a0f4d42e54a3 authorMichał Sawicz <michal.sawicz@canonical.com> dateWed 9 Jul 2014, 15:59 (12 years ago) parente5fe9b903d74e2
6 files changed+31−33
qml/Components/PageHeader.qml+2−1 tests/autopilot/unity8/shell/emulators/dash.py+27−24 tests/autopilot/unity8/shell/emulators/main_window.py−5 tests/autopilot/unity8/shell/tests/test_emulators.py−1 tests/qmltests/Dash/tst_DashContent.qml+1−1 tests/qmltests/Dash/tst_GenericScopeView.qml+1−1
qml/Components/PageHeader.qml+2−1
@@ -23,6 +23,7 @@ import "SearchHistoryModel"
2323
2424Item {
2525 id: root
26+ objectName: "pageHeader"
2627 implicitHeight: headerContainer.height + units.gu(2) + bottomContainer.height
2728
2829 property bool showBackButton: false
@@ -207,7 +208,7 @@ Item {
207208
208209 PageHeadStyle {
209210 id: header
210− objectName: "pageHeader"
211+ objectName: "innerPageHeader"
211212 anchors { left: parent.left; right: parent.right }
212213 height: headerContainer.height
213214 contentHeight: height
tests/autopilot/unity8/shell/emulators/dash.py+27−24
@@ -108,44 +108,47 @@ class Dash(emulators.UnityEmulatorBase):
108108 @autopilot_logging.log_action(logger.info)
109109 def _scroll_to_left_scope(self):
110110 original_index = self.dash_content_list.currentIndex
111− # Scroll on the border of the page header, because some scopes have
112− # contents that can be scrolled horizontally.
113− page_header = self._get_page_header()
114− border = page_header.select_single('QQuickBorderImage')
115− start_x = border.width / 3
116− stop_x = border.width / 3 * 2
117− start_y = stop_y = border.globalRect.y + border.height / 2
111+ dashContent = self.select_single(objectName="dashContent")
112+ start_x = dashContent.width / 3
113+ stop_x = dashContent.width / 3 * 2
114+ start_y = stop_y = dashContent.globalRect.y + 1
118115 self.pointing_device.drag(start_x, start_y, stop_x, stop_y)
119116 self.dash_content_list.currentIndex.wait_for(original_index - 1)
120117
121− def _get_page_header(self):
122− return self.select_single('PageHeader', objectName='pageHeader')
123−
124118 @autopilot_logging.log_action(logger.info)
125119 def _scroll_to_right_scope(self):
126120 original_index = self.dash_content_list.currentIndex
127− # Scroll on the border of the page header, because some scopes have
128− # contents that can be scrolled horizontally.
129− page_header = self._get_page_header()
130− border = page_header.select_single('QQuickBorderImage')
131− start_x = border.width / 3 * 2
132− stop_x = border.width / 3
133− start_y = stop_y = border.globalRect.y + border.height / 2
121+ dashContent = self.select_single(objectName="dashContent")
122+ start_x = dashContent.width / 3 * 2
123+ stop_x = dashContent.width / 3
124+ start_y = stop_y = dashContent.globalRect.y + 1
134125 self.pointing_device.drag(start_x, start_y, stop_x, stop_y)
135126 self.dash_content_list.currentIndex.wait_for(original_index + 1)
136127
137128 def enter_search_query(self, query):
129+ current_header = self._get_current_page_header()
130+ self.pointing_device.move(current_header.globalRect.x +
131+ current_header.width - current_header.height / 2,
132+ current_header.globalRect.y +
133+ current_header.height / 2)
134+ self.pointing_device.click()
135+ headerContainer = current_header.select_single(objectName="headerContainer")
136+ headerContainer.contentY.wait_for(0)
138137 search_text_field = self._get_search_text_field()
139138 search_text_field.write(query)
140− search_text_field.state.wait_for('idle')
139+ current_header.select_single(objectName="searchIndicator").running.wait_for(False)
141140
142141 def _get_search_text_field(self):
143− page_header = self._get_page_header()
144− search_container = page_header.select_single(
145− 'QQuickItem', objectName='searchContainer')
146− search_container.state.wait_for(
147− MatchesAny(Equals('narrowActive'), Equals('active')))
148− return search_container.select_single(toolkit_emulators.TextField)
142+ page_header = self._get_current_page_header()
143+ return page_header.select_single(objectName='searchTextField')
144+
145+ def _get_current_page_header(self):
146+ dashContentList = self.select_single(objectName="dashContentList")
147+ all_headers = dashContentList.select_many("QQuickLoader")
148+ for i in all_headers:
149+ if i.isCurrent:
150+ return i.select_single(objectName="pageHeader")
151+ return None
149152
150153
151154class GenericScopeView(emulators.UnityEmulatorBase):
tests/autopilot/unity8/shell/emulators/main_window.py−5
@@ -133,9 +133,4 @@ class QQuickView(emulators.UnityEmulatorBase):
133133
134134 @autopilot_logging.log_action(logger.info)
135135 def search(self, query):
136− search_indicator = self._get_search_indicator()
137− self.pointing_device.click_object(search_indicator)
138136 self.get_dash().enter_search_query(query)
139−
140− def _get_search_indicator(self):
141− return self.select_single('SearchIndicator', objectName='search')
tests/autopilot/unity8/shell/tests/test_emulators.py−1
@@ -50,7 +50,6 @@ class MainWindowTestCase(tests.UnityTestCase):
5050 self.main_window.search('Test')
5151 text_field = self.main_window.get_dash()._get_search_text_field()
5252 self.assertEqual(text_field.text, 'Test')
53− self.assertEqual(text_field.state, 'idle')
5453
5554
5655class DashBaseTestCase(tests.UnityTestCase):
tests/qmltests/Dash/tst_DashContent.qml+1−1
@@ -193,7 +193,7 @@ Item {
193193 dashContent.setCurrentScopeAtIndex(data.index, true, false);
194194 tryCompareFunction(get_current_item_object_name, data.objectName)
195195 var scopeView = findChild(dashContent, data.objectName);
196− var pageHeader = findChild(scopeView, "pageHeader");
196+ var pageHeader = findChild(scopeView, "innerPageHeader");
197197 compare(pageHeader.title, scopesModel.getScope(data.index).name);
198198 }
199199
tests/qmltests/Dash/tst_GenericScopeView.qml+1−1
@@ -198,7 +198,7 @@ Item {
198198 }
199199
200200 function closePreview() {
201− var closePreviewMouseArea = findChild(genericScopeView, "pageHeader");
201+ var closePreviewMouseArea = findChild(genericScopeView, "innerPageHeader");
202202 mouseClick(closePreviewMouseArea, units.gu(2), units.gu(2));
203203
204204 tryCompare(testCase.previewListView, "open", false);