git.iko.soy/unity8
on xenial help sign in
Remove the signals

We have the pageHeader ourselves, so we can just do it in GenericScopeView

commite24481590842603d8fad124c8f702380e67c4d6d authorAlbert Astals <albert.astals@canonical.com> dateTue 7 Jan 2014, 17:59 (13 years ago) parent1855b1d
2 files changed+2−10
compare with xenial
unifiedsplit
qml/Dash/DashContent.qml−6 qml/Dash/GenericScopeView.qml+2−4
qml/Dash/DashContent.qml−6
@@ -148,12 +148,6 @@ Item {
148148 target: item
149149 ignoreUnknownSignals: true
150150 onEndReached: contentEndReached()
151− onHeaderPositionChanged: {
152− pageHeader.y = position;
153− }
154− onHeaderHeightChanged: {
155− pageHeader.height = height;
156− }
157151 }
158152
159153 Component.onDestruction: active = false
qml/Dash/GenericScopeView.qml+2−4
@@ -36,8 +36,6 @@ FocusScope {
3636 signal endReached
3737 signal movementStarted
3838 signal positionedAtBeginning
39− signal headerPositionChanged(int position)
40− signal headerHeightChanged(int height)
4139
4240 property bool enableHeightBehaviorOnNextCreation: false
4341 property var categoryView: categoryView
@@ -301,11 +299,11 @@ FocusScope {
301299 }
302300 pageHeader: Item {
303301 implicitHeight: scopeView.tabBarHeight
304− onHeightChanged: scopeView.headerHeightChanged(height)
302+ onHeightChanged: scopeView.pageHeader.height = height;
305303 onYChanged: positionRealHeader();
306304
307305 function positionRealHeader() {
308− scopeView.headerPositionChanged(y + parent.y)
306+ scopeView.pageHeader.y = y + parent.y;
309307 }
310308 }
311309 }