e54d85c · unity8 · git.iko.soy

on xenial help sign in

Fix some review comments

e54d85cMichael Terry11 years ago

plugins/Wizard/timezonemodel.cpp+6−6

@@ -60,12 +60,12 @@ QVariant TimeZoneLocationModel::data(const QModelIndex &index, int role) const

61 switch (role) {

62 case Qt::DisplayRole:

63− return QVariant(QString("%1, %2, %3").arg(geonames_city_get_name(city))

63+ return QStringLiteral("%1, %2, %3").arg(geonames_city_get_name(city))

64− .arg(geonames_city_get_state(city))

64+ .arg(geonames_city_get_state(city))

65− .arg(geonames_city_get_country(city)));

65+ .arg(geonames_city_get_country(city));

66 case SimpleRole:

67− return QVariant(QString("%1, %2").arg(geonames_city_get_name(city))

67+ return QStringLiteral("%1, %2").arg(geonames_city_get_name(city))

68− .arg(geonames_city_get_country(city)));

68+ .arg(geonames_city_get_country(city));

69 case TimeZoneRole:

70 return geonames_city_get_timezone(city);

71 case CountryRole:

@@ -91,7 +91,7 @@ QHash<int, QByteArray> TimeZoneLocationModel::roleNames() const

91 return m_roleNames;

92}

94−void TimeZoneLocationModel::setModel(QList<GeonamesCity *> locations)

94+void TimeZoneLocationModel::setModel(const QList<GeonamesCity *> &locations)

95{

96 beginResetModel();

plugins/Wizard/timezonemodel.h+1−1

@@ -61,7 +61,7 @@ Q_SIGNALS:

61 void countryChanged(const QString &country);

63private:

64− void setModel(QList<GeonamesCity *> locations);

64+ void setModel(const QList<GeonamesCity *> &locations);

65 void setListUpdating(bool listUpdating);

66 static void filterFinished(GObject *source_object,

67 GAsyncResult *res,