git.iko.soy/unity8
on xenial help sign in
Pass SharedTimeSource by const reference instead of by value

To save some cpu cycles

commited2e6b144e1394d77acb4432812cdbb268969975 authorDaniel d'Andrada <daniel.dandrada@canonical.com> dateWed 23 Oct 2013, 10:25 (13 years ago) parenta5c2b98
5 files changed+9−9
compare with xenial
unifiedsplit
plugins/Ubuntu/Gestures/AxisVelocityCalculator.cpp+2−2 plugins/Ubuntu/Gestures/AxisVelocityCalculator.h+2−2 plugins/Ubuntu/Gestures/DirectionalDragArea.cpp+2−2 plugins/Ubuntu/Gestures/DirectionalDragArea.h+2−2 tests/plugins/Ubuntu/Gestures/tst_DirectionalDragArea.cpp+1−1
plugins/Ubuntu/Gestures/AxisVelocityCalculator.cpp+2−2
@@ -28,7 +28,7 @@ AxisVelocityCalculator::AxisVelocityCalculator(QObject *parent)
2828{
2929}
3030
31−AxisVelocityCalculator::AxisVelocityCalculator(SharedTimeSource timeSource,
31+AxisVelocityCalculator::AxisVelocityCalculator(const SharedTimeSource &timeSource,
3232 QObject *parent)
3333 : QObject(parent)
3434 , m_timeSource(timeSource)
@@ -136,7 +136,7 @@ int AxisVelocityCalculator::numSamples() const
136136 }
137137}
138138
139−void AxisVelocityCalculator::setTimeSource(SharedTimeSource timeSource)
139+void AxisVelocityCalculator::setTimeSource(const SharedTimeSource &timeSource)
140140{
141141 m_timeSource = timeSource;
142142
plugins/Ubuntu/Gestures/AxisVelocityCalculator.h+2−2
@@ -68,7 +68,7 @@ public:
6868 /*
6969 Constructor that takes a TimeSource
7070 */
71− AxisVelocityCalculator(UbuntuGestures::SharedTimeSource timeSource, QObject *parent = 0);
71+ AxisVelocityCalculator(const UbuntuGestures::SharedTimeSource &timeSource, QObject *parent = 0);
7272
7373 virtual ~AxisVelocityCalculator();
7474
@@ -90,7 +90,7 @@ public:
9090 /*
9191 Replaces the TimeSource with the given one. Useful for testing purposes.
9292 */
93− void setTimeSource(UbuntuGestures::SharedTimeSource timeSource);
93+ void setTimeSource(const UbuntuGestures::SharedTimeSource &timeSource);
9494
9595 /*
9696 The minimum amount of samples needed for a velocity calculation.
plugins/Ubuntu/Gestures/DirectionalDragArea.cpp+2−2
@@ -221,7 +221,7 @@ void DirectionalDragArea::setRecognitionTimer(UbuntuGestures::AbstractTimer *tim
221221 }
222222}
223223
224−void DirectionalDragArea::setTimeSource(UbuntuGestures::SharedTimeSource timeSource)
224+void DirectionalDragArea::setTimeSource(const SharedTimeSource &timeSource)
225225{
226226 m_timeSource = timeSource;
227227 m_velocityCalculator->setTimeSource(timeSource);
@@ -601,7 +601,7 @@ bool DirectionalDragArea::isWithinTouchCompositionWindow()
601601
602602//************************** ActiveTouchesInfo **************************
603603
604−DirectionalDragArea::ActiveTouchesInfo::ActiveTouchesInfo(UbuntuGestures::SharedTimeSource timeSource)
604+DirectionalDragArea::ActiveTouchesInfo::ActiveTouchesInfo(const SharedTimeSource &timeSource)
605605 : m_timeSource(timeSource)
606606{
607607 // Estimate of the maximum number of active touches we might reach.
plugins/Ubuntu/Gestures/DirectionalDragArea.h+2−2
@@ -193,7 +193,7 @@ public:
193193 void setRecognitionTimer(UbuntuGestures::AbstractTimer *timer);
194194
195195 // Useful for testing, where a fake time source can be supplied
196− void setTimeSource(UbuntuGestures::SharedTimeSource timeSource);
196+ void setTimeSource(const UbuntuGestures::SharedTimeSource &timeSource);
197197
198198Q_SIGNALS:
199199 void directionChanged(Direction::Type direction);
@@ -268,7 +268,7 @@ private:
268268 };
269269 class ActiveTouchesInfo : public QVector<struct ActiveTouchInfo> {
270270 public:
271− ActiveTouchesInfo(UbuntuGestures::SharedTimeSource timeSource);
271+ ActiveTouchesInfo(const UbuntuGestures::SharedTimeSource &timeSource);
272272 void update(QTouchEvent *event);
273273 ActiveTouchInfo &touchInfo(int id);
274274 qint64 mostRecentStartTime();
tests/plugins/Ubuntu/Gestures/tst_DirectionalDragArea.cpp+1−1
@@ -29,7 +29,7 @@ class FakeTimer : public AbstractTimer
2929{
3030 Q_OBJECT
3131public:
32− FakeTimer(SharedTimeSource timeSource, QObject *parent = 0)
32+ FakeTimer(const SharedTimeSource &timeSource, QObject *parent = 0)
3333 : UbuntuGestures::AbstractTimer(parent),
3434 m_timeSource(timeSource)
3535 {}