on xenial help sign in
Fix interaction papercuts with the Wizard

There are a couple of small issues when interacting with the 16.04 update wizard. The first is that the app update page Stop button is ineffective. My solution to this is removing it altogether since stopping the updater in the wizard could cause user confusion later when their apps don't work correctly. Also, after hours of troubleshooting I'm still not sure why the check won't move to another thread like in its home, system-settings. Another problem is that the flow to unlock a SIM is not available in the Wizard, so the app update page may not be able to connect to the internet. Instead of implementing the SIM unlock in the Wizard, I've made it clear that updates can be found in the OpenStore app after the device has been connected. See: https://github.com/ubports/ubuntu-touch/issues/842

commiteefa5c830ce8d82728fcf2255ca9d8354a632501 authorDalton Durst <me@daltondurst.com> dateFri 28 Sep 2018, 14:15 (8 years ago) parent10697b6
3 files changed+20−10
debian/changelog+8 qml/Wizard/Pages/76-app-update.qml+12−3 qml/Wizard/Pages/GlobalUpdateControls.qml−7
debian/changelog+8
@@ -1,3 +1,11 @@
1+unity8 (8.17+ubports3) xenial; urgency=medium
2+
3+ * Fix papercuts in Wizard update page interaction:
4+ * Remove "Stop" button for app update check
5+ * Make "not connected to internet" message more clear
6+
7+ -- Dalton Durst <dalton@ubports.com> Fri, 28 Sep 2018 14:08:00 -0500
8+
19unity8 (8.17+ubports2) xenial; urgency=medium
210
311 * Fix for https://github.com/ubports/ubuntu-touch/issues/624
qml/Wizard/Pages/76-app-update.qml+12−3
@@ -124,12 +124,14 @@ LocalComponents.Page {
124124 text: {
125125 var s = UpdateManager.status;
126126 if (!appUpdatePage.online) {
127− return i18n.tr("Connect to the Internet to check for updates.");
127+ return i18n.tr("This device is not connected to the internet.") + " " +
128+ i18n.tr("Use the OpenStore app to check for updates once connected.");
128129 } else if (s === UpdateManager.StatusIdle && updatesCount === 0) {
129130 return i18n.tr("Software is up to date");
130131 } else if (s === UpdateManager.StatusServerError ||
131132 s === UpdateManager.StatusNetworkError) {
132− return i18n.tr("The update server is not responding. Try again later.");
133+ return i18n.tr("The update server is not responding.") + " " +
134+ i18n.tr("Use the OpenStore app to check for updates once connected.");
133135 }
134136 return "";
135137 }
@@ -228,7 +230,14 @@ LocalComponents.Page {
228230 Component {
229231 id: forwardButton
230232 LocalComponents.StackButton {
231− text: (UpdateManager.status === UpdateManager.StatusIdle && updatesCount === 0) ? i18n.tr("Next") : i18n.tr("Skip")
233+ text: {
234+ var s = UpdateManager.status;
235+ if (s === UpdateManager.StatusIdle && updatesCount === 0) {
236+ return i18n.tr("Next");
237+ } else {
238+ return i18n.tr("Skip");
239+ }
240+ }
232241 onClicked: pageStack.next()
233242 }
234243 }
qml/Wizard/Pages/GlobalUpdateControls.qml−7
@@ -83,13 +83,6 @@ Item {
8383 elide: Text.ElideRight
8484 text: i18n.tr("Checking for updates…")
8585 }
86−
87− Button {
88− objectName: "updatesGlobalStopButton"
89− text: i18n.tr("Stop")
90− onClicked: g.stop()
91− Layout.alignment: Qt.AlignRight | Qt.AlignVCenter
92− }
9386 }
9487
9588 RowLayout {