git.iko.soy/unity8
on xenial help sign in
Better wait for it to check for growth to have stopped
commitf5d471a4bbb1679c6b0c03b3be3653fe2f9ce7e0 authorAlbert Astals Cid <albert.astals@canonical.com> dateMon 30 Nov 2015, 15:41 (11 years ago) parent0eebe47
2 files changed+3−7
compare with xenial
unifiedsplit
qml/Dash/Filters/FilterOptionSelector.qml+1 tests/qmltests/Dash/Filters/tst_FilterOptionSelector.qml+2−7
qml/Dash/Filters/FilterOptionSelector.qml+1
@@ -27,6 +27,7 @@ FilterWidget {
2727
2828 ListItems.Expandable {
2929 id: expandingItem
30+ objectName: "expandingItem"
3031
3132 expandedHeight: collapsedHeight + column.height
3233 width: parent.width
tests/qmltests/Dash/Filters/tst_FilterOptionSelector.qml+2−7
@@ -70,16 +70,11 @@ Rectangle {
7070 when: windowShown
7171
7272 function test_optionSelector() {
73− var initialHeight = factory.implicitHeight;
74− var currentHeight = 0;
73+ var expandingItem = findChild(factory, "expandingItem");
7574 // Open the selector
7675 mouseClick(factory);
7776 // wait for it to stop growing
78− while (currentHeight != factory.implicitHeight) {
79− currentHeight = factory.implicitHeight;
80− wait(250);
81− }
82− verify(initialHeight < currentHeight);
77+ tryCompare(factory, "implicitHeight", expandingItem.expandedHeight);
8378
8479 // Check the first option
8580 var option0 = findChild(factory, "testOptionSelectorFilterlabel0");