git.iko.soy/unity8
on xenial help sign in
drop some debug prints from mocked applicationmanager
commitf7114ad8eb3389624e5bdfc401ea52b0a7c5286b authorMichael Zanetti <michael.zanetti@canonical.com> dateThu 20 Mar 2014, 10:45 (13 years ago) parenta6eaa8c
3 files changed+1−11
compare with xenial
unifiedsplit
tests/mocks/Unity/Application/ApplicationInfo.h−1 tests/mocks/Unity/Application/ApplicationManager.cpp−7 tests/mocks/Unity/Application/ApplicationScreenshotProvider.cpp+1−3
tests/mocks/Unity/Application/ApplicationInfo.h−1
@@ -19,7 +19,6 @@
1919
2020#include <QObject>
2121#include <QQmlComponent>
22−#include <QDebug>
2322
2423class QQuickItem;
2524
tests/mocks/Unity/Application/ApplicationManager.cpp−7
@@ -26,7 +26,6 @@
2626#include <QQmlComponent>
2727#include <QTimer>
2828#include <QDateTime>
29−#include <QDebug>
3029
3130ApplicationManager::ApplicationManager(QObject *parent)
3231 : ApplicationManagerInterface(parent)
@@ -94,7 +93,6 @@ void ApplicationManager::add(ApplicationInfo *application) {
9493 if (!application) {
9594 return;
9695 }
97− qDebug() << "add() " << application->appId();
9896
9997 beginInsertRows(QModelIndex(), m_runningApplications.size(), m_runningApplications.size());
10098 m_runningApplications.append(application);
@@ -198,13 +196,11 @@ bool ApplicationManager::stopApplication(const QString &appId)
198196 unfocusCurrentApplication();
199197 }
200198 remove(application);
201− qDebug() << Q_FUNC_INFO << "emitting focusedAppChanged" << focusedApplicationId();
202199 return true;
203200}
204201
205202bool ApplicationManager::updateScreenshot(const QString &appId)
206203{
207− qDebug() << "updating screenshot for" << appId;
208204 int idx = -1;
209205 ApplicationInfo *application = nullptr;
210206 for (int i = 0; i < m_availableApplications.count(); ++i) {
@@ -221,7 +217,6 @@ bool ApplicationManager::updateScreenshot(const QString &appId)
221217
222218 application->setScreenshot(QString("image://application/%1/%2").arg(appId).arg(QDateTime::currentMSecsSinceEpoch()));
223219 QModelIndex appIndex = index(idx);
224− qDebug() << "emitting dataChanged for RoleScreenshot on" << appId;
225220 Q_EMIT dataChanged(appIndex, appIndex, QVector<int>() << RoleScreenshot);
226221 return true;
227222}
@@ -298,7 +293,6 @@ bool ApplicationManager::focusApplication(const QString &appId)
298293
299294 // move app to top of stack
300295 move(m_runningApplications.indexOf(application), 0);
301− qDebug() << Q_FUNC_INFO << "emitting focusedAppChanged" << focusedApplicationId();
302296 Q_EMIT focusedApplicationIdChanged();
303297 return true;
304298}
@@ -320,7 +314,6 @@ void ApplicationManager::unfocusCurrentApplication()
320314 app->setFocused(false);
321315 }
322316 }
323− qDebug() << Q_FUNC_INFO << "emitting focusedAppChanged" << focusedApplicationId();
324317 Q_EMIT focusedApplicationIdChanged();
325318}
326319
tests/mocks/Unity/Application/ApplicationScreenshotProvider.cpp+1−3
@@ -41,7 +41,6 @@ QImage ApplicationScreenshotProvider::requestImage(const QString &imageId, QSize
4141
4242 ApplicationInfo* app = static_cast<ApplicationInfo*>(m_appManager->findApplication(appId));
4343 if (app == NULL) {
44− qDebug() << "ApplicationScreenshotProvider - app not found:" << appId;
4544 return QImage();
4645 }
4746
@@ -49,7 +48,7 @@ QImage ApplicationScreenshotProvider::requestImage(const QString &imageId, QSize
4948
5049 QImage image;
5150 if (!image.load(filePath)) {
52− qDebug() << "failed loading app image" << filePath;
51+ qWarning() << "failed loading app image" << filePath;
5352 }
5453
5554 QGuiApplication *unity = qobject_cast<QGuiApplication*>(qApp);
@@ -68,7 +67,6 @@ QImage ApplicationScreenshotProvider::requestImage(const QString &imageId, QSize
6867
6968 size->setWidth(image.width());
7069 size->setHeight(image.height());
71− qDebug() << "got image of size" << size->width() << size->height() << requestedSize;
7270
7371 return image;
7472}