f7d59dd · unity8 · git.iko.soy

on xenial help sign in

fix window control buttons not reachable with the 3-finger overlay

f7d59ddLukáš Tinkl10 years ago

qml/Stage/WindowControlsOverlay.qml+1−1

@@ -184,7 +184,7 @@ Item {

184 }

185

186 overlayTimer.stop();

187− mouse.accepted = root.contains(mapToItem(root.target, mouse.x, mouse.y));

187+ mouse.accepted = root.contains(mapToItem(root.target.clientAreaItem, mouse.x, mouse.y));

188 }

189 propagateComposedEvents: true

190 }

tests/qmltests/Stage/tst_DesktopStage.qml+16

@@ -689,6 +689,22 @@ Item {

689 tryCompare(overlay, "visible", false);

690 }

691 }

692+

693+ function test_windowControlsOverlayMaximizeButtonReachable() {

694+ var facebookAppDelegate = startApplication("facebook-webapp");

695+ verify(facebookAppDelegate);

696+ var overlay = findChild(facebookAppDelegate, "windowControlsOverlay");

697+ verify(overlay);

698+

699+ multiTouchTap([0, 1, 2], facebookAppDelegate);

700+ tryCompare(overlay, "visible", true);

701+

702+ var maxButton = findChild(facebookAppDelegate, "maximizeWindowButton");

703+ tryCompare(maxButton, "visible", true);

704+ mouseClick(maxButton);

705+ tryCompare(facebookAppDelegate, "maximized", true);

706+ }

707+

692 function test_dashHasNoCloseButton() {

708 function test_dashHasNoCloseButton() {

693 var dashAppDelegate = startApplication("unity8-dash");

709 var dashAppDelegate = startApplication("unity8-dash");

694 verify(dashAppDelegate);

710 verify(dashAppDelegate);