on xenial help sign in
Skip unstable LVWPH tests.
fca4780Michał Sawicz
tests/plugins/DashViews/listviewwithpageheadertest.cpp+2−2
@@ -1281,9 +1281,8 @@ private Q_SLOTS:
1281
1281
1282 void testShowHeaderHalfShown()
1282 void testShowHeaderHalfShown()
1283 {
1283 {
1284−#if (QT_VERSION < QT_VERSION_CHECK(5, 1, 0))
1285 QSKIP("This test is extremely unstable in 5.0.x");
1284 QSKIP("This test is extremely unstable in 5.0.x");
1286−#endif
1285+
1287 changeContentY(20);
1286 changeContentY(20);
1288
1287
1289 QTRY_COMPARE(lvwph->m_visibleItems.count(), 4);
1288 QTRY_COMPARE(lvwph->m_visibleItems.count(), 4);
@@ -1851,6 +1850,7 @@ private Q_SLOTS:
1851
1850
1852 void testHeaderPositionBug1240118()
1851 void testHeaderPositionBug1240118()
1853 {
1852 {
1853+ QSKIP("This test is unstable.");
1854 scrollToBottom();
1854 scrollToBottom();
1855 lvwph->showHeader();
1855 lvwph->showHeader();
1856 QTRY_VERIFY(!lvwph->m_contentYAnimation->isRunning());
1856 QTRY_VERIFY(!lvwph->m_contentYAnimation->isRunning());
tests/plugins/DashViews/listviewwithpageheadertestsection.cpp+4−3
@@ -1486,9 +1486,8 @@ private Q_SLOTS:
1486
1486
1487 void testShowHeaderHalfShown()
1487 void testShowHeaderHalfShown()
1488 {
1488 {
1489−#if (QT_VERSION < QT_VERSION_CHECK(5, 1, 0))
1490− QSKIP("This test is extremely unstable in 5.0.x");
1489+ QSKIP("This test is extremely unstable.");
1491−#endif
1490+
1492 changeContentY(20);
1491 changeContentY(20);
1493
1492
1494 QTRY_COMPARE(lvwph->m_visibleItems.count(), 3);
1493 QTRY_COMPARE(lvwph->m_visibleItems.count(), 3);
@@ -2096,6 +2095,8 @@ private Q_SLOTS:
2096
2095
2097 void testDownAndUp()
2096 void testDownAndUp()
2098 {
2097 {
2098+ QSKIP("This test is unstable.");
2099+
2099 QMetaObject::invokeMethod(model, "removeItems", Q_ARG(QVariant, 1), Q_ARG(QVariant, 5));
2100 QMetaObject::invokeMethod(model, "removeItems", Q_ARG(QVariant, 1), Q_ARG(QVariant, 5));
2100
2101
2101 QTRY_COMPARE(lvwph->m_visibleItems.count(), 1);
2102 QTRY_COMPARE(lvwph->m_visibleItems.count(), 1);