on xenial help sign in
expand comments
fec14c1Michael Terry
qml/Shell.qml+9−2
@@ -210,7 +210,14 @@ Item {
210 objectName: "applicationsDisplayLoader"
210 objectName: "applicationsDisplayLoader"
211 anchors.fill: parent
211 anchors.fill: parent
212
212
213− // When we have a locked app, we only want to show that one app
213+ // When we have a locked app, we only want to show that one app.
214+ // FIXME: do this in a less traumatic way. We currently only allow
215+ // locked apps in phone mode (see FIXME in Lockscreen component in
216+ // this same file). When that changes, we need to do something
217+ // nicer here. But this code is currently just to prevent a
218+ // theoretical attack where user enters lockedApp mode, then makes
219+ // the screen larger (maybe connects to monitor) and tries to enter
220+ // tablet mode.
214 property bool tabletMode: shell.sideStageEnabled && !greeter.hasLockedApp
221 property bool tabletMode: shell.sideStageEnabled && !greeter.hasLockedApp
215 source: tabletMode ? "Stages/TabletStage.qml" : "Stages/PhoneStage.qml"
222 source: tabletMode ? "Stages/TabletStage.qml" : "Stages/PhoneStage.qml"
216
223
@@ -313,7 +320,7 @@ Item {
313 // and wider screens are tablets which don't. When we do allow this
320 // and wider screens are tablets which don't. When we do allow this
314 // on devices with a side stage and a SIM, work should be done to
321 // on devices with a side stage and a SIM, work should be done to
315 // ensure that the main stage is disabled while the dialer is present
322 // ensure that the main stage is disabled while the dialer is present
316− // in the side stage.
323+ // in the side stage. See the FIXME in the stage loader in this file.
317 showEmergencyCallButton: !shell.sideStageEnabled
324 showEmergencyCallButton: !shell.sideStageEnabled
318
325
319 onEntered: LightDM.Greeter.respond(passphrase);
326 onEntered: LightDM.Greeter.respond(passphrase);